From 5f3753e2317d598fbf6d65a97b3718824d0de4bb Mon Sep 17 00:00:00 2001
From: Chad Little <chad@chadsdomain.com>
Date: Fri, 5 Dec 2014 15:06:06 -0800
Subject: [PATCH] Clean up spacing, sizing on mobile app menus

Summary: Lots of minor spacing/alignment tweaks on mobile menus

Test Plan: set browser to 320 width, inspect for issues and alignments

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D10937
---
 resources/celerity/map.php                    |  6 ++--
 .../css/application/base/main-menu-view.css   | 35 ++++++++++++-------
 2 files changed, 26 insertions(+), 15 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 7bf2bd18ab..8752732e0c 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '75188459',
+    'core.pkg.css' => 'b95abae6',
     'core.pkg.js' => 'ef8f73ee',
     'darkconsole.pkg.js' => 'df001cab',
     'differential.pkg.css' => '8af45893',
@@ -35,7 +35,7 @@ return array(
     'rsrc/css/aphront/two-column.css' => '16ab3ad2',
     'rsrc/css/aphront/typeahead.css' => 'a989b5b3',
     'rsrc/css/application/auth/auth.css' => '1e655982',
-    'rsrc/css/application/base/main-menu-view.css' => '06acc232',
+    'rsrc/css/application/base/main-menu-view.css' => 'b2d8b1f8',
     'rsrc/css/application/base/notification-menu.css' => '6aa0a74b',
     'rsrc/css/application/base/phabricator-application-launch-view.css' => '5d71008f',
     'rsrc/css/application/base/standard-page-view.css' => '3f5b9311',
@@ -723,7 +723,7 @@ return array(
     'phabricator-hovercard-view-css' => '893f4783',
     'phabricator-keyboard-shortcut' => '1ae869f2',
     'phabricator-keyboard-shortcut-manager' => 'ad7a69ca',
-    'phabricator-main-menu-view' => '06acc232',
+    'phabricator-main-menu-view' => 'b2d8b1f8',
     'phabricator-nav-view-css' => '9283c2df',
     'phabricator-notification' => '0c6946e7',
     'phabricator-notification-css' => '9c279160',
diff --git a/webroot/rsrc/css/application/base/main-menu-view.css b/webroot/rsrc/css/application/base/main-menu-view.css
index 1a88b8a332..cb9be831c1 100644
--- a/webroot/rsrc/css/application/base/main-menu-view.css
+++ b/webroot/rsrc/css/application/base/main-menu-view.css
@@ -76,10 +76,10 @@
 */
 
 .phabricator-menu-button-icon {
-  width: 24px;
-  height: 24px;
+  width: 20px;
+  height: 32px;
   float: left;
-  margin: 10px 10px 0 5px;
+  margin: 10px 8px 0 8px;
 }
 
 .phabricator-menu-button-icon.phui-icon-view {
@@ -326,7 +326,7 @@
   text-transform: uppercase;
   font-size: 13px;
   background-color: #151719;
-  padding: 6px 0;
+  padding: 6px 0 6px 20px;
   display: block;
   font-weight: bold;
 }
@@ -336,7 +336,7 @@
   border-style: solid;
   border-color: #34373b transparent #282c2d;
   background-color: #272c2f;
-  padding: 4px 0 4px 16px;
+  padding: 4px 0 4px 20px;
   display: block;
 }
 
@@ -373,7 +373,7 @@
 
 .device .phui-list-item-type-link
   .phabricator-core-menu-icon + .phui-list-item-name {
-  margin-left: 30px;
+  margin-left: 32px;
 }
 
 .device-desktop .phabricator-application-menu {
@@ -393,16 +393,26 @@
   font-size: 20px;
   height: 20px;
   width: 20px;
-  color: #fff;
+  color: #d7d7d7;
   margin: 8px;
   text-align: center;
   vertical-align: middle;
 }
 
+.device .phabricator-application-menu .phui-list-item-icon.phui-font-fa {
+  margin: 4px 12px 4px 0;
+}
+
 .phabricator-application-menu .phui-list-item-icon.fa-plus {
   line-height: 22px;
 }
 
+.device-desktop .phabricator-application-menu
+  .core-menu-item.phui-list-item-view:hover
+  .phui-list-item-icon.phui-font-fa {
+    color: #fff;
+  }
+
 .device-desktop .phabricator-application-menu .phui-list-item-view.core-menu-item {
   display: block;
 }
@@ -416,6 +426,7 @@
  .core-menu-item.phui-list-item-view:hover {
   box-shadow: inset 0 5px 10px rgba(0,0,0,0.5);
   border-radius: 3px;
+  color: #fff;
 }
 
 .device-desktop .phabricator-application-menu .phui-list-item-view {
@@ -432,7 +443,11 @@
 }
 
 .device .phabricator-core-menu-icon {
-  left: 24px;
+  left: 16px;
+  height: 24px;
+  width: 24px;
+  background-size: 24px;
+  margin: 2px;
 }
 
 .phabricator-core-menu-icon {
@@ -469,10 +484,6 @@
   display: none;
 }
 
-.phabricator-application-menu .phui-list-item-name {
-  padding-left: 12px;
-}
-
 
 /* - Print ---------------------------------------------------------------------
 */