mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-09 16:32:39 +01:00
Correct PHPDoc return value for loadObject() in PhabricatorObjectMailReceiver
Summary: The PHPDoc for the abstract function `loadObject()` defines `@return void`, however the function's return value is used twice in `PhabricatorObjectMailReceiver` and all 17 `loadObject()` implementations in child classes return an object provided by some type of `PhabricatorCursorPagedPolicyAwareQuery`. Thus correct the PHPDoc to make static code analyzers happier. Test Plan: Carefully read and compare the code. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25654
This commit is contained in:
parent
98884f758a
commit
5f565e2ab6
1 changed files with 2 additions and 1 deletions
|
@ -22,7 +22,8 @@ abstract class PhabricatorObjectMailReceiver extends PhabricatorMailReceiver {
|
|||
* @param string A string matched by @{method:getObjectPattern}
|
||||
* fragment.
|
||||
* @param PhabricatorUser The viewing user.
|
||||
* @return void
|
||||
* @return object|null The object to receive mail, or null if no such
|
||||
* object exists.
|
||||
*/
|
||||
abstract protected function loadObject($pattern, PhabricatorUser $viewer);
|
||||
|
||||
|
|
Loading…
Reference in a new issue