mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-19 12:00:55 +01:00
Fix variable issue on Conpherence draft saving pathway
Summary: When we save a Conpherence draft, the draft part works fine but `$xactions` never gets defined, so this gets hit a little later on: [24-Feb-2014 11:46:10] WARNING: [pool www] child 82805 said into stderr: "NOTICE: PHP message: [2014-02-24 11:46:10] EXCEPTION: (RuntimeException) Undefined variable: xactions at [/INSECURE/devtools/libphutil/src/error/PhutilErrorHandler.php:211]" [24-Feb-2014 11:46:10] WARNING: [pool www] child 82805 said into stderr: "NOTICE: PHP message: #0 PhutilErrorHandler::handleError(8, Undefined variable: xactions, /INSECURE/devtools/phabricator/src/applications/conpherence/controller/ConpherenceUpdateController.php, 122, Array of size 13 starting with: { request => Object AphrontRequest }) called at [/INSECURE/devtools/phabricator/src/applications/conpherence/controller/ConpherenceUpdateController.php:122]" [24-Feb-2014 11:46:10] WARNING: [pool www] child 82805 said into stderr: "NOTICE: PHP message: #1 ConpherenceUpdateController::processRequest() called at [/INSECURE/devtools/phabricator/webroot/index.php:87]" Instead, define `$xactions`. Test Plan: - Type into Conpherence while tailing the error log. - After patch, clean error log. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D8323
This commit is contained in:
parent
14627ad65b
commit
5f95f2b6d5
1 changed files with 1 additions and 3 deletions
|
@ -37,6 +37,7 @@ final class ConpherenceUpdateController
|
|||
$e_file = array();
|
||||
$errors = array();
|
||||
$delete_draft = false;
|
||||
$xactions = array();
|
||||
if ($request->isFormPost()) {
|
||||
$editor = id(new ConpherenceEditor())
|
||||
->setContinueOnNoEffect($request->isContinueRequest())
|
||||
|
@ -59,7 +60,6 @@ final class ConpherenceUpdateController
|
|||
$delete_draft = true;
|
||||
break;
|
||||
case ConpherenceUpdateActions::ADD_PERSON:
|
||||
$xactions = array();
|
||||
$person_phids = $request->getArr('add_person');
|
||||
if (!empty($person_phids)) {
|
||||
$xactions[] = id(new ConpherenceTransaction())
|
||||
|
@ -69,7 +69,6 @@ final class ConpherenceUpdateController
|
|||
}
|
||||
break;
|
||||
case ConpherenceUpdateActions::REMOVE_PERSON:
|
||||
$xactions = array();
|
||||
if (!$request->isContinueRequest()) {
|
||||
// do nothing; we'll display a confirmation dialogue instead
|
||||
break;
|
||||
|
@ -95,7 +94,6 @@ final class ConpherenceUpdateController
|
|||
->setContent($result);
|
||||
break;
|
||||
case ConpherenceUpdateActions::METADATA:
|
||||
$xactions = array();
|
||||
$updated = false;
|
||||
// all metadata updates are continue requests
|
||||
if (!$request->isContinueRequest()) {
|
||||
|
|
Loading…
Reference in a new issue