revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-18 02:31:10 +01:00
Code Issues Releases Wiki Activity

Simplify drag-and-drop list implementations

Browse source 
Summary:
  - Use the same styles for shared operations (`drag-ghost`, `drag-dragging`).
  - Move shared code into the base class.

Test Plan: Dragged around tasks and named queries.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D6141
This commit is contained in:
epriestley 2013-06-05 17:36:33 -07:00
parent d0bb4e1c93
commit 5f98c5f386
7 changed files with 97 additions and 129 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

142
src/__celerity_resource_map__.php
View file

@ -1797,16 +1797,15 @@ celerity_register_resource_map(array(
), ),
'javelin-behavior-maniphest-subpriority-editor' => 'javelin-behavior-maniphest-subpriority-editor' =>
array( array(
'uri' => '/res/57540d92/rsrc/js/application/maniphest/behavior-subpriorityeditor.js', 'uri' => '/res/99d84c61/rsrc/js/application/maniphest/behavior-subpriorityeditor.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
0 => 'javelin-behavior', 0 => 'javelin-behavior',
1 => 'javelin-dom', 1 => 'javelin-dom',
2 => 'javelin-vector', 2 => 'javelin-stratcom',
3 => 'javelin-stratcom', 3 => 'javelin-workflow',
4 => 'javelin-workflow', 4 => 'phabricator-draggable-list',
5 => 'phabricator-draggable-list',
), ),
'disk' => '/rsrc/js/application/maniphest/behavior-subpriorityeditor.js', 'disk' => '/rsrc/js/application/maniphest/behavior-subpriorityeditor.js',
), ),
@ -2273,16 +2272,15 @@ celerity_register_resource_map(array(
), ),
'javelin-behavior-search-reorder-queries' => 'javelin-behavior-search-reorder-queries' =>
array( array(
'uri' => '/res/47148be5/rsrc/js/application/search/behavior-reorder-queries.js', 'uri' => '/res/9864b481/rsrc/js/application/search/behavior-reorder-queries.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
0 => 'javelin-behavior', 0 => 'javelin-behavior',
1 => 'javelin-vector', 1 => 'javelin-stratcom',
2 => 'javelin-stratcom', 2 => 'javelin-workflow',
3 => 'javelin-workflow', 3 => 'javelin-dom',
4 => 'javelin-dom', 4 => 'phabricator-draggable-list',
5 => 'phabricator-draggable-list',
), ),
'disk' => '/rsrc/js/application/search/behavior-reorder-queries.js', 'disk' => '/rsrc/js/application/search/behavior-reorder-queries.js',
), ),
@ -2820,7 +2818,7 @@ celerity_register_resource_map(array(
), ),
'maniphest-task-summary-css' => 'maniphest-task-summary-css' =>
array( array(
'uri' => '/res/7aa9e2eb/rsrc/css/application/maniphest/task-summary.css', 'uri' => '/res/1f2fac54/rsrc/css/application/maniphest/task-summary.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(
@ -3006,7 +3004,7 @@ celerity_register_resource_map(array(
), ),
'phabricator-draggable-list' => 'phabricator-draggable-list' =>
array( array(
'uri' => '/res/e72b9768/rsrc/js/core/DraggableList.js', 'uri' => '/res/76ddce56/rsrc/js/core/DraggableList.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
@ -3221,7 +3219,7 @@ celerity_register_resource_map(array(
), ),
'phabricator-object-item-list-view-css' => 'phabricator-object-item-list-view-css' =>
array( array(
'uri' => '/res/90b606a1/rsrc/css/layout/phabricator-object-item-list-view.css', 'uri' => '/res/b9f7acb9/rsrc/css/layout/phabricator-object-item-list-view.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(
@ -3598,7 +3596,7 @@ celerity_register_resource_map(array(
), ),
'phabricator-zindex-css' => 'phabricator-zindex-css' =>
array( array(
'uri' => '/res/f064ab0f/rsrc/css/core/z-index.css', 'uri' => '/res/f919f9e1/rsrc/css/core/z-index.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(
@ -4027,7 +4025,7 @@ celerity_register_resource_map(array(
), array( ), array(
'packages' => 'packages' =>
array( array(
'd2e70cf1' => '0ad6d3e5' =>
array( array(
'name' => 'core.pkg.css', 'name' => 'core.pkg.css',
'symbols' => 'symbols' =>
@ -4075,7 +4073,7 @@ celerity_register_resource_map(array(
40 => 'phabricator-property-list-view-css', 40 => 'phabricator-property-list-view-css',
41 => 'phabricator-tag-view-css', 41 => 'phabricator-tag-view-css',
), ),
'uri' => '/res/pkg/d2e70cf1/core.pkg.css', 'uri' => '/res/pkg/0ad6d3e5/core.pkg.css',
'type' => 'css', 'type' => 'css',
), ),
'f2ad0683' => 'f2ad0683' =>
@ -4238,7 +4236,7 @@ celerity_register_resource_map(array(
'uri' => '/res/pkg/a9f14d76/javelin.pkg.js', 'uri' => '/res/pkg/a9f14d76/javelin.pkg.js',
'type' => 'js', 'type' => 'js',
), ),
'03ab92cf' => 'a7ca34a9' =>
array( array(
'name' => 'maniphest.pkg.css', 'name' => 'maniphest.pkg.css',
'symbols' => 'symbols' =>
@ -4248,10 +4246,10 @@ celerity_register_resource_map(array(
2 => 'aphront-attached-file-view-css', 2 => 'aphront-attached-file-view-css',
3 => 'phabricator-project-tag-css', 3 => 'phabricator-project-tag-css',
), ),
'uri' => '/res/pkg/03ab92cf/maniphest.pkg.css', 'uri' => '/res/pkg/a7ca34a9/maniphest.pkg.css',
'type' => 'css', 'type' => 'css',
), ),
'265bc3fa' => '98f64f07' =>
array( array(
'name' => 'maniphest.pkg.js', 'name' => 'maniphest.pkg.js',
'symbols' => 'symbols' =>
@ -4262,23 +4260,23 @@ celerity_register_resource_map(array(
3 => 'javelin-behavior-maniphest-transaction-expand', 3 => 'javelin-behavior-maniphest-transaction-expand',
4 => 'javelin-behavior-maniphest-subpriority-editor', 4 => 'javelin-behavior-maniphest-subpriority-editor',
), ),
'uri' => '/res/pkg/265bc3fa/maniphest.pkg.js', 'uri' => '/res/pkg/98f64f07/maniphest.pkg.js',
'type' => 'js', 'type' => 'js',
), ),
), ),
'reverse' => 'reverse' =>
array( array(
'aphront-attached-file-view-css' => '03ab92cf', 'aphront-attached-file-view-css' => 'a7ca34a9',
'aphront-dialog-view-css' => 'd2e70cf1', 'aphront-dialog-view-css' => '0ad6d3e5',
'aphront-error-view-css' => 'd2e70cf1', 'aphront-error-view-css' => '0ad6d3e5',
'aphront-form-view-css' => 'd2e70cf1', 'aphront-form-view-css' => '0ad6d3e5',
'aphront-list-filter-view-css' => 'd2e70cf1', 'aphront-list-filter-view-css' => '0ad6d3e5',
'aphront-pager-view-css' => 'd2e70cf1', 'aphront-pager-view-css' => '0ad6d3e5',
'aphront-panel-view-css' => 'd2e70cf1', 'aphront-panel-view-css' => '0ad6d3e5',
'aphront-table-view-css' => 'd2e70cf1', 'aphront-table-view-css' => '0ad6d3e5',
'aphront-tokenizer-control-css' => 'd2e70cf1', 'aphront-tokenizer-control-css' => '0ad6d3e5',
'aphront-tooltip-css' => 'd2e70cf1', 'aphront-tooltip-css' => '0ad6d3e5',
'aphront-typeahead-control-css' => 'd2e70cf1', 'aphront-typeahead-control-css' => '0ad6d3e5',
'differential-changeset-view-css' => 'dd27a69b', 'differential-changeset-view-css' => 'dd27a69b',
'differential-core-view-css' => 'dd27a69b', 'differential-core-view-css' => 'dd27a69b',
'differential-inline-comment-editor' => '9488bb69', 'differential-inline-comment-editor' => '9488bb69',
@ -4292,7 +4290,7 @@ celerity_register_resource_map(array(
'differential-table-of-contents-css' => 'dd27a69b', 'differential-table-of-contents-css' => 'dd27a69b',
'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-commit-view-css' => 'c8ce2d88',
'diffusion-icons-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88',
'global-drag-and-drop-css' => 'd2e70cf1', 'global-drag-and-drop-css' => '0ad6d3e5',
'inline-comment-summary-css' => 'dd27a69b', 'inline-comment-summary-css' => 'dd27a69b',
'javelin-aphlict' => 'f2ad0683', 'javelin-aphlict' => 'f2ad0683',
'javelin-behavior' => 'a9f14d76', 'javelin-behavior' => 'a9f14d76',
@ -4325,11 +4323,11 @@ celerity_register_resource_map(array(
'javelin-behavior-konami' => 'f2ad0683', 'javelin-behavior-konami' => 'f2ad0683',
'javelin-behavior-lightbox-attachments' => 'f2ad0683', 'javelin-behavior-lightbox-attachments' => 'f2ad0683',
'javelin-behavior-load-blame' => '9488bb69', 'javelin-behavior-load-blame' => '9488bb69',
'javelin-behavior-maniphest-batch-selector' => '265bc3fa', 'javelin-behavior-maniphest-batch-selector' => '98f64f07',
'javelin-behavior-maniphest-subpriority-editor' => '265bc3fa', 'javelin-behavior-maniphest-subpriority-editor' => '98f64f07',
'javelin-behavior-maniphest-transaction-controls' => '265bc3fa', 'javelin-behavior-maniphest-transaction-controls' => '98f64f07',
'javelin-behavior-maniphest-transaction-expand' => '265bc3fa', 'javelin-behavior-maniphest-transaction-expand' => '98f64f07',
'javelin-behavior-maniphest-transaction-preview' => '265bc3fa', 'javelin-behavior-maniphest-transaction-preview' => '98f64f07',
'javelin-behavior-phabricator-active-nav' => 'f2ad0683', 'javelin-behavior-phabricator-active-nav' => 'f2ad0683',
'javelin-behavior-phabricator-autofocus' => 'f2ad0683', 'javelin-behavior-phabricator-autofocus' => 'f2ad0683',
'javelin-behavior-phabricator-gesture' => 'f2ad0683', 'javelin-behavior-phabricator-gesture' => 'f2ad0683',
@ -4366,55 +4364,55 @@ celerity_register_resource_map(array(
'javelin-util' => 'a9f14d76', 'javelin-util' => 'a9f14d76',
'javelin-vector' => 'a9f14d76', 'javelin-vector' => 'a9f14d76',
'javelin-workflow' => 'a9f14d76', 'javelin-workflow' => 'a9f14d76',
'lightbox-attachment-css' => 'd2e70cf1', 'lightbox-attachment-css' => '0ad6d3e5',
'maniphest-task-summary-css' => '03ab92cf', 'maniphest-task-summary-css' => 'a7ca34a9',
'maniphest-transaction-detail-css' => '03ab92cf', 'maniphest-transaction-detail-css' => 'a7ca34a9',
'phabricator-action-list-view-css' => 'd2e70cf1', 'phabricator-action-list-view-css' => '0ad6d3e5',
'phabricator-application-launch-view-css' => 'd2e70cf1', 'phabricator-application-launch-view-css' => '0ad6d3e5',
'phabricator-busy' => 'f2ad0683', 'phabricator-busy' => 'f2ad0683',
'phabricator-content-source-view-css' => 'dd27a69b', 'phabricator-content-source-view-css' => 'dd27a69b',
'phabricator-core-buttons-css' => 'd2e70cf1', 'phabricator-core-buttons-css' => '0ad6d3e5',
'phabricator-core-css' => 'd2e70cf1', 'phabricator-core-css' => '0ad6d3e5',
'phabricator-crumbs-view-css' => 'd2e70cf1', 'phabricator-crumbs-view-css' => '0ad6d3e5',
'phabricator-drag-and-drop-file-upload' => '9488bb69', 'phabricator-drag-and-drop-file-upload' => '9488bb69',
'phabricator-dropdown-menu' => 'f2ad0683', 'phabricator-dropdown-menu' => 'f2ad0683',
'phabricator-file-upload' => 'f2ad0683', 'phabricator-file-upload' => 'f2ad0683',
'phabricator-filetree-view-css' => 'd2e70cf1', 'phabricator-filetree-view-css' => '0ad6d3e5',
'phabricator-flag-css' => 'd2e70cf1', 'phabricator-flag-css' => '0ad6d3e5',
'phabricator-form-view-css' => 'd2e70cf1', 'phabricator-form-view-css' => '0ad6d3e5',
'phabricator-header-view-css' => 'd2e70cf1', 'phabricator-header-view-css' => '0ad6d3e5',
'phabricator-hovercard' => 'f2ad0683', 'phabricator-hovercard' => 'f2ad0683',
'phabricator-jump-nav' => 'd2e70cf1', 'phabricator-jump-nav' => '0ad6d3e5',
'phabricator-keyboard-shortcut' => 'f2ad0683', 'phabricator-keyboard-shortcut' => 'f2ad0683',
'phabricator-keyboard-shortcut-manager' => 'f2ad0683', 'phabricator-keyboard-shortcut-manager' => 'f2ad0683',
'phabricator-main-menu-view' => 'd2e70cf1', 'phabricator-main-menu-view' => '0ad6d3e5',
'phabricator-menu-item' => 'f2ad0683', 'phabricator-menu-item' => 'f2ad0683',
'phabricator-nav-view-css' => 'd2e70cf1', 'phabricator-nav-view-css' => '0ad6d3e5',
'phabricator-notification' => 'f2ad0683', 'phabricator-notification' => 'f2ad0683',
'phabricator-notification-css' => 'd2e70cf1', 'phabricator-notification-css' => '0ad6d3e5',
'phabricator-notification-menu-css' => 'd2e70cf1', 'phabricator-notification-menu-css' => '0ad6d3e5',
'phabricator-object-item-list-view-css' => 'd2e70cf1', 'phabricator-object-item-list-view-css' => '0ad6d3e5',
'phabricator-object-selector-css' => 'dd27a69b', 'phabricator-object-selector-css' => 'dd27a69b',
'phabricator-phtize' => 'f2ad0683', 'phabricator-phtize' => 'f2ad0683',
'phabricator-prefab' => 'f2ad0683', 'phabricator-prefab' => 'f2ad0683',
'phabricator-project-tag-css' => '03ab92cf', 'phabricator-project-tag-css' => 'a7ca34a9',
'phabricator-property-list-view-css' => 'd2e70cf1', 'phabricator-property-list-view-css' => '0ad6d3e5',
'phabricator-remarkup-css' => 'd2e70cf1', 'phabricator-remarkup-css' => '0ad6d3e5',
'phabricator-shaped-request' => '9488bb69', 'phabricator-shaped-request' => '9488bb69',
'phabricator-side-menu-view-css' => 'd2e70cf1', 'phabricator-side-menu-view-css' => '0ad6d3e5',
'phabricator-standard-page-view' => 'd2e70cf1', 'phabricator-standard-page-view' => '0ad6d3e5',
'phabricator-tag-view-css' => 'd2e70cf1', 'phabricator-tag-view-css' => '0ad6d3e5',
'phabricator-textareautils' => 'f2ad0683', 'phabricator-textareautils' => 'f2ad0683',
'phabricator-tooltip' => 'f2ad0683', 'phabricator-tooltip' => 'f2ad0683',
'phabricator-transaction-view-css' => 'd2e70cf1', 'phabricator-transaction-view-css' => '0ad6d3e5',
'phabricator-zindex-css' => 'd2e70cf1', 'phabricator-zindex-css' => '0ad6d3e5',
'phui-form-css' => 'd2e70cf1', 'phui-form-css' => '0ad6d3e5',
'phui-icon-view-css' => 'd2e70cf1', 'phui-icon-view-css' => '0ad6d3e5',
'spacing-css' => 'd2e70cf1', 'spacing-css' => '0ad6d3e5',
'sprite-apps-large-css' => 'd2e70cf1', 'sprite-apps-large-css' => '0ad6d3e5',
'sprite-gradient-css' => 'd2e70cf1', 'sprite-gradient-css' => '0ad6d3e5',
'sprite-icons-css' => 'd2e70cf1', 'sprite-icons-css' => '0ad6d3e5',
'sprite-menu-css' => 'd2e70cf1', 'sprite-menu-css' => '0ad6d3e5',
'syntax-highlighting-css' => 'd2e70cf1', 'syntax-highlighting-css' => '0ad6d3e5',
), ),
)); ));

16
webroot/rsrc/css/application/maniphest/task-summary.css
View file

@ -75,22 +75,6 @@
width: 100%; width: 100%;
} }
.maniphest-subpriority-target {
position: relative;
border: 1px dashed #aaaaaa;
background: #f9f9f9;
margin: 4px;
}
.maniphest-task-loading {
opacity: 0.75;
}
.maniphest-task-dragging {
position: relative;
opacity: 0.90;
}
.maniphest-list-container { .maniphest-list-container {
padding: 20px; padding: 20px;
} }

4
webroot/rsrc/css/core/z-index.css
View file

@ -46,10 +46,6 @@
z-index: 5; z-index: 5;
} }
.maniphest-task-dragging {
z-index: 5;
}
.drag-dragging { .drag-dragging {
z-index: 5; z-index: 5;
} }

10
webroot/rsrc/css/layout/phabricator-object-item-list-view.css
View file

@ -466,6 +466,12 @@
} }
/* - Draggable List ------------------------------------------------------------
These classes are applied by and/or provided for use with JX.DraggableList.
*/
.drag-ghost { .drag-ghost {
position: relative; position: relative;
border: 1px dashed #aaaaaa; border: 1px dashed #aaaaaa;
@ -475,9 +481,9 @@
.drag-dragging { .drag-dragging {
position: relative; position: relative;
opacity: 0.8; opacity: 0.9;
} }
.drag-sending { .drag-sending {
opacity: 0.5; opacity: 0.75;
} }

13
webroot/rsrc/js/application/maniphest/behavior-subpriorityeditor.js
View file

@ -2,7 +2,6 @@
* @provides javelin-behavior-maniphest-subpriority-editor * @provides javelin-behavior-maniphest-subpriority-editor
* @requires javelin-behavior * @requires javelin-behavior
* javelin-dom * javelin-dom
* javelin-vector
* javelin-stratcom * javelin-stratcom
* javelin-workflow * javelin-workflow
* phabricator-draggable-list * phabricator-draggable-list
@ -16,7 +15,6 @@ JX.behavior('maniphest-subpriority-editor', function(config) {
var heads = JX.DOM.scry(document.body, 'h1', 'task-group'); var heads = JX.DOM.scry(document.body, 'h1', 'task-group');
return tasks.concat(heads); return tasks.concat(heads);
}) })
.setGhostNode(JX.$N('li', {className: 'maniphest-subpriority-target'}))
.setGhostHandler(function(ghost, target) { .setGhostHandler(function(ghost, target) {
if (target.nextSibling) { if (target.nextSibling) {
if (JX.DOM.isType(target, 'h1')) { if (JX.DOM.isType(target, 'h1')) {
@ -35,15 +33,6 @@ JX.behavior('maniphest-subpriority-editor', function(config) {
} }
}); });
draggable.listen('didBeginDrag', function(node) {
draggable.getGhostNode().style.height = JX.Vector.getDim(node).y + 'px';
JX.DOM.alterClass(node, 'maniphest-task-dragging', true);
});
draggable.listen('didEndDrag', function(node) {
JX.DOM.alterClass(node, 'maniphest-task-dragging', false);
});
draggable.listen('didDrop', function(node, after) { draggable.listen('didDrop', function(node, after) {
var data = { var data = {
task: JX.Stratcom.getData(node).taskID task: JX.Stratcom.getData(node).taskID
@ -56,7 +45,7 @@ JX.behavior('maniphest-subpriority-editor', function(config) {
} }
draggable.lock(); draggable.lock();
JX.DOM.alterClass(node, 'maniphest-task-loading', true); JX.DOM.alterClass(node, 'drag-sending', true);
var onresponse = function(r) { var onresponse = function(r) {
var nodes = JX.$H(r.tasks).getFragment().firstChild; var nodes = JX.$H(r.tasks).getFragment().firstChild;

12
webroot/rsrc/js/application/search/behavior-reorder-queries.js
View file

@ -1,7 +1,6 @@
/** /**
* @provides javelin-behavior-search-reorder-queries * @provides javelin-behavior-search-reorder-queries
* @requires javelin-behavior * @requires javelin-behavior
* javelin-vector
* javelin-stratcom * javelin-stratcom
* javelin-workflow * javelin-workflow
* javelin-dom * javelin-dom
@ -10,24 +9,13 @@
JX.behavior('search-reorder-queries', function(config) { JX.behavior('search-reorder-queries', function(config) {
var ghost = JX.$N('div', {className: 'drag-ghost'});
var root = JX.$(config.listID); var root = JX.$(config.listID);
var list = new JX.DraggableList('named-query', root) var list = new JX.DraggableList('named-query', root)
.setGhostNode(ghost)
.setFindItemsHandler(function() { .setFindItemsHandler(function() {
return JX.DOM.scry(root, 'li', 'named-query'); return JX.DOM.scry(root, 'li', 'named-query');
}); });
list.listen('didBeginDrag', function(node) {
list.getGhostNode().style.height = JX.Vector.getDim(node).y + 'px';
JX.DOM.alterClass(node, 'drag-dragging', true);
});
list.listen('didEndDrag', function(node) {
JX.DOM.alterClass(node, 'drag-dragging', false);
});
list.listen('didDrop', function(node, after) { list.listen('didDrop', function(node, after) {
var nodes = list.findItems(); var nodes = list.findItems();
var order = []; var order = [];

29
webroot/rsrc/js/core/DraggableList.js
View file

@ -33,8 +33,7 @@ JX.install('DraggableList', {
'didDrop'], 'didDrop'],
properties : { properties : {
findItemsHandler : null, findItemsHandler : null
ghostNode: null
}, },
members : { members : {
@ -46,6 +45,7 @@ JX.install('DraggableList', {
_targets : null, _targets : null,
_dimensions : null, _dimensions : null,
_ghostHandler : null, _ghostHandler : null,
_ghostNode : null,
setGhostHandler : function(handler) { setGhostHandler : function(handler) {
this._ghostHandler = handler; this._ghostHandler = handler;
@ -56,6 +56,13 @@ JX.install('DraggableList', {
return this._ghostHandler || JX.bind(this, this._defaultGhostHandler); return this._ghostHandler || JX.bind(this, this._defaultGhostHandler);
}, },
getGhostNode : function() {
if (!this._ghostNode) {
this._ghostNode = JX.$N('li', {className: 'drag-ghost'});
}
return this._ghostNode;
},
_defaultGhostHandler : function(ghost, target) { _defaultGhostHandler : function(ghost, target) {
var parent = this._dragging.parentNode; var parent = this._dragging.parentNode;
if (target && target.nextSibling) { if (target && target.nextSibling) {
@ -79,13 +86,6 @@ JX.install('DraggableList', {
}, },
_ondrag : function(e) { _ondrag : function(e) {
if (__DEV__) {
var ghost = this.getGhostNode();
if (!ghost) {
JX.$E('JX.Draggable._ondrag(): No ghostNode set!');
}
}
if (this._dragging) { if (this._dragging) {
// Don't start dragging if we're already dragging something. // Don't start dragging if we're already dragging something.
return; return;
@ -123,7 +123,11 @@ JX.install('DraggableList', {
this._targets = targets; this._targets = targets;
this._target = null; this._target = null;
this.invoke('didBeginDrag', this._dragging); if (!this.invoke('didBeginDrag', this._dragging).getPrevented()) {
var ghost = this.getGhostNode();
ghost.style.height = JX.Vector.getDim(this._dragging).y + 'px';
JX.DOM.alterClass(this._dragging, 'drag-dragging', true);
}
}, },
_onmove : function(e) { _onmove : function(e) {
@ -249,7 +253,10 @@ JX.install('DraggableList', {
this.invoke('didCancelDrag', dragging); this.invoke('didCancelDrag', dragging);
} }
this.invoke('didEndDrag', dragging); if (!this.invoke('didEndDrag', dragging).getPrevented()) {
JX.DOM.alterClass(dragging, 'drag-dragging', false);
}
e.kill(); e.kill();
}, },