From 5fff4ed8dbb7176bcb4ea8a2cf87513504f670df Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 4 Sep 2020 16:37:23 -0700 Subject: [PATCH] (stable) Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon Overseer Summary: Ref T13579. This property was removed in D21425, but I missed this usage site. Remove the assignment; this class no longer tracks the subprocess PID directly. Test Plan: Searched for "->pid", no further hits. Maniphest Tasks: T13579 Differential Revision: https://secure.phabricator.com/D21452 --- src/infrastructure/daemon/PhutilDaemonHandle.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/infrastructure/daemon/PhutilDaemonHandle.php b/src/infrastructure/daemon/PhutilDaemonHandle.php index 428a64a056..3792c3b773 100644 --- a/src/infrastructure/daemon/PhutilDaemonHandle.php +++ b/src/infrastructure/daemon/PhutilDaemonHandle.php @@ -356,7 +356,6 @@ final class PhutilDaemonHandle extends Phobject { posix_kill(-$pgid, SIGTERM); sleep($this->getKillDelay()); posix_kill(-$pgid, SIGKILL); - $this->pid = null; } } }