From 608137039150e24db12143fbae84d833d64732fe Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Mon, 1 Dec 2014 12:13:04 -0800 Subject: [PATCH] Differential - fix "transaction has no effect error" on diff create Summary: Fixes T6658. Test Plan: made a diff with no repository and default policy and it worked! Reviewers: epriestley, chad Reviewed By: chad Subscribers: Korvin, epriestley Maniphest Tasks: T6658 Differential Revision: https://secure.phabricator.com/D10910 --- .../conduit/DifferentialCreateDiffConduitAPIMethod.php | 1 + .../conduit/DifferentialCreateRawDiffConduitAPIMethod.php | 1 + 2 files changed, 2 insertions(+) diff --git a/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php index 26b1c04ddd..1d6b461e0a 100644 --- a/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php +++ b/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php @@ -172,6 +172,7 @@ final class DifferentialCreateDiffConduitAPIMethod id(new DifferentialDiffEditor()) ->setActor($viewer) ->setContentSourceFromConduitRequest($request) + ->setContinueOnNoEffect(true) ->applyTransactions($diff, $xactions); $path = '/differential/diff/'.$diff->getID().'/'; diff --git a/src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php index 29638b5396..52999ad505 100644 --- a/src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php +++ b/src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php @@ -68,6 +68,7 @@ final class DifferentialCreateRawDiffConduitAPIMethod id(new DifferentialDiffEditor()) ->setActor($viewer) ->setContentSourceFromConduitRequest($request) + ->setContinueOnNoEffect(true) ->setLookupRepository(false) // respect user choice ->applyTransactions($diff, $xactions);