diff --git a/src/applications/differential/controller/DifferentialController.php b/src/applications/differential/controller/DifferentialController.php index 46ac290c09..1aba876c68 100644 --- a/src/applications/differential/controller/DifferentialController.php +++ b/src/applications/differential/controller/DifferentialController.php @@ -190,6 +190,12 @@ abstract class DifferentialController extends PhabricatorController { } } + // Cast duration to a float since it used to be a string in some + // cases. + if (isset($map['duration'])) { + $map['duration'] = (double)$map['duration']; + } + return $map; } diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php index afd5875a1a..cad2932a0c 100644 --- a/src/applications/differential/controller/DifferentialRevisionViewController.php +++ b/src/applications/differential/controller/DifferentialRevisionViewController.php @@ -1078,6 +1078,10 @@ final class DifferentialRevisionViewController extends DifferentialController { return null; } + if (!$diff->getBuildable()) { + return null; + } + $interesting_messages = array(); foreach ($diff->getUnitMessages() as $message) { switch ($message->getResult()) {