revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 19:40:55 +01:00
Code Issues Releases Wiki Activity

Return more transaction types in Conpherence notification menu

Browse source 
Summary: Unclear these are worth sending, but mostly seems useful. Returns `getTitle` for the transaction if it's not a message. Fixes T10683

Test Plan: Leave rooms, change names, add pictures.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T10683

Differential Revision: https://secure.phabricator.com/D16658
This commit is contained in:
Chad Little 2016-10-03 13:21:06 -07:00
parent 75fe750ee3
commit 60ce989247
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/applications/conpherence/storage/ConpherenceThread.php
View file

@ -284,11 +284,18 @@ final class ConpherenceThread extends ConpherenceDAO
$message_title = null; $message_title = null;
if ($subtitle_mode == 'message') { if ($subtitle_mode == 'message') {
$message_transaction = null; $message_transaction = null;
$action_transaction = null;
foreach ($transactions as $transaction) { foreach ($transactions as $transaction) {
switch ($transaction->getTransactionType()) { switch ($transaction->getTransactionType()) {
case PhabricatorTransactions::TYPE_COMMENT: case PhabricatorTransactions::TYPE_COMMENT:
$message_transaction = $transaction; $message_transaction = $transaction;
break 2; break;
case ConpherenceTransaction::TYPE_TITLE:
case ConpherenceTransaction::TYPE_TOPIC:
case ConpherenceTransaction::TYPE_PICTURE:
case ConpherenceTransaction::TYPE_PARTICIPANTS:
$action_transaction = $transaction;
break;
default: default:
break; break;
} }
@ -303,6 +310,11 @@ final class ConpherenceThread extends ConpherenceDAO
->truncateString( ->truncateString(
$message_transaction->getComment()->getContent())); $message_transaction->getComment()->getContent()));
} }
if ($action_transaction) {
$message_title = id(clone $action_transaction)
->setRenderingTarget(PhabricatorApplicationTransaction::TARGET_TEXT)
->getTitle();
}
} }
switch ($subtitle_mode) { switch ($subtitle_mode) {
case 'recent': case 'recent':