revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
Code Issues Releases Wiki Activity

show the current size limit when a file upload fails

Browse source 
Summary: Show the php.ini setting for max upload or alterantively the in phabricator configured one. Fixes T6663

Test Plan: changed php.ini and alternatively phabricator file upload size settings to minimal values and try to upload a larger file

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, btrahan, chad, epriestley

Maniphest Tasks: T6663

Differential Revision: https://secure.phabricator.com/D11031
This commit is contained in:
Fabian Stelzer 2014-12-23 05:17:16 -08:00 committed by epriestley
parent a366f85c11
commit 6132d8012b
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/applications/files/exception/PhabricatorFileUploadException.php
View file

@ -5,8 +5,9 @@ final class PhabricatorFileUploadException extends Exception {
public function __construct($code) { public function __construct($code) {
$map = array( $map = array(
UPLOAD_ERR_INI_SIZE => UPLOAD_ERR_INI_SIZE =>
"Uploaded file is too large: file is larger than the ". pht("Uploaded file is too large: current limit is %s. To adjust ".
"'upload_max_filesize' setting in php.ini.", "this limit change 'upload_max_filesize' in php.ini.",
ini_get('upload_max_filesize')),
UPLOAD_ERR_FORM_SIZE => UPLOAD_ERR_FORM_SIZE =>
'File is too large.', 'File is too large.',
UPLOAD_ERR_PARTIAL => UPLOAD_ERR_PARTIAL =>
@ -21,8 +22,9 @@ final class PhabricatorFileUploadException extends Exception {
'Unable to upload: a PHP extension stopped the upload.', 'Unable to upload: a PHP extension stopped the upload.',
-1000 => -1000 =>
"Uploaded file exceeds limit in Phabricator ". pht("Uploaded file is too large: current limit is %s. To adjust this ".
"'storage.upload-size-limit' configuration.", "limit change 'storage.upload-size-limit' in the Phabricator config.",
PhabricatorEnv::getEnvConfig('storage.upload-size-limit')),
); );
$message = idx($map, $code, 'Upload failed: unknown error.'); $message = idx($map, $code, 'Upload failed: unknown error.');