From 6182193cf55a8eeb5fc75e54916dc90ccd944c88 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 25 Mar 2019 14:31:21 -0700 Subject: [PATCH] Give the "Code" tab in Diffusion more consistent (path-retaining) behavior Summary: Fixes T13270. In Diffusion, the "Code" tab is linked in a weird way that isn't consistent with the other tabs. Particularly, if you navigate to `x/y/z/` and toggle between the "Branches" and "History" tabs (or other tabs), you keep your path. If you click "Code", you lose your path. Instead, retain the path, so you can navigate somewhere and then toggle to/from the "Code" tab to get different views of the same path. Test Plan: Browed into a repository, clicked "History", clicked "Code", ended up back in the place I started. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13270 Differential Revision: https://secure.phabricator.com/D20323 --- src/applications/diffusion/controller/DiffusionController.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/applications/diffusion/controller/DiffusionController.php b/src/applications/diffusion/controller/DiffusionController.php index a220ac05e0..5f4c304ebc 100644 --- a/src/applications/diffusion/controller/DiffusionController.php +++ b/src/applications/diffusion/controller/DiffusionController.php @@ -512,8 +512,7 @@ abstract class DiffusionController extends PhabricatorController { ->setIcon('fa-code') ->setHref($drequest->generateURI( array( - 'action' => 'branch', - 'path' => '/', + 'action' => 'browse', ))) ->setSelected($key == 'code'));