From 61af2e313bfad2f1e41f02a7a80988f790dffbf2 Mon Sep 17 00:00:00 2001 From: epriestley Date: Sat, 7 Jun 2014 12:29:19 -0700 Subject: [PATCH] Slightly improve friendliness of "no mxmlc" error Summary: Ref T4324. Add some hints and context. Test Plan: Read error. Reviewers: joshuaspence Reviewed By: joshuaspence Subscribers: epriestley Maniphest Tasks: T4324 Differential Revision: https://secure.phabricator.com/D9417 --- .../PhabricatorAphlictManagementBuildWorkflow.php | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/applications/aphlict/management/PhabricatorAphlictManagementBuildWorkflow.php b/src/applications/aphlict/management/PhabricatorAphlictManagementBuildWorkflow.php index b2665c47a1..bbee1c57f6 100644 --- a/src/applications/aphlict/management/PhabricatorAphlictManagementBuildWorkflow.php +++ b/src/applications/aphlict/management/PhabricatorAphlictManagementBuildWorkflow.php @@ -21,8 +21,16 @@ final class PhabricatorAphlictManagementBuildWorkflow $root = dirname(__FILE__).'/../../../..'; if (!Filesystem::binaryExists('mxmlc')) { - $console->writeErr('`mxmlc` is not installed.'); - return 1; + throw new PhutilArgumentUsageException( + pht( + "The `mxmlc` binary was not found in PATH. This compiler binary ". + "is required to rebuild the Aphlict client.\n\n". + "Adjust your PATH, or install the Flex SDK from:\n\n". + " http://flex.apache.org\n\n". + "You may also be able to install it with `npm`:\n\n". + " $ npm install flex-sdk\n\n". + "(Note: you should only need to rebuild Aphlict if you are ". + "developing Phabricator.)")); } $argv = array(