Use PhutilInvalidStateException

Summary: Use `PhutilInvalidStateException`. Depends on D12803.

Test Plan: Unit tests pass.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12829

src/applications/auth/provider/PhabricatorAuthProvider.php

@@ -15,8 +15,7 @@ abstract class PhabricatorAuthProvider {
 
   public function getProviderConfig() {
     if ($this->providerConfig === null) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('attachProviderConfig');
-        'Call attachProviderConfig() before getProviderConfig()!');
     }
     return $this->providerConfig;
   }

src/applications/celerity/CelerityResourceGraph.php

@@ -7,9 +7,7 @@ final class CelerityResourceGraph extends AbstractDirectedGraph {
 
   protected function loadEdges(array $nodes) {
     if (!$this->graphSet) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('setResourceGraph');
-        'Call setResourceGraph before loading the graph!'
-      );
     }
 
     $graph = $this->getResourceGraph();

src/applications/config/option/PhabricatorConfigOption.php

@@ -122,8 +122,7 @@ final class PhabricatorConfigOption
       return $this->enumOptions;
     }
 
-    throw new Exception(
+    throw new PhutilInvalidStateException('setEnumOptions');
-      'Call setEnumOptions() before trying to access them!');
   }
 
   public function setKey($key) {

src/applications/config/schema/PhabricatorConfigSchemaQuery.php

@@ -11,7 +11,7 @@ final class PhabricatorConfigSchemaQuery extends Phobject {
 
   protected function getAPI() {
     if (!$this->api) {
-      throw new Exception(pht('Call setAPI() before issuing a query!'));
+      throw new PhutilInvalidStateException('setAPI');
     }
     return $this->api;
   }

src/applications/daemon/view/PhabricatorDaemonLogEventsView.php

@@ -27,7 +27,7 @@ final class PhabricatorDaemonLogEventsView extends AphrontView {
     $rows = array();
 
     if (!$this->user) {
-      throw new Exception('Call setUser() before rendering!');
+      throw new PhutilInvalidStateException('setUser');
     }
 
     foreach ($this->events as $event) {

src/applications/daemon/view/PhabricatorDaemonLogListView.php

@@ -14,7 +14,7 @@ final class PhabricatorDaemonLogListView extends AphrontView {
     $rows = array();
 
     if (!$this->user) {
-      throw new Exception('Call setUser() before rendering!');
+      throw new PhutilInvalidStateException('setUser');
     }
 
     $env_hash = PhabricatorEnv::calculateEnvironmentHash();

src/applications/differential/view/DifferentialLocalCommitsView.php

@@ -19,7 +19,7 @@ final class DifferentialLocalCommitsView extends AphrontView {
   public function render() {
     $user = $this->user;
     if (!$user) {
-      throw new Exception('Call setUser() before render()-ing this view.');
+      throw new PhutilInvalidStateException('setUser');
     }
 
     $local = $this->localCommits;

src/applications/differential/view/DifferentialRevisionListView.php

@@ -57,10 +57,9 @@ final class DifferentialRevisionListView extends AphrontView {
   }
 
   public function render() {
-
     $user = $this->user;
     if (!$user) {
-      throw new Exception('Call setUser() before render()!');
+      throw new PhutilInvalidStateException('setUser');
     }
 
     $fresh = PhabricatorEnv::getEnvConfig('differential.days-fresh');

src/applications/diffusion/query/DiffusionLintCountQuery.php

@@ -23,11 +23,11 @@ final class DiffusionLintCountQuery extends PhabricatorQuery {
 
   public function execute() {
     if (!$this->paths) {
-      throw new Exception(pht('Call withPaths() before execute()!'));
+      throw new PhutilInvalidStateException('withPaths');
     }
 
     if (!$this->branchIDs) {
-      throw new Exception(pht('Call withBranchIDs() before execute()!'));
+      throw new PhutilInvalidStateException('withBranchIDs');
     }
 
     $conn_r = id(new PhabricatorRepositoryCommit())->establishConnection('r');

src/applications/diffusion/query/lowlevel/DiffusionLowLevelQuery.php

@@ -17,7 +17,7 @@ abstract class DiffusionLowLevelQuery extends Phobject {
 
   public function execute() {
     if (!$this->getRepository()) {
-      throw new Exception('Call setRepository() before execute()!');
+      throw new PhutilInvalidStateException('setRepository');
     }
 
     return $this->executeQuery();

src/applications/diviner/atom/DivinerAtom.php

@@ -95,16 +95,14 @@ final class DivinerAtom {
 
   public function getDocblockText() {
     if ($this->docblockText === null) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('setDocblockRaw');
-        pht('Call %s before %s!', 'setDocblockRaw()', 'getDocblockText()'));
     }
     return $this->docblockText;
   }
 
   public function getDocblockMeta() {
     if ($this->docblockMeta === null) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('setDocblockRaw');
-        pht('Call %s before %s!', 'setDocblockRaw()', 'getDocblockMeta()'));
     }
     return $this->docblockMeta;
   }

src/applications/doorkeeper/view/DoorkeeperTagView.php

@@ -12,7 +12,7 @@ final class DoorkeeperTagView extends AphrontView {
   public function render() {
     $xobj = $this->xobj;
     if (!$xobj) {
-      throw new Exception('Call setExternalObject() before render()!');
+      throw new PhutilInvalidStateException('setExternalObject');
     }
 
     $tag_id = celerity_generate_unique_node_id();

src/applications/files/controller/PhabricatorFileDataController.php

@@ -227,7 +227,7 @@ final class PhabricatorFileDataController extends PhabricatorFileController {
 
   private function getFile() {
     if (!$this->file) {
-      throw new Exception(pht('Call loadFile() before getFile()!'));
+      throw new PhutilInvalidStateException('loadFile');
     }
     return $this->file;
   }

src/applications/fund/phortune/FundBackerCart.php

@@ -33,8 +33,7 @@ final class FundBackerCart extends PhortuneCartImplementation {
 
     $initiative = $this->getInitiative();
     if (!$initiative) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('setInitiative');
-        pht('Call setInitiative() before building a cart!'));
     }
 
     $cart->setMetadataValue('initiativePHID', $initiative->getPHID());

src/applications/multimeter/data/MultimeterControl.php

@@ -88,7 +88,7 @@ final class MultimeterControl {
     }
 
     if ($this->sampleRate === null) {
-      throw new Exception(pht('Call setSampleRate() before saving events!'));
+      throw new PhutilInvalidStateException('setSampleRate');
     }
 
     $this->addServiceEvents();

src/applications/paste/view/PasteEmbedView.php

@@ -28,7 +28,7 @@ final class PasteEmbedView extends AphrontView {
 
   public function render() {
     if (!$this->paste) {
-      throw new Exception('Call setPaste() before render()!');
+      throw new PhutilInvalidStateException('setPaste');
     }
 
     $lines = phutil_split_lines($this->paste->getContent());

src/applications/phid/query/PhabricatorObjectQuery.php

@@ -78,7 +78,7 @@ final class PhabricatorObjectQuery
 
   public function getNamedResults() {
     if ($this->namedResults === null) {
-      throw new Exception('Call execute() before getNamedResults()!');
+      throw new PhutilInvalidStateException('execute');
     }
     return $this->namedResults;
   }

src/applications/pholio/view/PholioMockEmbedView.php

@@ -17,7 +17,7 @@ final class PholioMockEmbedView extends AphrontView {
 
   public function render() {
     if (!$this->mock) {
-      throw new Exception('Call setMock() before render()!');
+      throw new PhutilInvalidStateException('setMock');
     }
     $mock = $this->mock;
 

src/applications/phortune/cart/PhortuneSubscriptionCart.php

@@ -34,8 +34,7 @@ final class PhortuneSubscriptionCart
 
     $subscription = $this->getSubscription();
     if (!$subscription) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('setSubscription');
-        pht('Call setSubscription() before building a cart!'));
     }
 
     $cart->setMetadataValue('subscriptionPHID', $subscription->getPHID());

src/applications/search/controller/PhabricatorApplicationSearchController.php

@@ -55,18 +55,12 @@ final class PhabricatorApplicationSearchController
 
     $engine = $this->getSearchEngine();
     if (!$engine) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('setEngine');
-        pht(
-          'Call %s before delegating to this controller!',
-          'setEngine()'));
     }
 
     $nav = $this->getNavigation();
     if (!$nav) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('setNavigation');
-        pht(
-          'Call %s before delegating to this controller!',
-          'setNavigation()'));
     }
 
     $engine->setViewer($this->getRequest()->getUser());

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

@@ -33,7 +33,7 @@ abstract class PhabricatorApplicationSearchEngine {
 
   protected function requireViewer() {
     if (!$this->viewer) {
-      throw new Exception('Call setViewer() before using an engine!');
+      throw new PhutilInvalidStateException('setViewer');
     }
     return $this->viewer;
   }

src/applications/slowvote/view/SlowvoteEmbedView.php

@@ -22,7 +22,7 @@ final class SlowvoteEmbedView extends AphrontView {
 
   public function render() {
     if (!$this->poll) {
-      throw new Exception('Call setPoll() before render()!');
+      throw new PhutilInvalidStateException('setPoll');
     }
 
     $poll = $this->poll;

src/applications/subscriptions/editor/PhabricatorSubscriptionsEditor.php

@@ -56,7 +56,7 @@ final class PhabricatorSubscriptionsEditor extends PhabricatorEditor {
 
   public function save() {
     if (!$this->object) {
-      throw new Exception('Call setObject() before save()!');
+      throw new PhutilInvalidStateException('setObject');
     }
     $actor = $this->requireActor();
 

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php

@@ -133,8 +133,7 @@ final class PhabricatorApplicationTransactionCommentEditor
     }
 
     if (!$this->getContentSource()) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('applyEdit');
-        'Call setContentSource() before applyEdit()!');
     }
 
     $actor = $this->requireActor();

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

@@ -970,8 +970,7 @@ abstract class PhabricatorApplicationTransactionEditor
     array $xactions) {
 
     if (!$this->getContentSource()) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('setContentSource');
-        'Call setContentSource() before applyTransactions()!');
     }
 
     // Do a bunch of sanity checks that the incoming transactions are fresh.

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

@@ -149,7 +149,7 @@ class PhabricatorApplicationTransactionCommentView extends AphrontView {
     }
 
     if (!$this->getObjectPHID()) {
-      throw new Exception('Call setObjectPHID() before render()!');
+      throw new PhutilInvalidStateException('setObjectPHID', 'render');
     }
 
     return id(new AphrontFormView())

src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

@@ -76,10 +76,10 @@ final class PHUIDiffInlineCommentEditView
 
   public function render() {
     if (!$this->uri) {
-      throw new Exception('Call setSubmitURI() before render()!');
+      throw new PhutilInvalidStateException('setSubmitURI');
     }
     if (!$this->user) {
-      throw new Exception('Call setUser() before render()!');
+      throw new PhutilInvalidStateException('setUser');
     }
 
     $content = phabricator_form(

src/view/control/AphrontCursorPagerView.php

@@ -92,8 +92,7 @@ final class AphrontCursorPagerView extends AphrontView {
 
   public function getFirstPageURI() {
     if (!$this->uri) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('setURI');
-        pht('You must call setURI() before you can call getFirstPageURI().'));
     }
 
     if (!$this->afterID && !($this->beforeID && $this->moreResults)) {
@@ -107,8 +106,7 @@ final class AphrontCursorPagerView extends AphrontView {
 
   public function getPrevPageURI() {
     if (!$this->uri) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('getPrevPageURI');
-        pht('You must call setURI() before you can call getPrevPageURI().'));
     }
 
     if (!$this->prevPageID) {
@@ -122,8 +120,7 @@ final class AphrontCursorPagerView extends AphrontView {
 
   public function getNextPageURI() {
     if (!$this->uri) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('setURI');
-        pht('You must call setURI() before you can call getNextPageURI().'));
     }
 
     if (!$this->nextPageID) {
@@ -137,8 +134,7 @@ final class AphrontCursorPagerView extends AphrontView {
 
   public function render() {
     if (!$this->uri) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('setURI');
-        pht('You must call setURI() before you can call render().'));
     }
 
     $links = array();

src/view/control/AphrontPagerView.php

@@ -109,8 +109,7 @@ final class AphrontPagerView extends AphrontView {
 
   public function render() {
     if (!$this->uri) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('setURI');
-        pht('You must call setURI() before you can call render().'));
     }
 
     require_celerity_resource('aphront-pager-view-css');

src/view/form/PHUIFormLayoutView.php

@@ -32,11 +32,7 @@ final class PHUIFormLayoutView extends AphrontView {
 
   public function appendRemarkupInstructions($remarkup) {
     if ($this->getUser() === null) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('setUser');
-        pht(
-          'Call %s before appending Remarkup to %s.',
-          'setUser()',
-          __CLASS__));
     }
 
     return $this->appendInstructions(

src/view/form/control/PhabricatorRemarkupControl.php

@@ -24,11 +24,7 @@ final class PhabricatorRemarkupControl extends AphrontFormTextAreaControl {
 
     $viewer = $this->getUser();
     if (!$viewer) {
-      throw new Exception(
+      throw new PhutilInvalidStateException('setUser');
-        pht(
-          'Call %s before rendering a %s!',
-          'setUser()',
-          __CLASS__));
     }
 
     // We need to have this if previews render images, since Ajax can not

src/view/phui/PHUIRemarkupPreviewPanel.php

@@ -42,8 +42,11 @@ final class PHUIRemarkupPreviewPanel extends AphrontTagView {
     );
 
     if (empty($skins[$skin])) {
-      $valid = implode(', ', array_keys($skins));
+      throw new Exception(
-      throw new Exception("Invalid skin '{$skin}'. Valid skins are: {$valid}.");
+        pht(
+          "Invalid skin '%s'. Valid skins are: %s.",
+          $skin,
+          implode(', ', array_keys($skins))));
     }
 
     $this->skin = $skin;
@@ -69,10 +72,10 @@ final class PHUIRemarkupPreviewPanel extends AphrontTagView {
 
   protected function getTagContent() {
     if ($this->previewURI === null) {
-      throw new Exception('Call setPreviewURI() before rendering!');
+      throw new PhutilInvalidStateException('setPreviewURI');
     }
     if ($this->controlID === null) {
-      throw new Exception('Call setControlID() before rendering!');
+      throw new PhutilInvalidStateException('setControlID');
     }
 
     $preview_id = celerity_generate_unique_node_id();

src/view/phui/calendar/PHUICalendarMonthView.php

@@ -59,7 +59,7 @@ final class PHUICalendarMonthView extends AphrontView {
 
   public function render() {
     if (empty($this->user)) {
-      throw new Exception('Call setUser() before render()!');
+      throw new PhutilInvalidStateException('setUser');
     }
 
     $events = msort($this->events, 'getEpochStart');

src/view/widget/hovercard/PhabricatorHovercardView.php

@@ -62,7 +62,7 @@ final class PhabricatorHovercardView extends AphrontView {
 
   public function render() {
     if (!$this->handle) {
-      throw new Exception('Call setObjectHandle() before calling render()!');
+      throw new PhutilInvalidStateException('setObjectHandle');
     }
 
     $handle = $this->handle;