revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exception rendering Conpherence search results

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/conpherence/query/ConpherenceThreadSearchEngine.php:154]
```

See also similar rPe65ac7b8800d3397abfced7824a8d316ec573d8f

Closes T15818

Test Plan: Go to http://phorge.localhost/conpherence/search/query/all/

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15818

Differential Revision: https://we.phorge.it/D25629
This commit is contained in:
Andre Klapper 2024-05-09 13:23:13 +02:00
parent 5b90567f64
commit 61c953268e
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/conpherence/query/ConpherenceThreadSearchEngine.php
View file

@ -151,7 +151,7 @@ final class ConpherenceThreadSearchEngine
$icon = id(new PHUIIconView()) $icon = id(new PHUIIconView())
->setIcon($icon_name); ->setIcon($icon_name);
if (!strlen($fulltext)) { if (!phutil_nonempty_string($fulltext)) {
$item = id(new PHUIObjectItemView()) $item = id(new PHUIObjectItemView())
->setObjectName($conpherence->getMonogram()) ->setObjectName($conpherence->getMonogram())
->setHeader($title) ->setHeader($title)