revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
Code Issues Releases Wiki Activity

Remove unicode marks for "Accept/Raise Concern" in Audit

Browse source 
Summary:
Ref T13210. The comment action dropdown for audits has a heavy checkmark next to "Accept" and a heavy "X" next to "Raise Concern".

We previously removed similar marks in Differential in D19405 and that seems to have gone fine. For consistency, remove these too.

Test Plan: Viewed the comment action dropdown, no longer saw checkmark and X-mark.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13210

Differential Revision: https://secure.phabricator.com/D19759
This commit is contained in:
epriestley 2018-10-25 04:51:37 -07:00
parent a7c008708d
commit 61ec434208
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/diffusion/xaction/DiffusionCommitAcceptTransaction.php
View file

@ -7,7 +7,7 @@ final class DiffusionCommitAcceptTransaction
const ACTIONKEY = 'accept'; const ACTIONKEY = 'accept';
protected function getCommitActionLabel() { protected function getCommitActionLabel() {
return pht("Accept Commit \xE2\x9C\x94"); return pht('Accept Commit');
} }
protected function getCommitActionDescription() { protected function getCommitActionDescription() {

2
src/applications/diffusion/xaction/DiffusionCommitConcernTransaction.php
View file

@ -7,7 +7,7 @@ final class DiffusionCommitConcernTransaction
const ACTIONKEY = 'concern'; const ACTIONKEY = 'concern';
protected function getCommitActionLabel() { protected function getCommitActionLabel() {
return pht("Raise Concern \xE2\x9C\x98"); return pht('Raise Concern');
} }
protected function getCommitActionDescription() { protected function getCommitActionDescription() {