From 6219103f02a5036fff40575cf9e23171245bb13d Mon Sep 17 00:00:00 2001 From: Chad Little Date: Fri, 31 May 2013 08:40:03 -0700 Subject: [PATCH] Update ObjectItemView to a 4px grid Summary: Cleaning up the spacing on ObjectItemView to be on a 4px grid and a little more consistent. Test Plan: Review changes on a grid in Photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6088 --- src/__celerity_resource_map__.php | 92 +++++++++---------- .../phabricator-object-item-list-view.css | 15 ++- 2 files changed, 53 insertions(+), 54 deletions(-) diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php index ed5d0740f5..c8d4964270 100644 --- a/src/__celerity_resource_map__.php +++ b/src/__celerity_resource_map__.php @@ -3200,7 +3200,7 @@ celerity_register_resource_map(array( ), 'phabricator-object-item-list-view-css' => array( - 'uri' => '/res/96dce9f3/rsrc/css/layout/phabricator-object-item-list-view.css', + 'uri' => '/res/b8b2fe24/rsrc/css/layout/phabricator-object-item-list-view.css', 'type' => 'css', 'requires' => array( @@ -3988,7 +3988,7 @@ celerity_register_resource_map(array( ), array( 'packages' => array( - 'a94fc53b' => + 'e414a0b5' => array( 'name' => 'core.pkg.css', 'symbols' => @@ -4037,7 +4037,7 @@ celerity_register_resource_map(array( 41 => 'phabricator-property-list-view-css', 42 => 'phabricator-tag-view-css', ), - 'uri' => '/res/pkg/a94fc53b/core.pkg.css', + 'uri' => '/res/pkg/e414a0b5/core.pkg.css', 'type' => 'css', ), '98f60e3f' => @@ -4231,16 +4231,16 @@ celerity_register_resource_map(array( 'reverse' => array( 'aphront-attached-file-view-css' => '6b1fccc6', - 'aphront-dialog-view-css' => 'a94fc53b', - 'aphront-error-view-css' => 'a94fc53b', - 'aphront-form-view-css' => 'a94fc53b', - 'aphront-list-filter-view-css' => 'a94fc53b', - 'aphront-pager-view-css' => 'a94fc53b', - 'aphront-panel-view-css' => 'a94fc53b', - 'aphront-table-view-css' => 'a94fc53b', - 'aphront-tokenizer-control-css' => 'a94fc53b', - 'aphront-tooltip-css' => 'a94fc53b', - 'aphront-typeahead-control-css' => 'a94fc53b', + 'aphront-dialog-view-css' => 'e414a0b5', + 'aphront-error-view-css' => 'e414a0b5', + 'aphront-form-view-css' => 'e414a0b5', + 'aphront-list-filter-view-css' => 'e414a0b5', + 'aphront-pager-view-css' => 'e414a0b5', + 'aphront-panel-view-css' => 'e414a0b5', + 'aphront-table-view-css' => 'e414a0b5', + 'aphront-tokenizer-control-css' => 'e414a0b5', + 'aphront-tooltip-css' => 'e414a0b5', + 'aphront-typeahead-control-css' => 'e414a0b5', 'differential-changeset-view-css' => 'dd27a69b', 'differential-core-view-css' => 'dd27a69b', 'differential-inline-comment-editor' => '9488bb69', @@ -4254,7 +4254,7 @@ celerity_register_resource_map(array( 'differential-table-of-contents-css' => 'dd27a69b', 'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88', - 'global-drag-and-drop-css' => 'a94fc53b', + 'global-drag-and-drop-css' => 'e414a0b5', 'inline-comment-summary-css' => 'dd27a69b', 'javelin-aphlict' => '98f60e3f', 'javelin-behavior' => 'a9f14d76', @@ -4328,56 +4328,56 @@ celerity_register_resource_map(array( 'javelin-util' => 'a9f14d76', 'javelin-vector' => 'a9f14d76', 'javelin-workflow' => 'a9f14d76', - 'lightbox-attachment-css' => 'a94fc53b', + 'lightbox-attachment-css' => 'e414a0b5', 'maniphest-task-summary-css' => '6b1fccc6', 'maniphest-transaction-detail-css' => '6b1fccc6', - 'phabricator-action-list-view-css' => 'a94fc53b', - 'phabricator-application-launch-view-css' => 'a94fc53b', + 'phabricator-action-list-view-css' => 'e414a0b5', + 'phabricator-application-launch-view-css' => 'e414a0b5', 'phabricator-busy' => '98f60e3f', 'phabricator-content-source-view-css' => 'dd27a69b', - 'phabricator-core-buttons-css' => 'a94fc53b', - 'phabricator-core-css' => 'a94fc53b', - 'phabricator-crumbs-view-css' => 'a94fc53b', - 'phabricator-directory-css' => 'a94fc53b', + 'phabricator-core-buttons-css' => 'e414a0b5', + 'phabricator-core-css' => 'e414a0b5', + 'phabricator-crumbs-view-css' => 'e414a0b5', + 'phabricator-directory-css' => 'e414a0b5', 'phabricator-drag-and-drop-file-upload' => '9488bb69', 'phabricator-dropdown-menu' => '98f60e3f', 'phabricator-file-upload' => '98f60e3f', - 'phabricator-filetree-view-css' => 'a94fc53b', - 'phabricator-flag-css' => 'a94fc53b', - 'phabricator-form-view-css' => 'a94fc53b', - 'phabricator-header-view-css' => 'a94fc53b', + 'phabricator-filetree-view-css' => 'e414a0b5', + 'phabricator-flag-css' => 'e414a0b5', + 'phabricator-form-view-css' => 'e414a0b5', + 'phabricator-header-view-css' => 'e414a0b5', 'phabricator-hovercard' => '98f60e3f', - 'phabricator-jump-nav' => 'a94fc53b', + 'phabricator-jump-nav' => 'e414a0b5', 'phabricator-keyboard-shortcut' => '98f60e3f', 'phabricator-keyboard-shortcut-manager' => '98f60e3f', - 'phabricator-main-menu-view' => 'a94fc53b', + 'phabricator-main-menu-view' => 'e414a0b5', 'phabricator-menu-item' => '98f60e3f', - 'phabricator-nav-view-css' => 'a94fc53b', + 'phabricator-nav-view-css' => 'e414a0b5', 'phabricator-notification' => '98f60e3f', - 'phabricator-notification-css' => 'a94fc53b', - 'phabricator-notification-menu-css' => 'a94fc53b', - 'phabricator-object-item-list-view-css' => 'a94fc53b', + 'phabricator-notification-css' => 'e414a0b5', + 'phabricator-notification-menu-css' => 'e414a0b5', + 'phabricator-object-item-list-view-css' => 'e414a0b5', 'phabricator-object-selector-css' => 'dd27a69b', 'phabricator-phtize' => '98f60e3f', 'phabricator-prefab' => '98f60e3f', 'phabricator-project-tag-css' => '6b1fccc6', - 'phabricator-property-list-view-css' => 'a94fc53b', - 'phabricator-remarkup-css' => 'a94fc53b', + 'phabricator-property-list-view-css' => 'e414a0b5', + 'phabricator-remarkup-css' => 'e414a0b5', 'phabricator-shaped-request' => '9488bb69', - 'phabricator-side-menu-view-css' => 'a94fc53b', - 'phabricator-standard-page-view' => 'a94fc53b', - 'phabricator-tag-view-css' => 'a94fc53b', + 'phabricator-side-menu-view-css' => 'e414a0b5', + 'phabricator-standard-page-view' => 'e414a0b5', + 'phabricator-tag-view-css' => 'e414a0b5', 'phabricator-textareautils' => '98f60e3f', 'phabricator-tooltip' => '98f60e3f', - 'phabricator-transaction-view-css' => 'a94fc53b', - 'phabricator-zindex-css' => 'a94fc53b', - 'phui-form-css' => 'a94fc53b', - 'phui-icon-view-css' => 'a94fc53b', - 'spacing-css' => 'a94fc53b', - 'sprite-apps-large-css' => 'a94fc53b', - 'sprite-gradient-css' => 'a94fc53b', - 'sprite-icons-css' => 'a94fc53b', - 'sprite-menu-css' => 'a94fc53b', - 'syntax-highlighting-css' => 'a94fc53b', + 'phabricator-transaction-view-css' => 'e414a0b5', + 'phabricator-zindex-css' => 'e414a0b5', + 'phui-form-css' => 'e414a0b5', + 'phui-icon-view-css' => 'e414a0b5', + 'spacing-css' => 'e414a0b5', + 'sprite-apps-large-css' => 'e414a0b5', + 'sprite-gradient-css' => 'e414a0b5', + 'sprite-icons-css' => 'e414a0b5', + 'sprite-menu-css' => 'e414a0b5', + 'syntax-highlighting-css' => 'e414a0b5', ), )); diff --git a/webroot/rsrc/css/layout/phabricator-object-item-list-view.css b/webroot/rsrc/css/layout/phabricator-object-item-list-view.css index e5f845931e..dd27571e23 100644 --- a/webroot/rsrc/css/layout/phabricator-object-item-list-view.css +++ b/webroot/rsrc/css/layout/phabricator-object-item-list-view.css @@ -60,7 +60,7 @@ } .phabricator-object-item-content { - margin-top: 2px; + margin-top: 4px; overflow: hidden; } @@ -95,7 +95,6 @@ vertical-align: middle; text-align: right; border-left: 1px solid #c0c5d1; - background: #e9e9f9; box-shadow: inset 1px 0 1px 0px rgba(0, 0, 0, 0.07); } @@ -113,7 +112,7 @@ } .phabricator-object-item-actions .phabricator-menu-item-view:hover { - background: #d9d9ee; + background: #e9e9f9; } .phabricator-object-item-actions .phabricator-menu-item-icon { @@ -204,7 +203,7 @@ .phabricator-object-icon-pane { float: right; - margin-top: 4px; + margin-top: 6px; } .device .phabricator-object-item-no-icon-images .phabricator-object-icon-pane { @@ -405,7 +404,7 @@ } .phabricator-object-item-handle-icon { - margin-left: 3px; + margin: 1px; width: 28px; height: 28px; display: inline-block; @@ -424,9 +423,9 @@ float: right; clear: right; padding: 0 10px; - margin: 3px 0; + margin: 5px 0; font-size: 11px; - color: #333333; + color: #666; white-space: nowrap; overflow: hidden; text-align: right; @@ -447,7 +446,7 @@ } .phabricator-object-list-cards .phabricator-object-item-frame { - min-height: 41px; + min-height: 50px; } .phabricator-object-list-cards .phabricator-object-item-selected {