revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00
Code Issues Releases Wiki Activity

Unfatal the "show change" link in Maniphest description edits

Browse source 
Summary: I missed this callsite in D2946. Transition it to the new markup cache.

Test Plan: Clicked "show change" on a description edit transaction, got the change instead of a fatal.

Reviewers: alanh, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1502

Differential Revision: https://secure.phabricator.com/D2972
This commit is contained in:
epriestley 2012-07-12 21:34:53 -07:00
parent 9574b91e55
commit 621bac74c7
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/maniphest/controller/ManiphestTaskDescriptionChangeController.php
View file

@ -56,14 +56,16 @@ final class ManiphestTaskDescriptionChangeController
$transactions = array($transaction); $transactions = array($transaction);
$phids = array(); $phids = array();
foreach ($transactions as $transaction) { foreach ($transactions as $xaction) {
foreach ($transaction->extractPHIDs() as $phid) { foreach ($xaction->extractPHIDs() as $phid) {
$phids[$phid] = $phid; $phids[$phid] = $phid;
} }
} }
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles(); $handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$engine = PhabricatorMarkupEngine::newManiphestMarkupEngine(); $engine = new PhabricatorMarkupEngine();
$engine->addObject($transaction, ManiphestTransaction::MARKUP_FIELD_BODY);
$engine->process();
$view = new ManiphestTransactionDetailView(); $view = new ManiphestTransactionDetailView();
$view->setTransactionGroup($transactions); $view->setTransactionGroup($transactions);