From 6270114767335d5f911c5a1b842ed541724e7fc1 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Wed, 26 Feb 2014 12:44:58 -0800 Subject: [PATCH] Various linter fixes. Summary: - Removed trailing newlines. - Added newline at EOF. - Removed leading newlines. - Trimmed trailing whitespace. - Spelling fix. - Added newline at EOF Test Plan: N/A Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley CC: hach-que, chad, Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D8344 --- conf/production.conf.php | 1 - resources/sql/patches/000.project.sql | 2 - resources/sql/patches/0000.legacy.sql | 6 -- resources/sql/patches/002.oauth.sql | 2 +- resources/sql/patches/004.daemonrepos.sql | 2 +- resources/sql/patches/005.workers.sql | 2 - resources/sql/patches/007.daemonlog.sql | 2 - resources/sql/patches/009.repo_summary.sql | 2 +- resources/sql/patches/010.herald.sql | 2 - resources/sql/patches/011.badcommit.sql | 2 +- resources/sql/patches/012.dropphidtype.sql | 2 +- .../sql/patches/016.userrealnameindex.sql | 2 +- resources/sql/patches/018.owners.sql | 2 - resources/sql/patches/020.pathcapital.sql | 2 +- resources/sql/patches/021.xhpastview.sql | 1 - resources/sql/patches/024.mlistkeys.sql | 1 - resources/sql/patches/025.commentopt.sql | 2 +- resources/sql/patches/026.diffpropkey.sql | 1 - resources/sql/patches/028.systemagent.sql | 2 +- resources/sql/patches/034.savedheader.sql | 2 +- resources/sql/patches/036.mailkey.sql | 2 +- resources/sql/patches/043.pastebin.sql | 2 - resources/sql/patches/044.countdown.sql | 2 - resources/sql/patches/047.projectstatus.sql | 2 +- resources/sql/patches/049.projectowner.sql | 2 +- resources/sql/patches/052.pastelanguage.sql | 2 +- resources/sql/patches/053.feed.sql | 2 - .../sql/patches/055.add_author_to_files.sql | 2 +- resources/sql/patches/056.slowvote.sql | 4 +- resources/sql/patches/057.parsecache.sql | 2 +- resources/sql/patches/058.missingkeys.sql | 2 +- resources/sql/patches/060.phriction.sql | 2 - .../sql/patches/061.phrictioncontent.sql | 2 +- resources/sql/patches/062.phrictionmenu.sql | 2 +- resources/sql/patches/063.pasteforks.sql | 2 +- resources/sql/patches/064.subprojects.sql | 2 +- resources/sql/patches/065.sshkeys.sql | 2 +- resources/sql/patches/067.preferences.sql | 2 +- .../patches/068.maniphestauxiliarystorage.sql | 10 +- .../sql/patches/076.indexedlanguages.sql | 2 +- resources/sql/patches/080.filekeys.sql | 2 +- resources/sql/patches/086.formeraffil.sql | 2 +- resources/sql/patches/087.phrictiondelete.sql | 2 +- resources/sql/patches/088.audit.sql | 2 - .../patches/092.dropgithubnotification.sql | 2 +- resources/sql/patches/095.directory.sql | 2 +- resources/sql/patches/097.heraldruletypes.sql | 2 +- resources/sql/patches/099.drydock.sql | 2 - resources/sql/patches/106.chatlog.sql | 1 - resources/sql/patches/107.oauthserver.sql | 3 - resources/sql/patches/108.oauthscope.sql | 1 - .../sql/patches/109.oauthclientphidkey.sql | 1 - resources/sql/patches/110.commitaudit.sql | 2 +- .../112.oauthaccesscoderedirecturi.sql | 1 - .../116.utf8-backup-first-expect-wait.sql | 3 - resources/sql/patches/120.noop.sql | 2 +- resources/sql/patches/122.flag.sql | 4 +- resources/sql/patches/124.subpriority.sql | 2 - resources/sql/patches/128.phabricatorcom.sql | 2 +- resources/sql/patches/132.phame.sql | 2 - .../sql/patches/20121209.pholioxactions.sql | 1 - .../sql/patches/20130111.conpherence.sql | 2 - .../patches/20130127.altheraldtranscript.sql | 1 - .../sql/patches/20130131.conpherencepics.sql | 4 +- .../sql/patches/20130214.chatlogchannel.sql | 1 - .../20130215.phabricatorfileaddttl.sql | 4 +- .../sql/patches/20130317.phrictionedge.sql | 1 - resources/sql/patches/20130320.phlux.sql | 1 - resources/sql/patches/20130322.phortune.sql | 1 - .../sql/patches/20130417.externalaccount.sql | 1 - resources/sql/patches/20130519.diviner.sql | 2 - .../sql/patches/20130606.userxactions.sql | 2 - .../sql/patches/20130620.diffxactions.sql | 1 - resources/sql/patches/20130622.doorkeeper.sql | 1 - resources/sql/patches/20130628.legalpadv0.sql | 1 - .../sql/patches/20130723.taskstarttime.sql | 1 - .../sql/patches/20130726.ponderxactions.sql | 1 - .../sql/patches/20130820.filexactions.sql | 1 - resources/sql/patches/20130926.dinkeys.sql | 1 - .../patches/20131030.repostatusmessage.sql | 1 - .../sql/patches/20131224.harbormanual.sql | 1 - .../sql/patches/20131227.heraldobject.sql | 1 - .../sql/patches/20131302.maniphestvalue.sql | 1 - resources/sql/patches/emailtableremove.sql | 2 +- resources/sql/patches/phameblog.sql | 1 - resources/sql/patches/phamedomain.sql | 2 +- resources/sql/patches/phamepolicy.sql | 1 - resources/sql/patches/phiddrop.sql | 2 +- resources/sql/patches/ponder-comments.sql | 2 +- resources/sql/patches/ponder.sql | 2 +- scripts/differential/destroy_revision.php | 1 - scripts/mail/mail_handler.php | 2 - scripts/mail/manage_mail.php | 1 - scripts/repository/test_connection.php | 1 - scripts/search/reindex_maniphest.php | 1 - src/aphront/console/DarkConsoleCore.php | 1 - .../plugin/DarkConsoleServicesPlugin.php | 1 - .../errorlog/DarkConsoleErrorLogPluginAPI.php | 1 - .../event/DarkConsoleEventPluginAPI.php | 1 - .../PhabricatorApplicationAudit.php | 1 - .../events/AuditActionMenuEventListener.php | 1 - ...abricatorAuthProviderConfigTransaction.php | 1 - .../__tests__/PhabricatorApplicationTest.php | 1 - .../PhabricatorApplicationChatLog.php | 1 - .../storage/PhabricatorChatLogChannel.php | 1 - .../PhabricatorSetupCheckImagemagick.php | 1 - .../storage/PhabricatorConfigTransaction.php | 1 - .../ConpherenceActionMenuEventListener.php | 1 - .../ConpherenceHovercardEventListener.php | 1 - .../PhabricatorApplicationDifferential.php | 1 - .../DifferentialRevisionLandController.php | 1 - .../editor/DifferentialRevisionEditor.php | 1 - .../DifferentialActionMenuEventListener.php | 1 - .../DifferentialDefaultFieldSelector.php | 1 - .../mail/DifferentialExceptionMail.php | 2 - .../DifferentialHunkParserTestCase.php | 1 - .../DifferentialCustomFieldNumericIndex.php | 1 - .../DifferentialCustomFieldStorage.php | 1 - .../DifferentialCustomFieldStringIndex.php | 1 - ...rentialChangesetFileTreeSideNavBuilder.php | 1 - .../controller/DiffusionServeController.php | 1 - .../DiffusionHovercardEventListener.php | 1 - .../__tests__/DiffusionPathQueryTestCase.php | 1 - .../PhabricatorApplicationDiviner.php | 1 - .../diviner/atomizer/DivinerPHPAtomizer.php | 1 - .../drydock/worker/DrydockAllocatorWorker.php | 2 - .../PhabricatorApplicationFeed.php | 1 - .../PhabricatorApplicationFlags.php | 1 - .../PhabricatorFlagsUIEventListener.php | 1 - .../herald/adapter/HeraldAdapter.php | 1 - .../herald/engine/HeraldEffect.php | 1 - .../storage/HeraldRuleTransactionComment.php | 1 - .../__tests__/HeraldTranscriptTestCase.php | 2 +- .../storage/PhabricatorFileImageMacro.php | 1 - .../storage/PhabricatorMacroTransaction.php | 1 - .../PhabricatorMacroTransactionComment.php | 1 - .../PhabricatorApplicationManiphest.php | 1 - .../ManiphestCustomFieldNumericIndex.php | 1 - .../storage/ManiphestCustomFieldStorage.php | 1 - .../ManiphestCustomFieldStringIndex.php | 1 - .../storage/ManiphestTransaction.php | 1 - .../PhabricatorApplicationApplications.php | 1 - ...bricatorApplicationUninstallController.php | 1 - ...catorMailImplementationSendGridAdapter.php | 1 - .../PhabricatorApplicationNuance.php | 1 - .../nuance/query/NuanceItemQuery.php | 1 - src/applications/nuance/query/NuanceQuery.php | 1 - .../nuance/query/NuanceQueueQuery.php | 1 - .../nuance/query/NuanceRequestorQuery.php | 1 - .../nuance/source/NuanceSourceDefinition.php | 1 - .../owners/mail/OwnersPackageReplyHandler.php | 2 - ...icatorUserConfiguredCustomFieldStorage.php | 1 - ...PhabricatorUserCustomFieldNumericIndex.php | 1 - .../PhabricatorUserCustomFieldStringIndex.php | 1 - .../storage/PhabricatorUserTransaction.php | 1 - .../event/PholioActionMenuEventListener.php | 1 - .../PhabricatorApplicationPhragment.php | 1 - .../PhabricatorApplicationPhrequent.php | 1 - .../phrequent/query/PhrequentSearchEngine.php | 1 - .../PhabricatorApplicationPhriction.php | 1 - .../PhabricatorApplicationPolicy.php | 1 - .../PhabricatorPolicyCapability.php | 2 - .../policy/query/PhabricatorPolicyQuery.php | 1 - .../ponder/remarkup/PonderRemarkupRule.php | 1 - .../storage/PonderAnswerTransaction.php | 1 - .../PonderAnswerTransactionComment.php | 1 - .../ponder/storage/PonderComment.php | 1 - .../PonderQuestionTransactionComment.php | 1 - ...bricatorProjectCustomFieldNumericIndex.php | 1 - .../PhabricatorProjectCustomFieldStorage.php | 1 - ...abricatorProjectCustomFieldStringIndex.php | 1 - .../storage/ReleephBranchTransaction.php | 1 - .../storage/ReleephProjectTransaction.php | 1 - ...abricatorRepositoryCommitSearchIndexer.php | 1 - .../PhabricatorRepositoryTransaction.php | 1 - .../PhabricatorSearchAttachController.php | 2 +- ...torSettingsPanelConpherencePreferences.php | 1 - ...catorSettingsPanelDeveloperPreferences.php | 1 - ...habricatorSettingsPanelDiffPreferences.php | 1 - ...ricatorSettingsPanelDisplayPreferences.php | 1 - ...habricatorSettingsPanelHomePreferences.php | 1 - ...bricatorSettingsPanelSearchPreferences.php | 1 - .../PhabricatorSlowvoteTransaction.php | 1 - .../PhabricatorSlowvoteTransactionComment.php | 1 - .../PhabricatorApplicationSubscriptions.php | 1 - .../PhabricatorApplicationTransactions.php | 1 - ...catorApplicationTransactionCommentView.php | 1 - ...plicationTransactionTextDiffDetailView.php | 1 - .../PhabricatorApplicationTransactionView.php | 1 - .../storage/PhabricatorTypeaheadResult.php | 1 - .../troubleshooting_https.diviner | 2 +- .../contributing/php_coding_standards.diviner | 1 - .../developer/adding_new_css_and_js.diviner | 1 - src/docs/user/developer/unit_tests.diviner | 1 - .../user/developer/using_oauthserver.diviner | 92 +++++++++---------- .../javascript_object_array.diviner | 1 - .../flavortext/javascript_pitfalls.diviner | 1 - .../things_you_should_do_now.diviner | 2 - src/docs/user/userguide/arcanist_lint.diviner | 1 - .../userguide/differential_test_plans.diviner | 2 - src/docs/user/userguide/herald.diviner | 1 - src/docs/user/userguide/mail_rules.diviner | 1 - .../user/userguide/maniphest_custom.diviner | 1 - src/docs/user/userguide/phame.diviner | 16 ++-- .../PhabricatorInfrastructureTestCase.php | 1 - .../celerity/CeleritySpriteGenerator.php | 2 - ...ricatorBotBaseStreamingProtocolAdapter.php | 1 - .../events/PhabricatorEvent.php | 5 - .../events/PhabricatorEventListener.php | 5 - .../PhabricatorExampleEventListener.php | 5 - src/view/control/AphrontTableView.php | 1 - .../layout/PhabricatorFileLinkListView.php | 1 - src/view/viewutils.php | 1 - .../aphlict/client/aphlict_test_client.php | 1 - support/empty/README | 1 - webroot/index.php | 1 - .../rsrc/css/aphront/lightbox-attachment.css | 1 - .../rsrc/css/aphront/phabricator-nav-view.css | 1 - .../application/conpherence/notification.css | 1 - .../css/application/differential/core.css | 1 - .../application/maniphest/batch-editor.css | 1 - .../css/application/people/people-profile.css | 1 - .../layout/phabricator-action-header-view.css | 1 - webroot/rsrc/css/phui/phui-icon.css | 2 - webroot/rsrc/externals/javelin/LICENSE | 1 - .../core/__tests__/event-stop-and-kill.js | 4 - .../javelin/core/__tests__/install.js | 1 - webroot/rsrc/externals/javelin/docs/Base.js | 5 - .../javelin/docs/concepts/behaviors.diviner | 1 - webroot/rsrc/externals/javelin/docs/onload.js | 1 - .../javelin/ext/reactor/core/DynVal.js | 1 - .../javelin/ext/reactor/core/Reactor.js | 1 - .../javelin/ext/reactor/core/ReactorNode.js | 1 - .../ext/reactor/core/ReactorNodeCalmer.js | 1 - .../externals/javelin/ext/reactor/dom/RDOM.js | 2 - .../externals/javelin/ext/view/HTMLView.js | 1 - .../rsrc/externals/javelin/ext/view/View.js | 1 - .../javelin/ext/view/ViewRenderer.js | 1 - .../externals/javelin/ext/view/ViewVisitor.js | 1 - webroot/rsrc/externals/javelin/lib/DOM.js | 1 - .../externals/javelin/lib/__tests__/URI.js | 1 - .../javelin/lib/__tests__/behavior.js | 1 - .../source/TypeaheadCompositeSource.js | 1 - .../source/TypeaheadOnDemandSource.js | 2 - .../source/TypeaheadPreloadedSource.js | 3 - .../typeahead/source/TypeaheadStaticSource.js | 3 - webroot/rsrc/image/icon/fatcow/README | 2 +- .../config/behavior-reorder-fields.js | 1 - .../rsrc/js/application/countdown/timer.js | 1 - .../behavior-add-reviewers-and-ccs.js | 1 - .../behavior-edit-inline-comments.js | 1 - .../differential/behavior-keyboard-nav.js | 1 - .../diffusion/behavior-commit-branches.js | 1 - .../diffusion/behavior-commit-graph.js | 1 - .../diffusion/behavior-pull-lastmodified.js | 1 - .../doorkeeper/behavior-doorkeeper-tag.js | 1 - .../files/behavior-icon-composer.js | 1 - .../files/behavior-launch-icon-composer.js | 1 - .../harbormaster/behavior-reorder-steps.js | 1 - .../maniphest/behavior-line-chart.js | 1 - .../behavior-transaction-controls.js | 1 - .../search/behavior-reorder-queries.js | 1 - webroot/rsrc/js/core/FileUpload.js | 1 - webroot/rsrc/js/core/MultirowRowManager.js | 1 - webroot/rsrc/js/core/Notification.js | 1 - .../core/behavior-drag-and-drop-textarea.js | 1 - .../js/core/behavior-global-drag-and-drop.js | 1 - webroot/rsrc/swf/test.html | 2 +- 268 files changed, 108 insertions(+), 389 deletions(-) diff --git a/conf/production.conf.php b/conf/production.conf.php index e9a474ee11..c0a7bc2448 100644 --- a/conf/production.conf.php +++ b/conf/production.conf.php @@ -3,4 +3,3 @@ return array( ) + phabricator_read_config_file('default'); - diff --git a/resources/sql/patches/000.project.sql b/resources/sql/patches/000.project.sql index 6013c6c30d..62221ce871 100644 --- a/resources/sql/patches/000.project.sql +++ b/resources/sql/patches/000.project.sql @@ -1,4 +1,3 @@ - create table {$NAMESPACE}_project.project ( id int unsigned not null auto_increment primary key, name varchar(255) not null, @@ -28,4 +27,3 @@ create table {$NAMESPACE}_project.project_affiliation ( dateCreated int unsigned not null, dateModified int unsigned not null ); - diff --git a/resources/sql/patches/0000.legacy.sql b/resources/sql/patches/0000.legacy.sql index f1c179d3f1..fc02040ee3 100644 --- a/resources/sql/patches/0000.legacy.sql +++ b/resources/sql/patches/0000.legacy.sql @@ -1,9 +1,3 @@ - - - - - - /*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */; /*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */; /*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */; diff --git a/resources/sql/patches/002.oauth.sql b/resources/sql/patches/002.oauth.sql index bacd1872a6..4f68261188 100644 --- a/resources/sql/patches/002.oauth.sql +++ b/resources/sql/patches/002.oauth.sql @@ -15,4 +15,4 @@ insert into {$NAMESPACE}_user.user_oauthinfo FROM {$NAMESPACE}_user.user WHERE facebookUID is not null; -alter table {$NAMESPACE}_user.user drop facebookUID; \ No newline at end of file +alter table {$NAMESPACE}_user.user drop facebookUID; diff --git a/resources/sql/patches/004.daemonrepos.sql b/resources/sql/patches/004.daemonrepos.sql index f3e472bc4b..e58aac7233 100644 --- a/resources/sql/patches/004.daemonrepos.sql +++ b/resources/sql/patches/004.daemonrepos.sql @@ -25,4 +25,4 @@ create table {$NAMESPACE}_timeline.timeline_eventdata ( create table {$NAMESPACE}_timeline.timeline_cursor ( name varchar(255) not null primary key, position int unsigned not null -); \ No newline at end of file +); diff --git a/resources/sql/patches/005.workers.sql b/resources/sql/patches/005.workers.sql index 29d402f20f..c05718ebf7 100644 --- a/resources/sql/patches/005.workers.sql +++ b/resources/sql/patches/005.workers.sql @@ -1,5 +1,3 @@ - - create table {$NAMESPACE}_worker.worker_task ( id int unsigned not null auto_increment primary key, taskClass varchar(255) not null, diff --git a/resources/sql/patches/007.daemonlog.sql b/resources/sql/patches/007.daemonlog.sql index 15529ee848..ce1daee490 100644 --- a/resources/sql/patches/007.daemonlog.sql +++ b/resources/sql/patches/007.daemonlog.sql @@ -1,5 +1,3 @@ - - create table {$NAMESPACE}_daemon.daemon_log ( id int unsigned not null auto_increment primary key, daemon varchar(255) not null, diff --git a/resources/sql/patches/009.repo_summary.sql b/resources/sql/patches/009.repo_summary.sql index c5ab4e3021..0509b68d80 100644 --- a/resources/sql/patches/009.repo_summary.sql +++ b/resources/sql/patches/009.repo_summary.sql @@ -4,4 +4,4 @@ CREATE TABLE {$NAMESPACE}_repository.`repository_summary` ( `lastCommitID` int(10) unsigned NOT NULL, `epoch` int(10) unsigned DEFAULT NULL, PRIMARY KEY (`repositoryID`) -); \ No newline at end of file +); diff --git a/resources/sql/patches/010.herald.sql b/resources/sql/patches/010.herald.sql index 59deb29485..57f86acc03 100644 --- a/resources/sql/patches/010.herald.sql +++ b/resources/sql/patches/010.herald.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_herald.herald_action ( id int unsigned not null auto_increment primary key, ruleID int unsigned not null, diff --git a/resources/sql/patches/011.badcommit.sql b/resources/sql/patches/011.badcommit.sql index 76a8255417..58dbc45993 100644 --- a/resources/sql/patches/011.badcommit.sql +++ b/resources/sql/patches/011.badcommit.sql @@ -1,4 +1,4 @@ CREATE TABLE {$NAMESPACE}_repository.repository_badcommit ( fullCommitName varchar(255) binary not null primary key, description longblob not null -); \ No newline at end of file +); diff --git a/resources/sql/patches/012.dropphidtype.sql b/resources/sql/patches/012.dropphidtype.sql index 340a64fccb..53e0e1e937 100644 --- a/resources/sql/patches/012.dropphidtype.sql +++ b/resources/sql/patches/012.dropphidtype.sql @@ -1 +1 @@ -/* This database was later removed entirely. */ \ No newline at end of file +/* This database was later removed entirely. */ diff --git a/resources/sql/patches/016.userrealnameindex.sql b/resources/sql/patches/016.userrealnameindex.sql index 616f062869..58f1235b9c 100644 --- a/resources/sql/patches/016.userrealnameindex.sql +++ b/resources/sql/patches/016.userrealnameindex.sql @@ -1 +1 @@ -ALTER TABLE {$NAMESPACE}_user.user ADD key (realName); \ No newline at end of file +ALTER TABLE {$NAMESPACE}_user.user ADD key (realName); diff --git a/resources/sql/patches/018.owners.sql b/resources/sql/patches/018.owners.sql index c5fe3b9251..c30eb010c5 100644 --- a/resources/sql/patches/018.owners.sql +++ b/resources/sql/patches/018.owners.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_owners.owners_package ( id int unsigned not null auto_increment primary key, phid varchar(64) binary not null, diff --git a/resources/sql/patches/020.pathcapital.sql b/resources/sql/patches/020.pathcapital.sql index 7c825ca5fb..fd4ffd6672 100644 --- a/resources/sql/patches/020.pathcapital.sql +++ b/resources/sql/patches/020.pathcapital.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_differential.differential_diff - CHANGE sourceControlpath sourceControlPath varchar(255); \ No newline at end of file + CHANGE sourceControlpath sourceControlPath varchar(255); diff --git a/resources/sql/patches/021.xhpastview.sql b/resources/sql/patches/021.xhpastview.sql index bb517ed949..875fe0636d 100644 --- a/resources/sql/patches/021.xhpastview.sql +++ b/resources/sql/patches/021.xhpastview.sql @@ -1,4 +1,3 @@ - CREATE TABLE {$NAMESPACE}_xhpastview.xhpastview_parsetree ( id int unsigned not null auto_increment primary key, authorPHID varchar(64) binary, diff --git a/resources/sql/patches/024.mlistkeys.sql b/resources/sql/patches/024.mlistkeys.sql index 4ccf515d35..1063584dd5 100644 --- a/resources/sql/patches/024.mlistkeys.sql +++ b/resources/sql/patches/024.mlistkeys.sql @@ -3,4 +3,3 @@ ALTER TABLE {$NAMESPACE}_metamta.metamta_mailinglist ALTER TABLE {$NAMESPACE}_metamta.metamta_mailinglist ADD UNIQUE KEY (name); - diff --git a/resources/sql/patches/025.commentopt.sql b/resources/sql/patches/025.commentopt.sql index 2c0ee9cd76..0892515aa3 100644 --- a/resources/sql/patches/025.commentopt.sql +++ b/resources/sql/patches/025.commentopt.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_differential.differential_inlinecomment - ADD KEY (revisionID, authorPHID); \ No newline at end of file + ADD KEY (revisionID, authorPHID); diff --git a/resources/sql/patches/026.diffpropkey.sql b/resources/sql/patches/026.diffpropkey.sql index c4d3fb7ce5..40bb69aa94 100644 --- a/resources/sql/patches/026.diffpropkey.sql +++ b/resources/sql/patches/026.diffpropkey.sql @@ -1,3 +1,2 @@ ALTER TABLE {$NAMESPACE}_differential.differential_diffproperty ADD UNIQUE KEY (diffID, name); - diff --git a/resources/sql/patches/028.systemagent.sql b/resources/sql/patches/028.systemagent.sql index bce57aa443..e8e23618cc 100644 --- a/resources/sql/patches/028.systemagent.sql +++ b/resources/sql/patches/028.systemagent.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_user.user - ADD isSystemAgent bool not null default 0; \ No newline at end of file + ADD isSystemAgent bool not null default 0; diff --git a/resources/sql/patches/034.savedheader.sql b/resources/sql/patches/034.savedheader.sql index d7425a5c3d..cb626f20f2 100644 --- a/resources/sql/patches/034.savedheader.sql +++ b/resources/sql/patches/034.savedheader.sql @@ -1,4 +1,4 @@ CREATE TABLE {$NAMESPACE}_herald.herald_savedheader ( phid varchar(64) binary not null primary key, header varchar(255) not null -) ENGINE=InnoDB; \ No newline at end of file +) ENGINE=InnoDB; diff --git a/resources/sql/patches/036.mailkey.sql b/resources/sql/patches/036.mailkey.sql index 6edf512a71..06e05ec64a 100644 --- a/resources/sql/patches/036.mailkey.sql +++ b/resources/sql/patches/036.mailkey.sql @@ -16,4 +16,4 @@ CREATE TABLE {$NAMESPACE}_metamta.metamta_receivedmail ( message longblob, dateCreated int unsigned not null, dateModified int unsigned not null -) engine=innodb; \ No newline at end of file +) engine=innodb; diff --git a/resources/sql/patches/043.pastebin.sql b/resources/sql/patches/043.pastebin.sql index 5e62159474..7d4de868cb 100644 --- a/resources/sql/patches/043.pastebin.sql +++ b/resources/sql/patches/043.pastebin.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_pastebin.pastebin_paste ( id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, title VARCHAR(255) NOT NULL, diff --git a/resources/sql/patches/044.countdown.sql b/resources/sql/patches/044.countdown.sql index 540ab236d0..e25bb876b2 100644 --- a/resources/sql/patches/044.countdown.sql +++ b/resources/sql/patches/044.countdown.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_countdown.countdown_timer ( id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, title VARCHAR(255) NOT NULL, diff --git a/resources/sql/patches/047.projectstatus.sql b/resources/sql/patches/047.projectstatus.sql index 56a19a4a98..b0e563cf77 100644 --- a/resources/sql/patches/047.projectstatus.sql +++ b/resources/sql/patches/047.projectstatus.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_project.project - ADD status varchar(32) not null; \ No newline at end of file + ADD status varchar(32) not null; diff --git a/resources/sql/patches/049.projectowner.sql b/resources/sql/patches/049.projectowner.sql index 98bf55bf57..894166b13a 100644 --- a/resources/sql/patches/049.projectowner.sql +++ b/resources/sql/patches/049.projectowner.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_project.project_affiliation - ADD isOwner bool NOT NULL; \ No newline at end of file + ADD isOwner bool NOT NULL; diff --git a/resources/sql/patches/052.pastelanguage.sql b/resources/sql/patches/052.pastelanguage.sql index 1bfdac0b1f..b517f2dd80 100644 --- a/resources/sql/patches/052.pastelanguage.sql +++ b/resources/sql/patches/052.pastelanguage.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_pastebin.pastebin_paste - ADD COLUMN language VARCHAR(64) NOT NULL; \ No newline at end of file + ADD COLUMN language VARCHAR(64) NOT NULL; diff --git a/resources/sql/patches/053.feed.sql b/resources/sql/patches/053.feed.sql index 96ae6ed0f7..46ad0b4042 100644 --- a/resources/sql/patches/053.feed.sql +++ b/resources/sql/patches/053.feed.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_feed.feed_storydata ( id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, phid VARCHAR(64) BINARY NOT NULL, diff --git a/resources/sql/patches/055.add_author_to_files.sql b/resources/sql/patches/055.add_author_to_files.sql index b43a1c01d9..5c0f541c57 100644 --- a/resources/sql/patches/055.add_author_to_files.sql +++ b/resources/sql/patches/055.add_author_to_files.sql @@ -1,3 +1,3 @@ ALTER TABLE {$NAMESPACE}_file.file ADD COLUMN authorPHID VARCHAR(64) BINARY, - ADD KEY (authorPHID); \ No newline at end of file + ADD KEY (authorPHID); diff --git a/resources/sql/patches/056.slowvote.sql b/resources/sql/patches/056.slowvote.sql index 8a2912bd47..1d9064118d 100644 --- a/resources/sql/patches/056.slowvote.sql +++ b/resources/sql/patches/056.slowvote.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_slowvote.slowvote_poll ( id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, question VARCHAR(255) NOT NULL, @@ -41,4 +39,4 @@ CREATE TABLE {$NAMESPACE}_slowvote.slowvote_choice ( KEY (authorPHID), dateCreated INT UNSIGNED NOT NULL, dateModified INT UNSIGNED NOT NULL -); \ No newline at end of file +); diff --git a/resources/sql/patches/057.parsecache.sql b/resources/sql/patches/057.parsecache.sql index 796fa4592d..5254e3e6e1 100644 --- a/resources/sql/patches/057.parsecache.sql +++ b/resources/sql/patches/057.parsecache.sql @@ -4,4 +4,4 @@ ALTER TABLE {$NAMESPACE}_differential.differential_changeset_parse_cache ADD dateCreated INT UNSIGNED NOT NULL; ALTER TABLE {$NAMESPACE}_differential.differential_changeset_parse_cache - ADD KEY (dateCreated); \ No newline at end of file + ADD KEY (dateCreated); diff --git a/resources/sql/patches/058.missingkeys.sql b/resources/sql/patches/058.missingkeys.sql index 51d2e10aa2..dbb7f8404d 100644 --- a/resources/sql/patches/058.missingkeys.sql +++ b/resources/sql/patches/058.missingkeys.sql @@ -8,4 +8,4 @@ ALTER TABLE {$NAMESPACE}_herald.herald_condition ADD KEY (ruleID); ALTER TABLE {$NAMESPACE}_herald.herald_action - ADD KEY (ruleID); \ No newline at end of file + ADD KEY (ruleID); diff --git a/resources/sql/patches/060.phriction.sql b/resources/sql/patches/060.phriction.sql index 97a330575c..1e352caea9 100644 --- a/resources/sql/patches/060.phriction.sql +++ b/resources/sql/patches/060.phriction.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_phriction.phriction_document ( id INT UNSIGNED NOT NULL, phid VARCHAR(64) BINARY NOT NULL, diff --git a/resources/sql/patches/061.phrictioncontent.sql b/resources/sql/patches/061.phrictioncontent.sql index 958bba3f86..2209068926 100644 --- a/resources/sql/patches/061.phrictioncontent.sql +++ b/resources/sql/patches/061.phrictioncontent.sql @@ -19,4 +19,4 @@ CREATE TABLE {$NAMESPACE}_phriction.phriction_content ( content LONGBLOB NOT NULL, dateCreated INT UNSIGNED NOT NULL, dateModified INT UNSIGNED NOT NULL -) ENGINE=InnoDB; \ No newline at end of file +) ENGINE=InnoDB; diff --git a/resources/sql/patches/062.phrictionmenu.sql b/resources/sql/patches/062.phrictionmenu.sql index 9ce4021be1..bcc80bf648 100644 --- a/resources/sql/patches/062.phrictionmenu.sql +++ b/resources/sql/patches/062.phrictionmenu.sql @@ -1,3 +1,3 @@ /* Older versions incorrectly computed the depth for the root page. */ UPDATE {$NAMESPACE}_phriction.phriction_document - SET depth = 0 where slug = '/'; \ No newline at end of file + SET depth = 0 where slug = '/'; diff --git a/resources/sql/patches/063.pasteforks.sql b/resources/sql/patches/063.pasteforks.sql index 978b2c16e4..63a5ef70b5 100644 --- a/resources/sql/patches/063.pasteforks.sql +++ b/resources/sql/patches/063.pasteforks.sql @@ -1,3 +1,3 @@ ALTER TABLE {$NAMESPACE}_pastebin.pastebin_paste ADD COLUMN parentPHID VARCHAR(64) BINARY, - ADD KEY (parentPHID); \ No newline at end of file + ADD KEY (parentPHID); diff --git a/resources/sql/patches/064.subprojects.sql b/resources/sql/patches/064.subprojects.sql index 0baebc8ae8..688e8baaac 100644 --- a/resources/sql/patches/064.subprojects.sql +++ b/resources/sql/patches/064.subprojects.sql @@ -8,4 +8,4 @@ CREATE TABLE {$NAMESPACE}_project.project_subproject ( subprojectPHID varchar(64) BINARY NOT NULL, PRIMARY KEY (subprojectPHID, projectPHID), UNIQUE KEY (projectPHID, subprojectPHID) -) ENGINE=InnoDB; \ No newline at end of file +) ENGINE=InnoDB; diff --git a/resources/sql/patches/065.sshkeys.sql b/resources/sql/patches/065.sshkeys.sql index 0fb7e1d33b..766e4affba 100644 --- a/resources/sql/patches/065.sshkeys.sql +++ b/resources/sql/patches/065.sshkeys.sql @@ -9,4 +9,4 @@ CREATE TABLE {$NAMESPACE}_user.user_sshkey ( keyComment varchar(255), dateCreated INT UNSIGNED NOT NULL, dateModified INT UNSIGNED NOT NULL -) ENGINE=InnoDB; \ No newline at end of file +) ENGINE=InnoDB; diff --git a/resources/sql/patches/067.preferences.sql b/resources/sql/patches/067.preferences.sql index 4623688e52..9db23c5475 100644 --- a/resources/sql/patches/067.preferences.sql +++ b/resources/sql/patches/067.preferences.sql @@ -1 +1 @@ -/* This used to be a "directory" update. */; \ No newline at end of file +/* This used to be a "directory" update. */; diff --git a/resources/sql/patches/068.maniphestauxiliarystorage.sql b/resources/sql/patches/068.maniphestauxiliarystorage.sql index 429d0dac97..bd7576b186 100644 --- a/resources/sql/patches/068.maniphestauxiliarystorage.sql +++ b/resources/sql/patches/068.maniphestauxiliarystorage.sql @@ -1,9 +1,9 @@ -create table {$NAMESPACE}_maniphest.maniphest_taskauxiliarystorage +create table {$NAMESPACE}_maniphest.maniphest_taskauxiliarystorage (id int unsigned not null auto_increment primary key, - taskPHID varchar(64) binary not null, - name varchar(255) not null, - value varchar(255) not null, + taskPHID varchar(64) binary not null, + name varchar(255) not null, + value varchar(255) not null, unique key (taskPHID,name), dateCreated int unsigned not null, dateModified int unsigned not null) - ENGINE = InnoDB; \ No newline at end of file + ENGINE = InnoDB; diff --git a/resources/sql/patches/076.indexedlanguages.sql b/resources/sql/patches/076.indexedlanguages.sql index 1d3069f1d9..6ff83f73ad 100644 --- a/resources/sql/patches/076.indexedlanguages.sql +++ b/resources/sql/patches/076.indexedlanguages.sql @@ -1,4 +1,4 @@ ALTER TABLE {$NAMESPACE}_repository.repository_arcanistproject ADD symbolIndexLanguages LONGBLOB NOT NULL; ALTER TABLE {$NAMESPACE}_repository.repository_arcanistproject - ADD symbolIndexProjects LONGBLOB NOT NULL; \ No newline at end of file + ADD symbolIndexProjects LONGBLOB NOT NULL; diff --git a/resources/sql/patches/080.filekeys.sql b/resources/sql/patches/080.filekeys.sql index 2d8a35a02f..31e559012a 100644 --- a/resources/sql/patches/080.filekeys.sql +++ b/resources/sql/patches/080.filekeys.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_file.file - ADD secretKey VARCHAR(20) BINARY; \ No newline at end of file + ADD secretKey VARCHAR(20) BINARY; diff --git a/resources/sql/patches/086.formeraffil.sql b/resources/sql/patches/086.formeraffil.sql index 2394a10aa9..b2f44a5b65 100644 --- a/resources/sql/patches/086.formeraffil.sql +++ b/resources/sql/patches/086.formeraffil.sql @@ -1 +1 @@ -ALTER TABLE {$NAMESPACE}_project.project_affiliation DROP status; \ No newline at end of file +ALTER TABLE {$NAMESPACE}_project.project_affiliation DROP status; diff --git a/resources/sql/patches/087.phrictiondelete.sql b/resources/sql/patches/087.phrictiondelete.sql index b07c5358ff..384960bc87 100644 --- a/resources/sql/patches/087.phrictiondelete.sql +++ b/resources/sql/patches/087.phrictiondelete.sql @@ -5,4 +5,4 @@ ALTER TABLE {$NAMESPACE}_phriction.phriction_content ADD changeType INT UNSIGNED NOT NULL DEFAULT 0; ALTER TABLE {$NAMESPACE}_phriction.phriction_content - ADD changeRef INT UNSIGNED DEFAULT NULL; \ No newline at end of file + ADD changeRef INT UNSIGNED DEFAULT NULL; diff --git a/resources/sql/patches/088.audit.sql b/resources/sql/patches/088.audit.sql index ea93e1c928..63ace7f88c 100644 --- a/resources/sql/patches/088.audit.sql +++ b/resources/sql/patches/088.audit.sql @@ -1,5 +1,3 @@ - - ALTER TABLE {$NAMESPACE}_owners.owners_packagecommitrelationship ADD COLUMN `auditStatus` varchar(64) NOT NULL, ADD COLUMN `auditReasons` longtext NOT NULL, diff --git a/resources/sql/patches/092.dropgithubnotification.sql b/resources/sql/patches/092.dropgithubnotification.sql index 9fcfa76629..95a24fa6b8 100644 --- a/resources/sql/patches/092.dropgithubnotification.sql +++ b/resources/sql/patches/092.dropgithubnotification.sql @@ -1 +1 @@ -DROP TABLE {$NAMESPACE}_repository.repository_githubnotification; \ No newline at end of file +DROP TABLE {$NAMESPACE}_repository.repository_githubnotification; diff --git a/resources/sql/patches/095.directory.sql b/resources/sql/patches/095.directory.sql index 4623688e52..9db23c5475 100644 --- a/resources/sql/patches/095.directory.sql +++ b/resources/sql/patches/095.directory.sql @@ -1 +1 @@ -/* This used to be a "directory" update. */; \ No newline at end of file +/* This used to be a "directory" update. */; diff --git a/resources/sql/patches/097.heraldruletypes.sql b/resources/sql/patches/097.heraldruletypes.sql index b975403737..837359f490 100644 --- a/resources/sql/patches/097.heraldruletypes.sql +++ b/resources/sql/patches/097.heraldruletypes.sql @@ -1,2 +1,2 @@ ALTER TABLE {$NAMESPACE}_herald.herald_rule ADD ruleType varchar(255) not null DEFAULT 'global'; -CREATE INDEX IDX_RULE_TYPE on {$NAMESPACE}_herald.herald_rule (ruleType); \ No newline at end of file +CREATE INDEX IDX_RULE_TYPE on {$NAMESPACE}_herald.herald_rule (ruleType); diff --git a/resources/sql/patches/099.drydock.sql b/resources/sql/patches/099.drydock.sql index 87187f8bf7..74ae726a25 100644 --- a/resources/sql/patches/099.drydock.sql +++ b/resources/sql/patches/099.drydock.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_drydock.drydock_resource ( id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, phid VARCHAR(64) BINARY NOT NULL, diff --git a/resources/sql/patches/106.chatlog.sql b/resources/sql/patches/106.chatlog.sql index 419420f410..bbb9be945e 100644 --- a/resources/sql/patches/106.chatlog.sql +++ b/resources/sql/patches/106.chatlog.sql @@ -1,4 +1,3 @@ - CREATE TABLE {$NAMESPACE}_chatlog.chatlog_event ( id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT, channel VARCHAR(64) BINARY NOT NULL, diff --git a/resources/sql/patches/107.oauthserver.sql b/resources/sql/patches/107.oauthserver.sql index c2f1ae92cc..2865535af1 100644 --- a/resources/sql/patches/107.oauthserver.sql +++ b/resources/sql/patches/107.oauthserver.sql @@ -1,5 +1,3 @@ - - CREATE TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthserverclient` ( `id` int(10) unsigned NOT NULL AUTO_INCREMENT, `phid` varchar(64) BINARY NOT NULL, @@ -48,4 +46,3 @@ CREATE TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthserveraccesstoken` ( PRIMARY KEY (`id`), UNIQUE KEY `token` (`token`) ) ENGINE=InnoDB; - diff --git a/resources/sql/patches/108.oauthscope.sql b/resources/sql/patches/108.oauthscope.sql index f17a296956..e7d8155572 100644 --- a/resources/sql/patches/108.oauthscope.sql +++ b/resources/sql/patches/108.oauthscope.sql @@ -3,4 +3,3 @@ ALTER TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthclientauthorization` ALTER TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthserveraccesstoken` DROP `dateExpires`; - diff --git a/resources/sql/patches/109.oauthclientphidkey.sql b/resources/sql/patches/109.oauthclientphidkey.sql index 5570043612..90ea7f4288 100644 --- a/resources/sql/patches/109.oauthclientphidkey.sql +++ b/resources/sql/patches/109.oauthclientphidkey.sql @@ -1,3 +1,2 @@ ALTER TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthserverclient` ADD KEY `creatorPHID` (`creatorPHID`) - diff --git a/resources/sql/patches/110.commitaudit.sql b/resources/sql/patches/110.commitaudit.sql index 4fffa055a8..9c051ee1ca 100644 --- a/resources/sql/patches/110.commitaudit.sql +++ b/resources/sql/patches/110.commitaudit.sql @@ -8,4 +8,4 @@ ALTER TABLE {$NAMESPACE}_repository.repository_commit ADD auditStatus INT UNSIGNED NOT NULL; ALTER TABLE {$NAMESPACE}_repository.repository_commit - ADD KEY (authorPHID, auditStatus, epoch); \ No newline at end of file + ADD KEY (authorPHID, auditStatus, epoch); diff --git a/resources/sql/patches/112.oauthaccesscoderedirecturi.sql b/resources/sql/patches/112.oauthaccesscoderedirecturi.sql index 6131d63aca..56f258453e 100644 --- a/resources/sql/patches/112.oauthaccesscoderedirecturi.sql +++ b/resources/sql/patches/112.oauthaccesscoderedirecturi.sql @@ -1,3 +1,2 @@ ALTER TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthserverauthorizationcode` ADD `redirectURI` varchar(255) NOT NULL - diff --git a/resources/sql/patches/116.utf8-backup-first-expect-wait.sql b/resources/sql/patches/116.utf8-backup-first-expect-wait.sql index 7d463b6dc4..eda5573641 100644 --- a/resources/sql/patches/116.utf8-backup-first-expect-wait.sql +++ b/resources/sql/patches/116.utf8-backup-first-expect-wait.sql @@ -1123,6 +1123,3 @@ ALTER TABLE `{$NAMESPACE}_xhpastview`.`xhpastview_parsetree` MODIFY `authorPHID` varchar(64) COLLATE utf8_bin, MODIFY `input` longtext COLLATE utf8_bin NOT NULL, MODIFY `stdout` longtext COLLATE utf8_bin NOT NULL; - - - diff --git a/resources/sql/patches/120.noop.sql b/resources/sql/patches/120.noop.sql index b730eaa0d3..a8ab6db8fd 100644 --- a/resources/sql/patches/120.noop.sql +++ b/resources/sql/patches/120.noop.sql @@ -1,2 +1,2 @@ /* Do nothing, patch 121 got committed before there was a patch 120. */ -SELECT 1; \ No newline at end of file +SELECT 1; diff --git a/resources/sql/patches/122.flag.sql b/resources/sql/patches/122.flag.sql index 6b666a6855..7f66669930 100644 --- a/resources/sql/patches/122.flag.sql +++ b/resources/sql/patches/122.flag.sql @@ -1,5 +1,3 @@ - - CREATE TABLE {$NAMESPACE}_flag.flag ( id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, ownerPHID varchar(64) COLLATE utf8_bin NOT NULL, @@ -13,4 +11,4 @@ CREATE TABLE {$NAMESPACE}_flag.flag ( UNIQUE KEY (ownerPHID, type, objectPHID), KEY (objectPHID) -) ENGINE=InnoDB; \ No newline at end of file +) ENGINE=InnoDB; diff --git a/resources/sql/patches/124.subpriority.sql b/resources/sql/patches/124.subpriority.sql index 2133b6e574..cd826a1efc 100644 --- a/resources/sql/patches/124.subpriority.sql +++ b/resources/sql/patches/124.subpriority.sql @@ -7,5 +7,3 @@ ALTER TABLE {$NAMESPACE}_maniphest.maniphest_task /* Seed the subpriority column with reasonable values that keep order stable. */ UPDATE {$NAMESPACE}_maniphest.maniphest_task SET subpriority = (UNIX_TIMESTAMP() - dateModified); - - diff --git a/resources/sql/patches/128.phabricatorcom.sql b/resources/sql/patches/128.phabricatorcom.sql index 4623688e52..9db23c5475 100644 --- a/resources/sql/patches/128.phabricatorcom.sql +++ b/resources/sql/patches/128.phabricatorcom.sql @@ -1 +1 @@ -/* This used to be a "directory" update. */; \ No newline at end of file +/* This used to be a "directory" update. */; diff --git a/resources/sql/patches/132.phame.sql b/resources/sql/patches/132.phame.sql index e56de6fe91..be513ea050 100644 --- a/resources/sql/patches/132.phame.sql +++ b/resources/sql/patches/132.phame.sql @@ -1,5 +1,3 @@ - - CREATE TABLE `{$NAMESPACE}_phame`.`phame_post` ( `id` INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY, `phid` VARCHAR(64) BINARY NOT NULL COLLATE utf8_bin, diff --git a/resources/sql/patches/20121209.pholioxactions.sql b/resources/sql/patches/20121209.pholioxactions.sql index 70f2280057..ab302801ba 100644 --- a/resources/sql/patches/20121209.pholioxactions.sql +++ b/resources/sql/patches/20121209.pholioxactions.sql @@ -48,4 +48,3 @@ CREATE TABLE {$NAMESPACE}_pholio.pholio_transaction_comment ( UNIQUE KEY `key_draft` (authorPHID, mockID, transactionPHID) ) ENGINE=InnoDB, COLLATE utf8_general_ci; - diff --git a/resources/sql/patches/20130111.conpherence.sql b/resources/sql/patches/20130111.conpherence.sql index bea6b1820e..519271771b 100644 --- a/resources/sql/patches/20130111.conpherence.sql +++ b/resources/sql/patches/20130111.conpherence.sql @@ -1,4 +1,3 @@ - CREATE TABLE {$NAMESPACE}_conpherence.conpherence_thread ( id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT, phid VARCHAR(64) NOT NULL COLLATE utf8_bin, @@ -80,4 +79,3 @@ CREATE TABLE {$NAMESPACE}_conpherence.conpherence_transaction_comment ( UNIQUE KEY `key_draft` (authorPHID, conpherencePHID, transactionPHID) ) ENGINE=InnoDB, COLLATE utf8_general_ci; - diff --git a/resources/sql/patches/20130127.altheraldtranscript.sql b/resources/sql/patches/20130127.altheraldtranscript.sql index 5b59c4d40b..2f3f916df0 100644 --- a/resources/sql/patches/20130127.altheraldtranscript.sql +++ b/resources/sql/patches/20130127.altheraldtranscript.sql @@ -1,3 +1,2 @@ ALTER TABLE `{$NAMESPACE}_herald`.`herald_transcript` DROP `psth`; - diff --git a/resources/sql/patches/20130131.conpherencepics.sql b/resources/sql/patches/20130131.conpherencepics.sql index 421291225f..0b22a89967 100644 --- a/resources/sql/patches/20130131.conpherencepics.sql +++ b/resources/sql/patches/20130131.conpherencepics.sql @@ -1,6 +1,6 @@ -ALTER TABLE {$NAMESPACE}_conpherence.conpherence_thread +ALTER TABLE {$NAMESPACE}_conpherence.conpherence_thread DROP imagePHID, ADD imagePHIDs LONGTEXT COLLATE utf8_bin NOT NULL AFTER title; -UPDATE {$NAMESPACE}_conpherence.conpherence_thread +UPDATE {$NAMESPACE}_conpherence.conpherence_thread SET imagePHIDs = '{}' WHERE imagePHIDs = ''; diff --git a/resources/sql/patches/20130214.chatlogchannel.sql b/resources/sql/patches/20130214.chatlogchannel.sql index a28b1d0a4b..6bb0a777ac 100644 --- a/resources/sql/patches/20130214.chatlogchannel.sql +++ b/resources/sql/patches/20130214.chatlogchannel.sql @@ -1,4 +1,3 @@ - CREATE TABLE {$NAMESPACE}_chatlog.chatlog_channel ( id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT, serviceName VARCHAR(64) COLLATE utf8_bin NOT NULL, diff --git a/resources/sql/patches/20130215.phabricatorfileaddttl.sql b/resources/sql/patches/20130215.phabricatorfileaddttl.sql index d8c3cbf8b3..eece5414e8 100644 --- a/resources/sql/patches/20130215.phabricatorfileaddttl.sql +++ b/resources/sql/patches/20130215.phabricatorfileaddttl.sql @@ -1,3 +1,3 @@ -ALTER TABLE {$NAMESPACE}_file.file - ADD ttl INT(10) UNSIGNED DEFAULT NULL, +ALTER TABLE {$NAMESPACE}_file.file + ADD ttl INT(10) UNSIGNED DEFAULT NULL, ADD KEY key_ttl (ttl); diff --git a/resources/sql/patches/20130317.phrictionedge.sql b/resources/sql/patches/20130317.phrictionedge.sql index fdeed8f178..802d259bcb 100644 --- a/resources/sql/patches/20130317.phrictionedge.sql +++ b/resources/sql/patches/20130317.phrictionedge.sql @@ -13,4 +13,3 @@ CREATE TABLE {$NAMESPACE}_phriction.edgedata ( id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT, data LONGTEXT NOT NULL COLLATE utf8_bin ) ENGINE=InnoDB, COLLATE utf8_general_ci; - diff --git a/resources/sql/patches/20130320.phlux.sql b/resources/sql/patches/20130320.phlux.sql index fc3db93a42..07e6fd9949 100644 --- a/resources/sql/patches/20130320.phlux.sql +++ b/resources/sql/patches/20130320.phlux.sql @@ -29,4 +29,3 @@ CREATE TABLE {$NAMESPACE}_phlux.phlux_transaction ( UNIQUE KEY `key_phid` (phid), KEY `key_object` (objectPHID) ) ENGINE=InnoDB DEFAULT CHARSET=utf8; - diff --git a/resources/sql/patches/20130322.phortune.sql b/resources/sql/patches/20130322.phortune.sql index 5105716972..5a9447aab0 100644 --- a/resources/sql/patches/20130322.phortune.sql +++ b/resources/sql/patches/20130322.phortune.sql @@ -43,4 +43,3 @@ CREATE TABLE {$NAMESPACE}_phortune.edgedata ( id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT, data LONGTEXT NOT NULL COLLATE utf8_bin ) ENGINE=InnoDB DEFAULT CHARSET=utf8; - diff --git a/resources/sql/patches/20130417.externalaccount.sql b/resources/sql/patches/20130417.externalaccount.sql index 0d87db0afb..806117709a 100644 --- a/resources/sql/patches/20130417.externalaccount.sql +++ b/resources/sql/patches/20130417.externalaccount.sql @@ -1,4 +1,3 @@ - CREATE TABLE {$NAMESPACE}_user.externalaccount ( id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT, phid VARCHAR(64) COLLATE utf8_bin NOT NULL UNIQUE KEY, diff --git a/resources/sql/patches/20130519.diviner.sql b/resources/sql/patches/20130519.diviner.sql index fc746bb354..7adc386baa 100644 --- a/resources/sql/patches/20130519.diviner.sql +++ b/resources/sql/patches/20130519.diviner.sql @@ -34,5 +34,3 @@ CREATE TABLE {$NAMESPACE}_diviner.diviner_liveatom ( atomData LONGTEXT NOT NULL COLLATE utf8_bin, UNIQUE KEY (symbolPHID) ) ENGINE=InnoDB, DEFAULT CHARSET = utf8; - - diff --git a/resources/sql/patches/20130606.userxactions.sql b/resources/sql/patches/20130606.userxactions.sql index 3d266e826c..5659c5e56c 100644 --- a/resources/sql/patches/20130606.userxactions.sql +++ b/resources/sql/patches/20130606.userxactions.sql @@ -19,5 +19,3 @@ CREATE TABLE {$NAMESPACE}_user.user_transaction ( KEY `key_object` (objectPHID) ) ENGINE=InnoDB, COLLATE utf8_general_ci; - - diff --git a/resources/sql/patches/20130620.diffxactions.sql b/resources/sql/patches/20130620.diffxactions.sql index 7b63f895f6..bd88123b35 100644 --- a/resources/sql/patches/20130620.diffxactions.sql +++ b/resources/sql/patches/20130620.diffxactions.sql @@ -48,4 +48,3 @@ CREATE TABLE {$NAMESPACE}_differential.differential_transaction_comment ( UNIQUE KEY `key_draft` (authorPHID, revisionPHID, transactionPHID) ) ENGINE=InnoDB, COLLATE utf8_general_ci; - diff --git a/resources/sql/patches/20130622.doorkeeper.sql b/resources/sql/patches/20130622.doorkeeper.sql index 80329f03d5..6125e613cc 100644 --- a/resources/sql/patches/20130622.doorkeeper.sql +++ b/resources/sql/patches/20130622.doorkeeper.sql @@ -32,4 +32,3 @@ CREATE TABLE {$NAMESPACE}_doorkeeper.edgedata ( id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT, data LONGTEXT NOT NULL COLLATE utf8_bin ) ENGINE=InnoDB, COLLATE utf8_general_ci; - diff --git a/resources/sql/patches/20130628.legalpadv0.sql b/resources/sql/patches/20130628.legalpadv0.sql index fa843f18d9..723e25c552 100644 --- a/resources/sql/patches/20130628.legalpadv0.sql +++ b/resources/sql/patches/20130628.legalpadv0.sql @@ -101,4 +101,3 @@ CREATE TABLE {$NAMESPACE}_legalpad.legalpad_transaction_comment ( UNIQUE KEY `key_draft` (authorPHID, documentID, transactionPHID) ) ENGINE=InnoDB, COLLATE utf8_general_ci; - diff --git a/resources/sql/patches/20130723.taskstarttime.sql b/resources/sql/patches/20130723.taskstarttime.sql index eee39b8e82..2ca759db1e 100644 --- a/resources/sql/patches/20130723.taskstarttime.sql +++ b/resources/sql/patches/20130723.taskstarttime.sql @@ -3,4 +3,3 @@ ALTER TABLE {$NAMESPACE}_worker.worker_activetask ALTER TABLE {$NAMESPACE}_worker.worker_activetask ADD KEY `key_failuretime` (`failureTime`); - diff --git a/resources/sql/patches/20130726.ponderxactions.sql b/resources/sql/patches/20130726.ponderxactions.sql index a3caf75d75..107eae2c16 100644 --- a/resources/sql/patches/20130726.ponderxactions.sql +++ b/resources/sql/patches/20130726.ponderxactions.sql @@ -79,4 +79,3 @@ CREATE TABLE {$NAMESPACE}_ponder.ponder_answertransaction_comment ( UNIQUE KEY `key_version` (transactionPHID, commentVersion) ) ENGINE=InnoDB, COLLATE utf8_general_ci; - diff --git a/resources/sql/patches/20130820.filexactions.sql b/resources/sql/patches/20130820.filexactions.sql index 8f92df563f..5febdc2710 100644 --- a/resources/sql/patches/20130820.filexactions.sql +++ b/resources/sql/patches/20130820.filexactions.sql @@ -39,4 +39,3 @@ CREATE TABLE {$NAMESPACE}_file.file_transaction_comment ( UNIQUE KEY `key_draft` (authorPHID, transactionPHID) ) ENGINE=InnoDB, COLLATE utf8_general_ci; - diff --git a/resources/sql/patches/20130926.dinkeys.sql b/resources/sql/patches/20130926.dinkeys.sql index a96b7be9c0..7d7caf8b87 100644 --- a/resources/sql/patches/20130926.dinkeys.sql +++ b/resources/sql/patches/20130926.dinkeys.sql @@ -12,4 +12,3 @@ ALTER TABLE {$NAMESPACE}_differential.differential_transaction_comment ALTER TABLE {$NAMESPACE}_differential.differential_transaction_comment ADD KEY `key_legacy` (legacyCommentID); - diff --git a/resources/sql/patches/20131030.repostatusmessage.sql b/resources/sql/patches/20131030.repostatusmessage.sql index 159f5dadb1..17ee068368 100644 --- a/resources/sql/patches/20131030.repostatusmessage.sql +++ b/resources/sql/patches/20131030.repostatusmessage.sql @@ -7,4 +7,3 @@ CREATE TABLE {$NAMESPACE}_repository.repository_statusmessage ( epoch INT UNSIGNED NOT NULL, UNIQUE KEY (repositoryID, statusType) ) ENGINE=InnoDB, CHARSET utf8; - diff --git a/resources/sql/patches/20131224.harbormanual.sql b/resources/sql/patches/20131224.harbormanual.sql index fb5a5ee970..0ce5aba968 100644 --- a/resources/sql/patches/20131224.harbormanual.sql +++ b/resources/sql/patches/20131224.harbormanual.sql @@ -3,4 +3,3 @@ ALTER TABLE {$NAMESPACE}_harbormaster.harbormaster_buildable ALTER TABLE {$NAMESPACE}_harbormaster.harbormaster_buildable ADD KEY `key_manual` (isManualBuildable); - diff --git a/resources/sql/patches/20131227.heraldobject.sql b/resources/sql/patches/20131227.heraldobject.sql index b53d95ab86..04f886d9df 100644 --- a/resources/sql/patches/20131227.heraldobject.sql +++ b/resources/sql/patches/20131227.heraldobject.sql @@ -3,4 +3,3 @@ ALTER TABLE {$NAMESPACE}_herald.herald_rule ALTER TABLE {$NAMESPACE}_herald.herald_rule ADD KEY `key_trigger` (triggerObjectPHID); - diff --git a/resources/sql/patches/20131302.maniphestvalue.sql b/resources/sql/patches/20131302.maniphestvalue.sql index 43f703a06d..bfcb9336f9 100644 --- a/resources/sql/patches/20131302.maniphestvalue.sql +++ b/resources/sql/patches/20131302.maniphestvalue.sql @@ -1,3 +1,2 @@ ALTER TABLE {$NAMESPACE}_maniphest.maniphest_taskauxiliarystorage MODIFY value LONGTEXT COLLATE utf8_bin; - diff --git a/resources/sql/patches/emailtableremove.sql b/resources/sql/patches/emailtableremove.sql index be31125fec..9712d660dc 100644 --- a/resources/sql/patches/emailtableremove.sql +++ b/resources/sql/patches/emailtableremove.sql @@ -1 +1 @@ -ALTER TABLE {$NAMESPACE}_user.user DROP email; \ No newline at end of file +ALTER TABLE {$NAMESPACE}_user.user DROP email; diff --git a/resources/sql/patches/phameblog.sql b/resources/sql/patches/phameblog.sql index b54d76c8ed..74ae9c8f89 100644 --- a/resources/sql/patches/phameblog.sql +++ b/resources/sql/patches/phameblog.sql @@ -28,4 +28,3 @@ CREATE TABLE {$NAMESPACE}_phame.edgedata ( ALTER TABLE {$NAMESPACE}_phame.phame_post ADD KEY `instancePosts` (`visibility`, `datePublished`, `id`); - diff --git a/resources/sql/patches/phamedomain.sql b/resources/sql/patches/phamedomain.sql index 066fa37e46..1feddd7ab4 100644 --- a/resources/sql/patches/phamedomain.sql +++ b/resources/sql/patches/phamedomain.sql @@ -1,4 +1,4 @@ ALTER TABLE `{$NAMESPACE}_phame`.`phame_blog` - ADD COLUMN `domain` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin + ADD COLUMN `domain` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin AFTER `description`, ADD UNIQUE KEY (`domain`); diff --git a/resources/sql/patches/phamepolicy.sql b/resources/sql/patches/phamepolicy.sql index d48bdf2223..be86021e4e 100644 --- a/resources/sql/patches/phamepolicy.sql +++ b/resources/sql/patches/phamepolicy.sql @@ -15,4 +15,3 @@ ALTER TABLE `{$NAMESPACE}_phame`.`phame_blog` UPDATE `{$NAMESPACE}_phame`.`phame_blog` SET joinPolicy = 'users' WHERE joinPolicy IS NULL; - diff --git a/resources/sql/patches/phiddrop.sql b/resources/sql/patches/phiddrop.sql index 53c95e5c20..6f3c3344d2 100644 --- a/resources/sql/patches/phiddrop.sql +++ b/resources/sql/patches/phiddrop.sql @@ -1 +1 @@ -DROP DATABASE IF EXISTS {$NAMESPACE}_phid; \ No newline at end of file +DROP DATABASE IF EXISTS {$NAMESPACE}_phid; diff --git a/resources/sql/patches/ponder-comments.sql b/resources/sql/patches/ponder-comments.sql index 1f21bfc3e6..b93092f67b 100644 --- a/resources/sql/patches/ponder-comments.sql +++ b/resources/sql/patches/ponder-comments.sql @@ -8,4 +8,4 @@ CREATE TABLE `{$NAMESPACE}_ponder`.`ponder_comment` ( PRIMARY KEY (`id`), KEY `authorPHID` (`authorPHID`), KEY `targetPHID` (`targetPHID`) -) ENGINE=InnoDB DEFAULT CHARSET=utf8; \ No newline at end of file +) ENGINE=InnoDB DEFAULT CHARSET=utf8; diff --git a/resources/sql/patches/ponder.sql b/resources/sql/patches/ponder.sql index 86e36a075b..868dbe66ce 100644 --- a/resources/sql/patches/ponder.sql +++ b/resources/sql/patches/ponder.sql @@ -47,4 +47,4 @@ CREATE TABLE `{$NAMESPACE}_ponder`.`edgedata` ( `id` int(10) unsigned NOT NULL AUTO_INCREMENT, `data` longtext CHARACTER SET utf8 COLLATE utf8_bin NOT NULL, PRIMARY KEY (`id`) -) ENGINE=InnoDB DEFAULT CHARSET=utf8; \ No newline at end of file +) ENGINE=InnoDB DEFAULT CHARSET=utf8; diff --git a/scripts/differential/destroy_revision.php b/scripts/differential/destroy_revision.php index af97de3932..8f24e6d17d 100755 --- a/scripts/differential/destroy_revision.php +++ b/scripts/differential/destroy_revision.php @@ -49,4 +49,3 @@ if (!$ok) { $revision->delete(); echo "OK, destroyed revision.\n"; - diff --git a/scripts/mail/mail_handler.php b/scripts/mail/mail_handler.php index 11d8f1c29f..63d6688a5c 100755 --- a/scripts/mail/mail_handler.php +++ b/scripts/mail/mail_handler.php @@ -92,5 +92,3 @@ try { throw $e; } - - diff --git a/scripts/mail/manage_mail.php b/scripts/mail/manage_mail.php index fefb1e0da3..9822565175 100755 --- a/scripts/mail/manage_mail.php +++ b/scripts/mail/manage_mail.php @@ -19,4 +19,3 @@ $workflows = id(new PhutilSymbolLoader()) ->loadObjects(); $workflows[] = new PhutilHelpArgumentWorkflow(); $args->parseWorkflows($workflows); - diff --git a/scripts/repository/test_connection.php b/scripts/repository/test_connection.php index 6047f3429d..226a967c78 100755 --- a/scripts/repository/test_connection.php +++ b/scripts/repository/test_connection.php @@ -3,4 +3,3 @@ echo "This script is obsolete. Use `bin/repository` to manage repositories.\n"; exit(1); - diff --git a/scripts/search/reindex_maniphest.php b/scripts/search/reindex_maniphest.php index ed4670b690..a99e79e342 100755 --- a/scripts/search/reindex_maniphest.php +++ b/scripts/search/reindex_maniphest.php @@ -13,4 +13,3 @@ foreach ($tasks as $task) { echo '.'; } echo "\nDone.\n"; - diff --git a/src/aphront/console/DarkConsoleCore.php b/src/aphront/console/DarkConsoleCore.php index 3501f514ea..3389109ebf 100644 --- a/src/aphront/console/DarkConsoleCore.php +++ b/src/aphront/console/DarkConsoleCore.php @@ -135,4 +135,3 @@ final class DarkConsoleCore { } } - diff --git a/src/aphront/console/plugin/DarkConsoleServicesPlugin.php b/src/aphront/console/plugin/DarkConsoleServicesPlugin.php index 38538f0564..e0f760d271 100644 --- a/src/aphront/console/plugin/DarkConsoleServicesPlugin.php +++ b/src/aphront/console/plugin/DarkConsoleServicesPlugin.php @@ -293,4 +293,3 @@ final class DarkConsoleServicesPlugin extends DarkConsolePlugin { return phutil_implode_html("\n", $results); } } - diff --git a/src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php b/src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php index 3855dd4a89..c65a4a27b8 100644 --- a/src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php +++ b/src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php @@ -76,4 +76,3 @@ final class DarkConsoleErrorLogPluginAPI { } } - diff --git a/src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php b/src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php index 3298fb46c0..afac58ceb4 100644 --- a/src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php +++ b/src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php @@ -28,4 +28,3 @@ final class DarkConsoleEventPluginAPI extends PhabricatorEventListener { } } - diff --git a/src/applications/audit/application/PhabricatorApplicationAudit.php b/src/applications/audit/application/PhabricatorApplicationAudit.php index ce0a120b16..d568a7be3d 100644 --- a/src/applications/audit/application/PhabricatorApplicationAudit.php +++ b/src/applications/audit/application/PhabricatorApplicationAudit.php @@ -78,4 +78,3 @@ final class PhabricatorApplicationAudit extends PhabricatorApplication { } } - diff --git a/src/applications/audit/events/AuditActionMenuEventListener.php b/src/applications/audit/events/AuditActionMenuEventListener.php index 73a5e1a01b..97dfe7af67 100644 --- a/src/applications/audit/events/AuditActionMenuEventListener.php +++ b/src/applications/audit/events/AuditActionMenuEventListener.php @@ -43,4 +43,3 @@ final class AuditActionMenuEventListener extends PhabricatorEventListener { } } - diff --git a/src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php b/src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php index ff6564c95e..bb5b35b986 100644 --- a/src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php +++ b/src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php @@ -140,4 +140,3 @@ final class PhabricatorAuthProviderConfigTransaction } } - diff --git a/src/applications/base/controller/__tests__/PhabricatorApplicationTest.php b/src/applications/base/controller/__tests__/PhabricatorApplicationTest.php index b20faaf553..d5e993bc4f 100644 --- a/src/applications/base/controller/__tests__/PhabricatorApplicationTest.php +++ b/src/applications/base/controller/__tests__/PhabricatorApplicationTest.php @@ -35,4 +35,3 @@ final class PhabricatorApplicationTest extends PhabricatorApplication { } } - diff --git a/src/applications/chatlog/applications/PhabricatorApplicationChatLog.php b/src/applications/chatlog/applications/PhabricatorApplicationChatLog.php index 5c873ac414..707cf46344 100644 --- a/src/applications/chatlog/applications/PhabricatorApplicationChatLog.php +++ b/src/applications/chatlog/applications/PhabricatorApplicationChatLog.php @@ -38,4 +38,3 @@ final class PhabricatorApplicationChatLog extends PhabricatorApplication { } } - diff --git a/src/applications/chatlog/storage/PhabricatorChatLogChannel.php b/src/applications/chatlog/storage/PhabricatorChatLogChannel.php index e9ea837379..5e3f355a7b 100644 --- a/src/applications/chatlog/storage/PhabricatorChatLogChannel.php +++ b/src/applications/chatlog/storage/PhabricatorChatLogChannel.php @@ -37,4 +37,3 @@ final class PhabricatorChatLogChannel } } - diff --git a/src/applications/config/check/PhabricatorSetupCheckImagemagick.php b/src/applications/config/check/PhabricatorSetupCheckImagemagick.php index be041518d2..6d201be53d 100644 --- a/src/applications/config/check/PhabricatorSetupCheckImagemagick.php +++ b/src/applications/config/check/PhabricatorSetupCheckImagemagick.php @@ -21,4 +21,3 @@ final class PhabricatorSetupCheckImagemagick extends PhabricatorSetupCheck { } } } - diff --git a/src/applications/config/storage/PhabricatorConfigTransaction.php b/src/applications/config/storage/PhabricatorConfigTransaction.php index 75c2cc34a3..579b8b3b65 100644 --- a/src/applications/config/storage/PhabricatorConfigTransaction.php +++ b/src/applications/config/storage/PhabricatorConfigTransaction.php @@ -116,4 +116,3 @@ final class PhabricatorConfigTransaction } } - diff --git a/src/applications/conpherence/events/ConpherenceActionMenuEventListener.php b/src/applications/conpherence/events/ConpherenceActionMenuEventListener.php index 1fa71004eb..ca5145bd5b 100644 --- a/src/applications/conpherence/events/ConpherenceActionMenuEventListener.php +++ b/src/applications/conpherence/events/ConpherenceActionMenuEventListener.php @@ -42,4 +42,3 @@ final class ConpherenceActionMenuEventListener } } - diff --git a/src/applications/conpherence/events/ConpherenceHovercardEventListener.php b/src/applications/conpherence/events/ConpherenceHovercardEventListener.php index 6020d6f7e0..616af030ea 100644 --- a/src/applications/conpherence/events/ConpherenceHovercardEventListener.php +++ b/src/applications/conpherence/events/ConpherenceHovercardEventListener.php @@ -39,4 +39,3 @@ final class ConpherenceHovercardEventListener extends PhabricatorEventListener { } } - diff --git a/src/applications/differential/application/PhabricatorApplicationDifferential.php b/src/applications/differential/application/PhabricatorApplicationDifferential.php index 50b0dd3c04..705b2932bb 100644 --- a/src/applications/differential/application/PhabricatorApplicationDifferential.php +++ b/src/applications/differential/application/PhabricatorApplicationDifferential.php @@ -132,4 +132,3 @@ final class PhabricatorApplicationDifferential extends PhabricatorApplication { } } - diff --git a/src/applications/differential/controller/DifferentialRevisionLandController.php b/src/applications/differential/controller/DifferentialRevisionLandController.php index aecc5644b7..774906671c 100644 --- a/src/applications/differential/controller/DifferentialRevisionLandController.php +++ b/src/applications/differential/controller/DifferentialRevisionLandController.php @@ -151,4 +151,3 @@ final class DifferentialRevisionLandController extends DifferentialController { return $lock; } } - diff --git a/src/applications/differential/editor/DifferentialRevisionEditor.php b/src/applications/differential/editor/DifferentialRevisionEditor.php index 0ddbbb1720..10411f2346 100644 --- a/src/applications/differential/editor/DifferentialRevisionEditor.php +++ b/src/applications/differential/editor/DifferentialRevisionEditor.php @@ -994,4 +994,3 @@ final class DifferentialRevisionEditor extends PhabricatorEditor { } } - diff --git a/src/applications/differential/event/DifferentialActionMenuEventListener.php b/src/applications/differential/event/DifferentialActionMenuEventListener.php index a7f42bde4f..6f46c44c04 100644 --- a/src/applications/differential/event/DifferentialActionMenuEventListener.php +++ b/src/applications/differential/event/DifferentialActionMenuEventListener.php @@ -67,4 +67,3 @@ final class DifferentialActionMenuEventListener } } - diff --git a/src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php b/src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php index e95dc3acbd..9d2a6021aa 100644 --- a/src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php +++ b/src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php @@ -93,4 +93,3 @@ final class DifferentialDefaultFieldSelector } } - diff --git a/src/applications/differential/mail/DifferentialExceptionMail.php b/src/applications/differential/mail/DifferentialExceptionMail.php index efe90d0c04..aded833d77 100644 --- a/src/applications/differential/mail/DifferentialExceptionMail.php +++ b/src/applications/differential/mail/DifferentialExceptionMail.php @@ -43,5 +43,3 @@ EOBODY; } } - - diff --git a/src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php b/src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php index 0d247eec4a..dae9fb48ac 100644 --- a/src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php +++ b/src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php @@ -280,4 +280,3 @@ final class DifferentialHunkParserTestCase extends PhabricatorTestCase { } } - diff --git a/src/applications/differential/storage/DifferentialCustomFieldNumericIndex.php b/src/applications/differential/storage/DifferentialCustomFieldNumericIndex.php index a9155467de..3939d4e205 100644 --- a/src/applications/differential/storage/DifferentialCustomFieldNumericIndex.php +++ b/src/applications/differential/storage/DifferentialCustomFieldNumericIndex.php @@ -8,4 +8,3 @@ final class DifferentialCustomFieldNumericIndex } } - diff --git a/src/applications/differential/storage/DifferentialCustomFieldStorage.php b/src/applications/differential/storage/DifferentialCustomFieldStorage.php index 03de1403b9..7e2874e6ac 100644 --- a/src/applications/differential/storage/DifferentialCustomFieldStorage.php +++ b/src/applications/differential/storage/DifferentialCustomFieldStorage.php @@ -8,4 +8,3 @@ final class DifferentialCustomFieldStorage } } - diff --git a/src/applications/differential/storage/DifferentialCustomFieldStringIndex.php b/src/applications/differential/storage/DifferentialCustomFieldStringIndex.php index e2790f5f8f..6c695329d9 100644 --- a/src/applications/differential/storage/DifferentialCustomFieldStringIndex.php +++ b/src/applications/differential/storage/DifferentialCustomFieldStringIndex.php @@ -8,4 +8,3 @@ final class DifferentialCustomFieldStringIndex } } - diff --git a/src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php b/src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php index acfc3a7a88..f56c5c13d1 100644 --- a/src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php +++ b/src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php @@ -140,4 +140,3 @@ final class DifferentialChangesetFileTreeSideNavBuilder { } } - diff --git a/src/applications/diffusion/controller/DiffusionServeController.php b/src/applications/diffusion/controller/DiffusionServeController.php index 403522a056..e8b238053d 100644 --- a/src/applications/diffusion/controller/DiffusionServeController.php +++ b/src/applications/diffusion/controller/DiffusionServeController.php @@ -601,4 +601,3 @@ final class DiffusionServeController extends DiffusionController { } } - diff --git a/src/applications/diffusion/events/DiffusionHovercardEventListener.php b/src/applications/diffusion/events/DiffusionHovercardEventListener.php index ccba5c8260..ebd91d994c 100644 --- a/src/applications/diffusion/events/DiffusionHovercardEventListener.php +++ b/src/applications/diffusion/events/DiffusionHovercardEventListener.php @@ -73,4 +73,3 @@ final class DiffusionHovercardEventListener extends PhabricatorEventListener { } } - diff --git a/src/applications/diffusion/query/pathid/__tests__/DiffusionPathQueryTestCase.php b/src/applications/diffusion/query/pathid/__tests__/DiffusionPathQueryTestCase.php index 00602372a0..b0c6183761 100644 --- a/src/applications/diffusion/query/pathid/__tests__/DiffusionPathQueryTestCase.php +++ b/src/applications/diffusion/query/pathid/__tests__/DiffusionPathQueryTestCase.php @@ -40,4 +40,3 @@ final class DiffusionPathQueryTestCase extends PhabricatorTestCase { } } - diff --git a/src/applications/diviner/application/PhabricatorApplicationDiviner.php b/src/applications/diviner/application/PhabricatorApplicationDiviner.php index a0b140ae77..3ff59349f5 100644 --- a/src/applications/diviner/application/PhabricatorApplicationDiviner.php +++ b/src/applications/diviner/application/PhabricatorApplicationDiviner.php @@ -72,4 +72,3 @@ final class PhabricatorApplicationDiviner extends PhabricatorApplication { } - diff --git a/src/applications/diviner/atomizer/DivinerPHPAtomizer.php b/src/applications/diviner/atomizer/DivinerPHPAtomizer.php index 0c344aee13..18405b9116 100644 --- a/src/applications/diviner/atomizer/DivinerPHPAtomizer.php +++ b/src/applications/diviner/atomizer/DivinerPHPAtomizer.php @@ -316,4 +316,3 @@ final class DivinerPHPAtomizer extends DivinerAtomizer { } } - diff --git a/src/applications/drydock/worker/DrydockAllocatorWorker.php b/src/applications/drydock/worker/DrydockAllocatorWorker.php index 6c2064c587..0e9d99aa97 100644 --- a/src/applications/drydock/worker/DrydockAllocatorWorker.php +++ b/src/applications/drydock/worker/DrydockAllocatorWorker.php @@ -179,5 +179,3 @@ final class DrydockAllocatorWorker extends PhabricatorWorker { } } - - diff --git a/src/applications/feed/application/PhabricatorApplicationFeed.php b/src/applications/feed/application/PhabricatorApplicationFeed.php index 4f2cafc8d4..21c8092e3d 100644 --- a/src/applications/feed/application/PhabricatorApplicationFeed.php +++ b/src/applications/feed/application/PhabricatorApplicationFeed.php @@ -33,4 +33,3 @@ final class PhabricatorApplicationFeed extends PhabricatorApplication { } } - diff --git a/src/applications/flag/application/PhabricatorApplicationFlags.php b/src/applications/flag/application/PhabricatorApplicationFlags.php index 51737fed67..d7d16997f2 100644 --- a/src/applications/flag/application/PhabricatorApplicationFlags.php +++ b/src/applications/flag/application/PhabricatorApplicationFlags.php @@ -58,4 +58,3 @@ final class PhabricatorApplicationFlags extends PhabricatorApplication { } } - diff --git a/src/applications/flag/events/PhabricatorFlagsUIEventListener.php b/src/applications/flag/events/PhabricatorFlagsUIEventListener.php index 04314d311c..df7b1d03d7 100644 --- a/src/applications/flag/events/PhabricatorFlagsUIEventListener.php +++ b/src/applications/flag/events/PhabricatorFlagsUIEventListener.php @@ -59,4 +59,3 @@ final class PhabricatorFlagsUIEventListener extends PhabricatorEventListener { } } - diff --git a/src/applications/herald/adapter/HeraldAdapter.php b/src/applications/herald/adapter/HeraldAdapter.php index 136a0b1cb0..4f5343d445 100644 --- a/src/applications/herald/adapter/HeraldAdapter.php +++ b/src/applications/herald/adapter/HeraldAdapter.php @@ -1077,4 +1077,3 @@ abstract class HeraldAdapter { } } - diff --git a/src/applications/herald/engine/HeraldEffect.php b/src/applications/herald/engine/HeraldEffect.php index 1d4955c7ed..9863ae3f39 100644 --- a/src/applications/herald/engine/HeraldEffect.php +++ b/src/applications/herald/engine/HeraldEffect.php @@ -76,4 +76,3 @@ final class HeraldEffect { } } - diff --git a/src/applications/herald/storage/HeraldRuleTransactionComment.php b/src/applications/herald/storage/HeraldRuleTransactionComment.php index 5db8952403..56022ef863 100644 --- a/src/applications/herald/storage/HeraldRuleTransactionComment.php +++ b/src/applications/herald/storage/HeraldRuleTransactionComment.php @@ -8,4 +8,3 @@ final class HeraldRuleTransactionComment } } - diff --git a/src/applications/herald/storage/__tests__/HeraldTranscriptTestCase.php b/src/applications/herald/storage/__tests__/HeraldTranscriptTestCase.php index 799c8b9e34..1dcba15d01 100644 --- a/src/applications/herald/storage/__tests__/HeraldTranscriptTestCase.php +++ b/src/applications/herald/storage/__tests__/HeraldTranscriptTestCase.php @@ -44,4 +44,4 @@ final class HeraldTranscriptTestCase extends PhabricatorTestCase { implode('!', $truncated_fields['ma'])); } -} \ No newline at end of file +} diff --git a/src/applications/macro/storage/PhabricatorFileImageMacro.php b/src/applications/macro/storage/PhabricatorFileImageMacro.php index b8cdbf6a8f..578e0c3513 100644 --- a/src/applications/macro/storage/PhabricatorFileImageMacro.php +++ b/src/applications/macro/storage/PhabricatorFileImageMacro.php @@ -110,4 +110,3 @@ final class PhabricatorFileImageMacro extends PhabricatorFileDAO } } - diff --git a/src/applications/macro/storage/PhabricatorMacroTransaction.php b/src/applications/macro/storage/PhabricatorMacroTransaction.php index bcac44ae19..c29cb92265 100644 --- a/src/applications/macro/storage/PhabricatorMacroTransaction.php +++ b/src/applications/macro/storage/PhabricatorMacroTransaction.php @@ -301,4 +301,3 @@ final class PhabricatorMacroTransaction } - diff --git a/src/applications/macro/storage/PhabricatorMacroTransactionComment.php b/src/applications/macro/storage/PhabricatorMacroTransactionComment.php index 565f5040ee..1963a554a0 100644 --- a/src/applications/macro/storage/PhabricatorMacroTransactionComment.php +++ b/src/applications/macro/storage/PhabricatorMacroTransactionComment.php @@ -8,4 +8,3 @@ final class PhabricatorMacroTransactionComment } } - diff --git a/src/applications/maniphest/application/PhabricatorApplicationManiphest.php b/src/applications/maniphest/application/PhabricatorApplicationManiphest.php index c0b3eaad66..4cf58c76c3 100644 --- a/src/applications/maniphest/application/PhabricatorApplicationManiphest.php +++ b/src/applications/maniphest/application/PhabricatorApplicationManiphest.php @@ -124,4 +124,3 @@ final class PhabricatorApplicationManiphest extends PhabricatorApplication { } } - diff --git a/src/applications/maniphest/storage/ManiphestCustomFieldNumericIndex.php b/src/applications/maniphest/storage/ManiphestCustomFieldNumericIndex.php index 640552c63c..79d7a3a8e6 100644 --- a/src/applications/maniphest/storage/ManiphestCustomFieldNumericIndex.php +++ b/src/applications/maniphest/storage/ManiphestCustomFieldNumericIndex.php @@ -8,4 +8,3 @@ final class ManiphestCustomFieldNumericIndex } } - diff --git a/src/applications/maniphest/storage/ManiphestCustomFieldStorage.php b/src/applications/maniphest/storage/ManiphestCustomFieldStorage.php index f3b2596d11..d40ac89dc0 100644 --- a/src/applications/maniphest/storage/ManiphestCustomFieldStorage.php +++ b/src/applications/maniphest/storage/ManiphestCustomFieldStorage.php @@ -8,4 +8,3 @@ final class ManiphestCustomFieldStorage } } - diff --git a/src/applications/maniphest/storage/ManiphestCustomFieldStringIndex.php b/src/applications/maniphest/storage/ManiphestCustomFieldStringIndex.php index 9cb678ccec..5126a7bf50 100644 --- a/src/applications/maniphest/storage/ManiphestCustomFieldStringIndex.php +++ b/src/applications/maniphest/storage/ManiphestCustomFieldStringIndex.php @@ -8,4 +8,3 @@ final class ManiphestCustomFieldStringIndex } } - diff --git a/src/applications/maniphest/storage/ManiphestTransaction.php b/src/applications/maniphest/storage/ManiphestTransaction.php index 09a3f936e5..a66b8500fe 100644 --- a/src/applications/maniphest/storage/ManiphestTransaction.php +++ b/src/applications/maniphest/storage/ManiphestTransaction.php @@ -667,4 +667,3 @@ final class ManiphestTransaction } - diff --git a/src/applications/meta/application/PhabricatorApplicationApplications.php b/src/applications/meta/application/PhabricatorApplicationApplications.php index 765e5e0b0d..66c611406c 100644 --- a/src/applications/meta/application/PhabricatorApplicationApplications.php +++ b/src/applications/meta/application/PhabricatorApplicationApplications.php @@ -43,4 +43,3 @@ final class PhabricatorApplicationApplications extends PhabricatorApplication { } } - diff --git a/src/applications/meta/controller/PhabricatorApplicationUninstallController.php b/src/applications/meta/controller/PhabricatorApplicationUninstallController.php index 7c480ad81e..8445526a04 100644 --- a/src/applications/meta/controller/PhabricatorApplicationUninstallController.php +++ b/src/applications/meta/controller/PhabricatorApplicationUninstallController.php @@ -90,4 +90,3 @@ final class PhabricatorApplicationUninstallController } } - diff --git a/src/applications/metamta/adapter/PhabricatorMailImplementationSendGridAdapter.php b/src/applications/metamta/adapter/PhabricatorMailImplementationSendGridAdapter.php index 7e41491ace..44c8acd2f5 100644 --- a/src/applications/metamta/adapter/PhabricatorMailImplementationSendGridAdapter.php +++ b/src/applications/metamta/adapter/PhabricatorMailImplementationSendGridAdapter.php @@ -155,4 +155,3 @@ final class PhabricatorMailImplementationSendGridAdapter } } - diff --git a/src/applications/nuance/application/PhabricatorApplicationNuance.php b/src/applications/nuance/application/PhabricatorApplicationNuance.php index b2d123ee2e..ac962b1982 100644 --- a/src/applications/nuance/application/PhabricatorApplicationNuance.php +++ b/src/applications/nuance/application/PhabricatorApplicationNuance.php @@ -70,4 +70,3 @@ final class PhabricatorApplicationNuance extends PhabricatorApplication { } } - diff --git a/src/applications/nuance/query/NuanceItemQuery.php b/src/applications/nuance/query/NuanceItemQuery.php index 18a96b9f79..d37c2176f8 100644 --- a/src/applications/nuance/query/NuanceItemQuery.php +++ b/src/applications/nuance/query/NuanceItemQuery.php @@ -68,4 +68,3 @@ final class NuanceItemQuery } } - diff --git a/src/applications/nuance/query/NuanceQuery.php b/src/applications/nuance/query/NuanceQuery.php index c286cdbd3b..617cada36d 100644 --- a/src/applications/nuance/query/NuanceQuery.php +++ b/src/applications/nuance/query/NuanceQuery.php @@ -8,4 +8,3 @@ abstract class NuanceQuery } } - diff --git a/src/applications/nuance/query/NuanceQueueQuery.php b/src/applications/nuance/query/NuanceQueueQuery.php index ce5ce30a5c..942753dbf4 100644 --- a/src/applications/nuance/query/NuanceQueueQuery.php +++ b/src/applications/nuance/query/NuanceQueueQuery.php @@ -54,4 +54,3 @@ final class NuanceQueueQuery } } - diff --git a/src/applications/nuance/query/NuanceRequestorQuery.php b/src/applications/nuance/query/NuanceRequestorQuery.php index c9e8fc5ea4..a1df9b98f3 100644 --- a/src/applications/nuance/query/NuanceRequestorQuery.php +++ b/src/applications/nuance/query/NuanceRequestorQuery.php @@ -54,4 +54,3 @@ final class NuanceRequestorQuery } } - diff --git a/src/applications/nuance/source/NuanceSourceDefinition.php b/src/applications/nuance/source/NuanceSourceDefinition.php index 86eea6ddeb..e643daa0b1 100644 --- a/src/applications/nuance/source/NuanceSourceDefinition.php +++ b/src/applications/nuance/source/NuanceSourceDefinition.php @@ -260,4 +260,3 @@ abstract class NuanceSourceDefinition extends Phobject { abstract public function renderListView(); } - diff --git a/src/applications/owners/mail/OwnersPackageReplyHandler.php b/src/applications/owners/mail/OwnersPackageReplyHandler.php index 31bdf4cb00..e530ee41ed 100644 --- a/src/applications/owners/mail/OwnersPackageReplyHandler.php +++ b/src/applications/owners/mail/OwnersPackageReplyHandler.php @@ -28,5 +28,3 @@ final class OwnersPackageReplyHandler extends PhabricatorMailReplyHandler { return; } } - - diff --git a/src/applications/people/storage/PhabricatorUserConfiguredCustomFieldStorage.php b/src/applications/people/storage/PhabricatorUserConfiguredCustomFieldStorage.php index fe5f21b6bd..432938d3a4 100644 --- a/src/applications/people/storage/PhabricatorUserConfiguredCustomFieldStorage.php +++ b/src/applications/people/storage/PhabricatorUserConfiguredCustomFieldStorage.php @@ -8,4 +8,3 @@ final class PhabricatorUserConfiguredCustomFieldStorage } } - diff --git a/src/applications/people/storage/PhabricatorUserCustomFieldNumericIndex.php b/src/applications/people/storage/PhabricatorUserCustomFieldNumericIndex.php index 0f36bd8e57..eaf9334d02 100644 --- a/src/applications/people/storage/PhabricatorUserCustomFieldNumericIndex.php +++ b/src/applications/people/storage/PhabricatorUserCustomFieldNumericIndex.php @@ -8,4 +8,3 @@ final class PhabricatorUserCustomFieldNumericIndex } } - diff --git a/src/applications/people/storage/PhabricatorUserCustomFieldStringIndex.php b/src/applications/people/storage/PhabricatorUserCustomFieldStringIndex.php index 399385c8cc..25e4d64de6 100644 --- a/src/applications/people/storage/PhabricatorUserCustomFieldStringIndex.php +++ b/src/applications/people/storage/PhabricatorUserCustomFieldStringIndex.php @@ -8,4 +8,3 @@ final class PhabricatorUserCustomFieldStringIndex } } - diff --git a/src/applications/people/storage/PhabricatorUserTransaction.php b/src/applications/people/storage/PhabricatorUserTransaction.php index eb7e29929e..86551be428 100644 --- a/src/applications/people/storage/PhabricatorUserTransaction.php +++ b/src/applications/people/storage/PhabricatorUserTransaction.php @@ -16,4 +16,3 @@ final class PhabricatorUserTransaction } } - diff --git a/src/applications/pholio/event/PholioActionMenuEventListener.php b/src/applications/pholio/event/PholioActionMenuEventListener.php index 6e55b065c1..15954520b6 100644 --- a/src/applications/pholio/event/PholioActionMenuEventListener.php +++ b/src/applications/pholio/event/PholioActionMenuEventListener.php @@ -49,4 +49,3 @@ final class PholioActionMenuEventListener } } - diff --git a/src/applications/phragment/application/PhabricatorApplicationPhragment.php b/src/applications/phragment/application/PhabricatorApplicationPhragment.php index aaa8f3c4bc..d82e2dba5b 100644 --- a/src/applications/phragment/application/PhabricatorApplicationPhragment.php +++ b/src/applications/phragment/application/PhabricatorApplicationPhragment.php @@ -65,4 +65,3 @@ final class PhabricatorApplicationPhragment extends PhabricatorApplication { } } - diff --git a/src/applications/phrequent/application/PhabricatorApplicationPhrequent.php b/src/applications/phrequent/application/PhabricatorApplicationPhrequent.php index bf406cd703..35f2dd9fd9 100644 --- a/src/applications/phrequent/application/PhabricatorApplicationPhrequent.php +++ b/src/applications/phrequent/application/PhabricatorApplicationPhrequent.php @@ -59,4 +59,3 @@ final class PhabricatorApplicationPhrequent extends PhabricatorApplication { } } - diff --git a/src/applications/phrequent/query/PhrequentSearchEngine.php b/src/applications/phrequent/query/PhrequentSearchEngine.php index 5e3d152f3a..48fd907b51 100644 --- a/src/applications/phrequent/query/PhrequentSearchEngine.php +++ b/src/applications/phrequent/query/PhrequentSearchEngine.php @@ -111,4 +111,3 @@ final class PhrequentSearchEngine } } - diff --git a/src/applications/phriction/application/PhabricatorApplicationPhriction.php b/src/applications/phriction/application/PhabricatorApplicationPhriction.php index d0573e872b..5ede3d5229 100644 --- a/src/applications/phriction/application/PhabricatorApplicationPhriction.php +++ b/src/applications/phriction/application/PhabricatorApplicationPhriction.php @@ -67,4 +67,3 @@ final class PhabricatorApplicationPhriction extends PhabricatorApplication { } } - diff --git a/src/applications/policy/application/PhabricatorApplicationPolicy.php b/src/applications/policy/application/PhabricatorApplicationPolicy.php index 6ecf69c9c9..7d0ff9df2a 100644 --- a/src/applications/policy/application/PhabricatorApplicationPolicy.php +++ b/src/applications/policy/application/PhabricatorApplicationPolicy.php @@ -21,4 +21,3 @@ final class PhabricatorApplicationPolicy extends PhabricatorApplication { } } - diff --git a/src/applications/policy/capability/PhabricatorPolicyCapability.php b/src/applications/policy/capability/PhabricatorPolicyCapability.php index a34e0f76bd..1cff309a64 100644 --- a/src/applications/policy/capability/PhabricatorPolicyCapability.php +++ b/src/applications/policy/capability/PhabricatorPolicyCapability.php @@ -68,5 +68,3 @@ abstract class PhabricatorPolicyCapability extends Phobject { } } - - diff --git a/src/applications/policy/query/PhabricatorPolicyQuery.php b/src/applications/policy/query/PhabricatorPolicyQuery.php index 37c38a5d6b..ac2c600305 100644 --- a/src/applications/policy/query/PhabricatorPolicyQuery.php +++ b/src/applications/policy/query/PhabricatorPolicyQuery.php @@ -234,4 +234,3 @@ final class PhabricatorPolicyQuery } } - diff --git a/src/applications/ponder/remarkup/PonderRemarkupRule.php b/src/applications/ponder/remarkup/PonderRemarkupRule.php index 9102600cfc..840c98fc0a 100644 --- a/src/applications/ponder/remarkup/PonderRemarkupRule.php +++ b/src/applications/ponder/remarkup/PonderRemarkupRule.php @@ -28,4 +28,3 @@ final class PonderRemarkupRule } } - diff --git a/src/applications/ponder/storage/PonderAnswerTransaction.php b/src/applications/ponder/storage/PonderAnswerTransaction.php index f12303b3a7..24a8a86ba1 100644 --- a/src/applications/ponder/storage/PonderAnswerTransaction.php +++ b/src/applications/ponder/storage/PonderAnswerTransaction.php @@ -102,4 +102,3 @@ final class PonderAnswerTransaction } } - diff --git a/src/applications/ponder/storage/PonderAnswerTransactionComment.php b/src/applications/ponder/storage/PonderAnswerTransactionComment.php index 034798a20b..2dc601a3d6 100644 --- a/src/applications/ponder/storage/PonderAnswerTransactionComment.php +++ b/src/applications/ponder/storage/PonderAnswerTransactionComment.php @@ -8,4 +8,3 @@ final class PonderAnswerTransactionComment } } - diff --git a/src/applications/ponder/storage/PonderComment.php b/src/applications/ponder/storage/PonderComment.php index b1abf2fa9d..a877672bea 100644 --- a/src/applications/ponder/storage/PonderComment.php +++ b/src/applications/ponder/storage/PonderComment.php @@ -38,4 +38,3 @@ final class PonderComment extends PonderDAO return self::MARKUP_FIELD_CONTENT; } } - diff --git a/src/applications/ponder/storage/PonderQuestionTransactionComment.php b/src/applications/ponder/storage/PonderQuestionTransactionComment.php index c5e0c0f0e3..46e20ff1ed 100644 --- a/src/applications/ponder/storage/PonderQuestionTransactionComment.php +++ b/src/applications/ponder/storage/PonderQuestionTransactionComment.php @@ -8,4 +8,3 @@ final class PonderQuestionTransactionComment } } - diff --git a/src/applications/project/storage/PhabricatorProjectCustomFieldNumericIndex.php b/src/applications/project/storage/PhabricatorProjectCustomFieldNumericIndex.php index 095155a0b4..8ddec8396a 100644 --- a/src/applications/project/storage/PhabricatorProjectCustomFieldNumericIndex.php +++ b/src/applications/project/storage/PhabricatorProjectCustomFieldNumericIndex.php @@ -8,4 +8,3 @@ final class PhabricatorProjectCustomFieldNumericIndex } } - diff --git a/src/applications/project/storage/PhabricatorProjectCustomFieldStorage.php b/src/applications/project/storage/PhabricatorProjectCustomFieldStorage.php index a65483e428..4bfe884813 100644 --- a/src/applications/project/storage/PhabricatorProjectCustomFieldStorage.php +++ b/src/applications/project/storage/PhabricatorProjectCustomFieldStorage.php @@ -8,4 +8,3 @@ final class PhabricatorProjectCustomFieldStorage } } - diff --git a/src/applications/project/storage/PhabricatorProjectCustomFieldStringIndex.php b/src/applications/project/storage/PhabricatorProjectCustomFieldStringIndex.php index f2441e695f..80280ffae6 100644 --- a/src/applications/project/storage/PhabricatorProjectCustomFieldStringIndex.php +++ b/src/applications/project/storage/PhabricatorProjectCustomFieldStringIndex.php @@ -8,4 +8,3 @@ final class PhabricatorProjectCustomFieldStringIndex } } - diff --git a/src/applications/releeph/storage/ReleephBranchTransaction.php b/src/applications/releeph/storage/ReleephBranchTransaction.php index d9805aff88..1b453c2583 100644 --- a/src/applications/releeph/storage/ReleephBranchTransaction.php +++ b/src/applications/releeph/storage/ReleephBranchTransaction.php @@ -12,4 +12,3 @@ final class ReleephBranchTransaction } } - diff --git a/src/applications/releeph/storage/ReleephProjectTransaction.php b/src/applications/releeph/storage/ReleephProjectTransaction.php index fc9fd0c5c6..800d7e3569 100644 --- a/src/applications/releeph/storage/ReleephProjectTransaction.php +++ b/src/applications/releeph/storage/ReleephProjectTransaction.php @@ -12,4 +12,3 @@ final class ReleephProjectTransaction } } - diff --git a/src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php b/src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php index 7147b37a66..b76b49fc9e 100644 --- a/src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php +++ b/src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php @@ -80,4 +80,3 @@ final class PhabricatorRepositoryCommitSearchIndexer return $doc; } } - diff --git a/src/applications/repository/storage/PhabricatorRepositoryTransaction.php b/src/applications/repository/storage/PhabricatorRepositoryTransaction.php index 446dcb19e6..1cec405290 100644 --- a/src/applications/repository/storage/PhabricatorRepositoryTransaction.php +++ b/src/applications/repository/storage/PhabricatorRepositoryTransaction.php @@ -388,4 +388,3 @@ final class PhabricatorRepositoryTransaction } } - diff --git a/src/applications/search/controller/PhabricatorSearchAttachController.php b/src/applications/search/controller/PhabricatorSearchAttachController.php index b0b7bae84c..a2ec3b2fb1 100644 --- a/src/applications/search/controller/PhabricatorSearchAttachController.php +++ b/src/applications/search/controller/PhabricatorSearchAttachController.php @@ -26,7 +26,7 @@ final class PhabricatorSearchAttachController $request = $this->getRequest(); $user = $request->getUser(); - $handle = id(New PhabricatorHandleQuery()) + $handle = id(new PhabricatorHandleQuery()) ->setViewer($user) ->withPHIDs(array($this->phid)) ->executeOne(); diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelConpherencePreferences.php b/src/applications/settings/panel/PhabricatorSettingsPanelConpherencePreferences.php index 95c19d9d5e..2085a3eb5c 100644 --- a/src/applications/settings/panel/PhabricatorSettingsPanelConpherencePreferences.php +++ b/src/applications/settings/panel/PhabricatorSettingsPanelConpherencePreferences.php @@ -66,4 +66,3 @@ final class PhabricatorSettingsPanelConpherencePreferences ); } } - diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelDeveloperPreferences.php b/src/applications/settings/panel/PhabricatorSettingsPanelDeveloperPreferences.php index 3c23cc05a8..e5ba13fdbe 100644 --- a/src/applications/settings/panel/PhabricatorSettingsPanelDeveloperPreferences.php +++ b/src/applications/settings/panel/PhabricatorSettingsPanelDeveloperPreferences.php @@ -95,4 +95,3 @@ final class PhabricatorSettingsPanelDeveloperPreferences ); } } - diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelDiffPreferences.php b/src/applications/settings/panel/PhabricatorSettingsPanelDiffPreferences.php index 26115e3e77..16ba31bd3d 100644 --- a/src/applications/settings/panel/PhabricatorSettingsPanelDiffPreferences.php +++ b/src/applications/settings/panel/PhabricatorSettingsPanelDiffPreferences.php @@ -68,4 +68,3 @@ final class PhabricatorSettingsPanelDiffPreferences ); } } - diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php b/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php index c97f9d6046..d03a73b423 100644 --- a/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php +++ b/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php @@ -147,4 +147,3 @@ EXAMPLE; ); } } - diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelHomePreferences.php b/src/applications/settings/panel/PhabricatorSettingsPanelHomePreferences.php index 82a7b13a55..276463861f 100644 --- a/src/applications/settings/panel/PhabricatorSettingsPanelHomePreferences.php +++ b/src/applications/settings/panel/PhabricatorSettingsPanelHomePreferences.php @@ -216,4 +216,3 @@ final class PhabricatorSettingsPanelHomePreferences return array($header, $error_view, $form); } } - diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php b/src/applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php index 4330a6dc93..0c77448895 100644 --- a/src/applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php +++ b/src/applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php @@ -60,4 +60,3 @@ final class PhabricatorSettingsPanelSearchPreferences ); } } - diff --git a/src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php b/src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php index 9370ea361a..9769767bbb 100644 --- a/src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php +++ b/src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php @@ -124,4 +124,3 @@ final class PhabricatorSlowvoteTransaction } - diff --git a/src/applications/slowvote/storage/PhabricatorSlowvoteTransactionComment.php b/src/applications/slowvote/storage/PhabricatorSlowvoteTransactionComment.php index 876ee015de..0dc033e2fd 100644 --- a/src/applications/slowvote/storage/PhabricatorSlowvoteTransactionComment.php +++ b/src/applications/slowvote/storage/PhabricatorSlowvoteTransactionComment.php @@ -8,4 +8,3 @@ final class PhabricatorSlowvoteTransactionComment } } - diff --git a/src/applications/subscriptions/application/PhabricatorApplicationSubscriptions.php b/src/applications/subscriptions/application/PhabricatorApplicationSubscriptions.php index ad4b4eea15..e569be0d8f 100644 --- a/src/applications/subscriptions/application/PhabricatorApplicationSubscriptions.php +++ b/src/applications/subscriptions/application/PhabricatorApplicationSubscriptions.php @@ -26,4 +26,3 @@ final class PhabricatorApplicationSubscriptions extends PhabricatorApplication { } } - diff --git a/src/applications/transactions/application/PhabricatorApplicationTransactions.php b/src/applications/transactions/application/PhabricatorApplicationTransactions.php index 96d76ca0e0..e91cb3dc80 100644 --- a/src/applications/transactions/application/PhabricatorApplicationTransactions.php +++ b/src/applications/transactions/application/PhabricatorApplicationTransactions.php @@ -24,4 +24,3 @@ final class PhabricatorApplicationTransactions extends PhabricatorApplication { } } - diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php index 3c35d017b3..6ff13c78a6 100644 --- a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php +++ b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php @@ -234,4 +234,3 @@ class PhabricatorApplicationTransactionCommentView extends AphrontView { } } - diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionTextDiffDetailView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionTextDiffDetailView.php index 83f016cb2b..55fe586bc6 100644 --- a/src/applications/transactions/view/PhabricatorApplicationTransactionTextDiffDetailView.php +++ b/src/applications/transactions/view/PhabricatorApplicationTransactionTextDiffDetailView.php @@ -54,4 +54,3 @@ final class PhabricatorApplicationTransactionTextDiffDetailView } } - diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php index 38592a2978..b02c6119ad 100644 --- a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php +++ b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php @@ -349,4 +349,3 @@ class PhabricatorApplicationTransactionView extends AphrontView { } } - diff --git a/src/applications/typeahead/storage/PhabricatorTypeaheadResult.php b/src/applications/typeahead/storage/PhabricatorTypeaheadResult.php index 581d26d566..9ec4955be1 100644 --- a/src/applications/typeahead/storage/PhabricatorTypeaheadResult.php +++ b/src/applications/typeahead/storage/PhabricatorTypeaheadResult.php @@ -83,4 +83,3 @@ final class PhabricatorTypeaheadResult { } } - diff --git a/src/docs/user/configuration/troubleshooting_https.diviner b/src/docs/user/configuration/troubleshooting_https.diviner index 6950377219..19e335e615 100644 --- a/src/docs/user/configuration/troubleshooting_https.diviner +++ b/src/docs/user/configuration/troubleshooting_https.diviner @@ -10,7 +10,7 @@ particularly if you're receiving a "There was an error negotiating the SSL connection." error, this document may be able to help you diagnose and resolve the problem. -Connection negotation can fail for several reasons. The major ones are: +Connection negotiation can fail for several reasons. The major ones are: - You have not added the the Certificate Authority as a trusted authority (this is the most common problem, and usually the issue for self-signed diff --git a/src/docs/user/contributing/php_coding_standards.diviner b/src/docs/user/contributing/php_coding_standards.diviner index 72a849fce5..cb3406e15b 100644 --- a/src/docs/user/contributing/php_coding_standards.diviner +++ b/src/docs/user/contributing/php_coding_standards.diviner @@ -167,4 +167,3 @@ diffs which add elements to the array affect only one line. return $this->favoriteFood; } } - diff --git a/src/docs/user/developer/adding_new_css_and_js.diviner b/src/docs/user/developer/adding_new_css_and_js.diviner index 2443f9d5d6..83a80aca40 100644 --- a/src/docs/user/developer/adding_new_css_and_js.diviner +++ b/src/docs/user/developer/adding_new_css_and_js.diviner @@ -83,4 +83,3 @@ as possible, i.e. **not** at the top of your Controller. The idea is that you should @{function:require_celerity_resource} a resource only if you are actually using it on a specific rendering of the page, not just because some views of the page might require it. - diff --git a/src/docs/user/developer/unit_tests.diviner b/src/docs/user/developer/unit_tests.diviner index 55a67403f8..6aeaaab225 100644 --- a/src/docs/user/developer/unit_tests.diviner +++ b/src/docs/user/developer/unit_tests.diviner @@ -84,4 +84,3 @@ in a number of ways. From best to worst: ##self::PHABRICATOR_TESTCONFIG_ISOLATE_LISK => false## in the configuration dictionary you return. This will disable isolation entirely. STRONGLY NOT RECOMMENDED. - diff --git a/src/docs/user/developer/using_oauthserver.diviner b/src/docs/user/developer/using_oauthserver.diviner index 9a1a989e66..9587d23410 100644 --- a/src/docs/user/developer/using_oauthserver.diviner +++ b/src/docs/user/developer/using_oauthserver.diviner @@ -5,32 +5,32 @@ How to use the Phabricator OAuth Server. = Overview = -Phabricator includes an OAuth Server which supports the -##Authorization Code Grant## flow as described in the OAuth 2.0 +Phabricator includes an OAuth Server which supports the +##Authorization Code Grant## flow as described in the OAuth 2.0 specification: http://tools.ietf.org/html/draft-ietf-oauth-v2-23 -This functionality can allow clients to integrate with a given -Phabricator instance in a secure way with granular data access. -For example, Phabricator can be used as a central identity store for any +This functionality can allow clients to integrate with a given +Phabricator instance in a secure way with granular data access. +For example, Phabricator can be used as a central identity store for any clients that implement OAuth 2.0. = Vocabulary = -- **Access token** - a token which allows a client to ask for data on -behalf of a resource owner. A given client will only be able to access +- **Access token** - a token which allows a client to ask for data on +behalf of a resource owner. A given client will only be able to access data included in the scope(s) the resource owner authorized that client for. -- **Authorization code** - a short-lived code which allows an authenticated +- **Authorization code** - a short-lived code which allows an authenticated client to ask for an access token on behalf of some resource owner. -- **Client** - this is the application or system asking for data from the +- **Client** - this is the application or system asking for data from the OAuth Server on behalf of the resource owner. -- **Resource owner** - this is the user the client and OAuth Server are +- **Resource owner** - this is the user the client and OAuth Server are concerned with on a given request. -- **Scope** - this defines a specific piece of granular data a client can -or can not access on behalf of a user. For example, if authorized for the -"whoami" scope on behalf of a given resource owner, the client can get the -results of Conduit.whoami for that resource owner when authenticated with +- **Scope** - this defines a specific piece of granular data a client can +or can not access on behalf of a user. For example, if authorized for the +"whoami" scope on behalf of a given resource owner, the client can get the +results of Conduit.whoami for that resource owner when authenticated with a valid access token. = Setup - Creating a Client = @@ -41,80 +41,80 @@ a valid access token. = Obtaining an Authorization Code = -POST or GET https://phabricator.example.com/oauthserver/auth/ with the +POST or GET https://phabricator.example.com/oauthserver/auth/ with the following parameters: - Required - **client_id** - the id of the newly registered client. -- Required - **response_type** - the desired type of authorization code +- Required - **response_type** - the desired type of authorization code response. Only code is supported at this time. -- Optional - **redirect_uri** - override the redirect_uri the client -registered. This redirect_uri must have the same fully-qualified domain -and have at least the same query parameters as the redirect_uri the client +- Optional - **redirect_uri** - override the redirect_uri the client +registered. This redirect_uri must have the same fully-qualified domain +and have at least the same query parameters as the redirect_uri the client registered, as well as have no fragments. - Optional - **scope** - specify what scope(s) the client needs access to in a space-delimited list. -- Optional - **state** - an opaque value the client can send to the server -for programmatic excellence. Some clients use this value to implement XSRF +- Optional - **state** - an opaque value the client can send to the server +for programmatic excellence. Some clients use this value to implement XSRF protection or for debugging purposes. -If done correctly and the resource owner has not yet authorized the client -for the desired scope, then the resource owner will be presented with an -interface to authorize the client for the desired scope. The OAuth Server -will redirect to the pertinent redirect_uri with an authorization code or +If done correctly and the resource owner has not yet authorized the client +for the desired scope, then the resource owner will be presented with an +interface to authorize the client for the desired scope. The OAuth Server +will redirect to the pertinent redirect_uri with an authorization code or an error indicating the resource owner did not authorize the client, depending. -If done correctly and the resource owner has already authorized the client for -the desired scope, then the OAuth Server will redirect to the pertinent -redirect_uri with a valid authorization code. +If done correctly and the resource owner has already authorized the client for +the desired scope, then the OAuth Server will redirect to the pertinent +redirect_uri with a valid authorization code. -If there is an error, the OAuth Server will return a descriptive error -message. This error will be presented to the resource owner on the -Phabricator domain if there is reason to believe there is something fishy -with the client. For example, if there is an issue with the redirect_uri. -Otherwise, the OAuth Server will redirect to the pertinent redirect_uri +If there is an error, the OAuth Server will return a descriptive error +message. This error will be presented to the resource owner on the +Phabricator domain if there is reason to believe there is something fishy +with the client. For example, if there is an issue with the redirect_uri. +Otherwise, the OAuth Server will redirect to the pertinent redirect_uri and include the pertinent error information. = Obtaining an Access Token = -POST or GET https://phabricator.example.com/oauthserver/token/ +POST or GET https://phabricator.example.com/oauthserver/token/ with the following parameters: - Required - **client_id** - the id of the client -- Required - **client_secret** - the secret of the client. +- Required - **client_secret** - the secret of the client. This is used to authenticate the client. - Required - **code** - the authorization code obtained earlier. -- Required - **grant_type** - the desired type of access grant. +- Required - **grant_type** - the desired type of access grant. Only token is supported at this time. -- Optional - **redirect_uri** - should be the exact same redirect_uri as -the redirect_uri specified to obtain the authorization code. If no -redirect_uri was specified to obtain the authorization code then this +- Optional - **redirect_uri** - should be the exact same redirect_uri as +the redirect_uri specified to obtain the authorization code. If no +redirect_uri was specified to obtain the authorization code then this should not be specified. -If done correctly, the OAuth Server will redirect to the pertinent +If done correctly, the OAuth Server will redirect to the pertinent redirect_uri with an access token. -If there is an error, the OAuth Server will return a descriptive error +If there is an error, the OAuth Server will return a descriptive error message. = Using an Access Token = -Simply include a query param with the key of "access_token" and the value +Simply include a query param with the key of "access_token" and the value as the earlier obtained access token. For example: https://phabricator.example.com/api/user.whoami?access_token=ykc7ly7vtibj334oga4fnfbuvnwz4ocp If the token has expired or is otherwise invalid, the client will receive -an error indicating as such. In these cases, the client should re-initiate +an error indicating as such. In these cases, the client should re-initiate the entire ##Authorization Code Grant## flow. -NOTE: See "Scopes" section below for more information on what data is +NOTE: See "Scopes" section below for more information on what data is currently exposed through the OAuth Server. = Scopes = There are only two scopes supported at this time. -- **offline_access** - allows an access token to work indefinitely without +- **offline_access** - allows an access token to work indefinitely without expiring. -- **whoami** - allows the client to access the results of Conduit.whoami on +- **whoami** - allows the client to access the results of Conduit.whoami on behalf of the resource owner. diff --git a/src/docs/user/flavortext/javascript_object_array.diviner b/src/docs/user/flavortext/javascript_object_array.diviner index 19cca9973c..fde8b33ecf 100644 --- a/src/docs/user/flavortext/javascript_object_array.diviner +++ b/src/docs/user/flavortext/javascript_object_array.diviner @@ -150,4 +150,3 @@ If you need an ordered map, you need to have a map for key-value associations and a list for key order. Don't try to build an ordered map using one Object or one Array. This generally applies for other complicated datatypes, as well; you need to build them out of more than one primitive. - diff --git a/src/docs/user/flavortext/javascript_pitfalls.diviner b/src/docs/user/flavortext/javascript_pitfalls.diviner index bee2b94675..a4815e8f3a 100644 --- a/src/docs/user/flavortext/javascript_pitfalls.diviner +++ b/src/docs/user/flavortext/javascript_pitfalls.diviner @@ -85,4 +85,3 @@ worst strictly wrong. **Never use** ##new Number()##, ##new String()## or ##new Boolean()## unless your Javascript is God Tier and you are absolutely sure you know what you are doing. - diff --git a/src/docs/user/flavortext/things_you_should_do_now.diviner b/src/docs/user/flavortext/things_you_should_do_now.diviner index 2ccc53b893..d446c741c2 100644 --- a/src/docs/user/flavortext/things_you_should_do_now.diviner +++ b/src/docs/user/flavortext/things_you_should_do_now.diviner @@ -136,5 +136,3 @@ Hopefully, whatever language you're writing in has good query libraries that can handle escaping for you. If so, use them. If you're using PHP and don't have a solution in place yet, the Phabricator implementation of qsprintf() is similar to Facebook's system and was successful there. - - diff --git a/src/docs/user/userguide/arcanist_lint.diviner b/src/docs/user/userguide/arcanist_lint.diviner index 67f5513e38..4be3c402df 100644 --- a/src/docs/user/userguide/arcanist_lint.diviner +++ b/src/docs/user/userguide/arcanist_lint.diviner @@ -195,4 +195,3 @@ Continue by: @{article:Arcanist User Guide: Customizing Existing Linters}; or - learning how to add new linters and lint engines with @{article:Arcanist User Guide: Customizing Lint, Unit Tests and Workflows}. - diff --git a/src/docs/user/userguide/differential_test_plans.diviner b/src/docs/user/userguide/differential_test_plans.diviner index 645578093d..81992097a2 100644 --- a/src/docs/user/userguide/differential_test_plans.diviner +++ b/src/docs/user/userguide/differential_test_plans.diviner @@ -63,5 +63,3 @@ you are writing; they are adapted from Facebook's internal documentation. - **Static Resources:** Will your change cause the application to serve more JS or CSS? Can you use less JS/CSS, or reuse more? - **Browsers:** Have you tested your change in multiple browsers? - - diff --git a/src/docs/user/userguide/herald.diviner b/src/docs/user/userguide/herald.diviner index 66272fb325..b2e11d65e4 100644 --- a/src/docs/user/userguide/herald.diviner +++ b/src/docs/user/userguide/herald.diviner @@ -96,4 +96,3 @@ A few features in Herald are particularly complicated: than "all" vs "any" allows, or have a common set of conditions which you want to share between several rules. If a rule is only being used as a group of conditions, you can set the action to "Do Nothing". - diff --git a/src/docs/user/userguide/mail_rules.diviner b/src/docs/user/userguide/mail_rules.diviner index b5c8253bb0..2000d6d160 100644 --- a/src/docs/user/userguide/mail_rules.diviner +++ b/src/docs/user/userguide/mail_rules.diviner @@ -79,4 +79,3 @@ The headers Phabricator adds to mail are: - ##X-Herald-Rules##: this is attached to some mail and shows Herald rule IDs which have triggered for the object. You can use this to sort or categorize mail that has triggered specific rules. - diff --git a/src/docs/user/userguide/maniphest_custom.diviner b/src/docs/user/userguide/maniphest_custom.diviner index 0193d52002..f285fe69d4 100644 --- a/src/docs/user/userguide/maniphest_custom.diviner +++ b/src/docs/user/userguide/maniphest_custom.diviner @@ -62,4 +62,3 @@ the field. These options are available: "Create Another Similar Task". Some fields from the original task are copied into the new task, while others are not; by default, fields are not copied. If you want this field to be copied, specify `true` for the `copy` property. - diff --git a/src/docs/user/userguide/phame.diviner b/src/docs/user/userguide/phame.diviner index 1cf22b1b53..64e17d421f 100644 --- a/src/docs/user/userguide/phame.diviner +++ b/src/docs/user/userguide/phame.diviner @@ -7,18 +7,18 @@ Journal about your thoughts and feelings. Share with others. Profit. Phame is a simple blogging platform. You can write drafts which only you can see. Later, you can publish these drafts as posts which anyone who can access -the Phabricator instance can see. You can also add posts to blogs to increase +the Phabricator instance can see. You can also add posts to blogs to increase your distribution. -Overall, Phame is intended to help an individual spread their message. As +Overall, Phame is intended to help an individual spread their message. As such, pertinent design decisions skew towards favoring the individual -rather than the collective. +rather than the collective. = Drafts = -Drafts are completely private so draft away. +Drafts are completely private so draft away. -= Posts = += Posts = Posts are accessible to anyone who has access to the Phabricator instance. @@ -33,10 +33,10 @@ Soon, blogs will be useful for powering external websites, like blog.yourcompany.com -by making pertinent configuration changes with your DNS authority and +by making pertinent configuration changes with your DNS authority and Phabricator instance. -NOTE: removing a blogger from a given blog does not remove their posts that +NOTE: removing a blogger from a given blog does not remove their posts that are already associated with the blog. Rather, it removes their ability to edit metadata about and add posts to the blog. @@ -50,7 +50,7 @@ A given comment widget is tied 1:1 with a given post. This means the same instance of a given comment widget will appear for a given post regardless of whether that post is being viewed in the context of a blog. -= Next Steps = += Next Steps = - Phame is extremely new and very basic for now. Give us feedback on what you'd like to see improve! See @{article:Give Feedback! Get Support!}. diff --git a/src/infrastructure/__tests__/PhabricatorInfrastructureTestCase.php b/src/infrastructure/__tests__/PhabricatorInfrastructureTestCase.php index 47cdbf14fe..68822568ae 100644 --- a/src/infrastructure/__tests__/PhabricatorInfrastructureTestCase.php +++ b/src/infrastructure/__tests__/PhabricatorInfrastructureTestCase.php @@ -101,4 +101,3 @@ final class PhabricatorInfrastructureTestCase } } - diff --git a/src/infrastructure/celerity/CeleritySpriteGenerator.php b/src/infrastructure/celerity/CeleritySpriteGenerator.php index 95102cf5ce..42e33c9ca6 100644 --- a/src/infrastructure/celerity/CeleritySpriteGenerator.php +++ b/src/infrastructure/celerity/CeleritySpriteGenerator.php @@ -863,5 +863,3 @@ EOCSS return $sheet; } } - - diff --git a/src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php b/src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php index 2e81dee3ed..1456085eba 100644 --- a/src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php +++ b/src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php @@ -160,4 +160,3 @@ abstract class PhabricatorBotBaseStreamingProtocolAdapter abstract protected function processMessage($raw_object); } - diff --git a/src/infrastructure/events/PhabricatorEvent.php b/src/infrastructure/events/PhabricatorEvent.php index d92d7b6894..03116cdd9e 100644 --- a/src/infrastructure/events/PhabricatorEvent.php +++ b/src/infrastructure/events/PhabricatorEvent.php @@ -42,8 +42,3 @@ final class PhabricatorEvent extends PhutilEvent { } } - - - - - diff --git a/src/infrastructure/events/PhabricatorEventListener.php b/src/infrastructure/events/PhabricatorEventListener.php index 5a0c8c1986..211cc1f544 100644 --- a/src/infrastructure/events/PhabricatorEventListener.php +++ b/src/infrastructure/events/PhabricatorEventListener.php @@ -49,8 +49,3 @@ abstract class PhabricatorEventListener extends PhutilEventListener { } } - - - - - diff --git a/src/infrastructure/events/PhabricatorExampleEventListener.php b/src/infrastructure/events/PhabricatorExampleEventListener.php index 03c83d7146..4cbbb6b0bb 100644 --- a/src/infrastructure/events/PhabricatorExampleEventListener.php +++ b/src/infrastructure/events/PhabricatorExampleEventListener.php @@ -29,8 +29,3 @@ final class PhabricatorExampleEventListener extends PhabricatorEventListener { } } - - - - - diff --git a/src/view/control/AphrontTableView.php b/src/view/control/AphrontTableView.php index 17fca10d5a..e698421c88 100644 --- a/src/view/control/AphrontTableView.php +++ b/src/view/control/AphrontTableView.php @@ -320,4 +320,3 @@ final class AphrontTableView extends AphrontView { } - diff --git a/src/view/layout/PhabricatorFileLinkListView.php b/src/view/layout/PhabricatorFileLinkListView.php index 0eaf519d33..5824b6a8c2 100644 --- a/src/view/layout/PhabricatorFileLinkListView.php +++ b/src/view/layout/PhabricatorFileLinkListView.php @@ -34,4 +34,3 @@ final class PhabricatorFileLinkListView extends AphrontView { return phutil_implode_html(phutil_tag('br'), $file_links); } } - diff --git a/src/view/viewutils.php b/src/view/viewutils.php index 44916e947b..b7fc259dfe 100644 --- a/src/view/viewutils.php +++ b/src/view/viewutils.php @@ -277,4 +277,3 @@ function phabricator_format_units_generic( return $num_string; } - diff --git a/support/aphlict/client/aphlict_test_client.php b/support/aphlict/client/aphlict_test_client.php index b6ca0480d6..52974a0731 100755 --- a/support/aphlict/client/aphlict_test_client.php +++ b/support/aphlict/client/aphlict_test_client.php @@ -53,4 +53,3 @@ while (true) { $message = $proto_channel->waitForMessage(); $console->writeOut($json->encodeFormatted($message)); } - diff --git a/support/empty/README b/support/empty/README index 1d7f895991..019c55dcec 100644 --- a/support/empty/README +++ b/support/empty/README @@ -3,4 +3,3 @@ for some reason, you can use this one. Of course, it's not quite empty because it has this file in it. So it's a mostly-empty, readable directory. - diff --git a/webroot/index.php b/webroot/index.php index f880a77b90..7072727e7f 100644 --- a/webroot/index.php +++ b/webroot/index.php @@ -148,4 +148,3 @@ try { $ex, $show_unexpected_traces); } - diff --git a/webroot/rsrc/css/aphront/lightbox-attachment.css b/webroot/rsrc/css/aphront/lightbox-attachment.css index 6058b95fb9..a11512ce4e 100644 --- a/webroot/rsrc/css/aphront/lightbox-attachment.css +++ b/webroot/rsrc/css/aphront/lightbox-attachment.css @@ -104,4 +104,3 @@ .lightbox-attachment .lightbox-right:hover { background: url('/rsrc/image/icon/lightbox/right-arrow-hover-2.png'); } - diff --git a/webroot/rsrc/css/aphront/phabricator-nav-view.css b/webroot/rsrc/css/aphront/phabricator-nav-view.css index efb8b91f61..b6682c6f44 100644 --- a/webroot/rsrc/css/aphront/phabricator-nav-view.css +++ b/webroot/rsrc/css/aphront/phabricator-nav-view.css @@ -100,4 +100,3 @@ .device-phone .phabricator-side-menu-home .phabricator-nav-local { width: 100%; } - diff --git a/webroot/rsrc/css/application/conpherence/notification.css b/webroot/rsrc/css/application/conpherence/notification.css index 565504cbc2..ec55ad0b3a 100644 --- a/webroot/rsrc/css/application/conpherence/notification.css +++ b/webroot/rsrc/css/application/conpherence/notification.css @@ -77,4 +77,3 @@ color: #a1a5a9; font-size: 11px; } - diff --git a/webroot/rsrc/css/application/differential/core.css b/webroot/rsrc/css/application/differential/core.css index 2b4f6b4d9c..7ccd633f3f 100644 --- a/webroot/rsrc/css/application/differential/core.css +++ b/webroot/rsrc/css/application/differential/core.css @@ -23,4 +23,3 @@ -ms-user-select: none; user-select: none; } - diff --git a/webroot/rsrc/css/application/maniphest/batch-editor.css b/webroot/rsrc/css/application/maniphest/batch-editor.css index 10e9a61d62..f761cf1aa0 100644 --- a/webroot/rsrc/css/application/maniphest/batch-editor.css +++ b/webroot/rsrc/css/application/maniphest/batch-editor.css @@ -16,4 +16,3 @@ width: 100%; text-align: left; } - diff --git a/webroot/rsrc/css/application/people/people-profile.css b/webroot/rsrc/css/application/people/people-profile.css index 655bcb0c99..bc0e61fbf9 100644 --- a/webroot/rsrc/css/application/people/people-profile.css +++ b/webroot/rsrc/css/application/people/people-profile.css @@ -76,4 +76,3 @@ form.compose-dialog { .compose-dialog .compose-background-backdrop { background-color: {$backdrop}; } - diff --git a/webroot/rsrc/css/layout/phabricator-action-header-view.css b/webroot/rsrc/css/layout/phabricator-action-header-view.css index fbc573b919..11127e18b6 100644 --- a/webroot/rsrc/css/layout/phabricator-action-header-view.css +++ b/webroot/rsrc/css/layout/phabricator-action-header-view.css @@ -62,4 +62,3 @@ width: 16px; margin-right: 4px; } - diff --git a/webroot/rsrc/css/phui/phui-icon.css b/webroot/rsrc/css/phui/phui-icon.css index ccc6715696..9ab8036bc9 100644 --- a/webroot/rsrc/css/phui/phui-icon.css +++ b/webroot/rsrc/css/phui/phui-icon.css @@ -50,5 +50,3 @@ width: 35px; background-size: 35px; } - - diff --git a/webroot/rsrc/externals/javelin/LICENSE b/webroot/rsrc/externals/javelin/LICENSE index 48fb9f83b0..7d06b3778a 100644 --- a/webroot/rsrc/externals/javelin/LICENSE +++ b/webroot/rsrc/externals/javelin/LICENSE @@ -22,4 +22,3 @@ LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - diff --git a/webroot/rsrc/externals/javelin/core/__tests__/event-stop-and-kill.js b/webroot/rsrc/externals/javelin/core/__tests__/event-stop-and-kill.js index bc45d43fe0..09a2d3a764 100644 --- a/webroot/rsrc/externals/javelin/core/__tests__/event-stop-and-kill.js +++ b/webroot/rsrc/externals/javelin/core/__tests__/event-stop-and-kill.js @@ -33,7 +33,3 @@ describe('Event Stop/Kill', function() { expect(target.getStopped()).toBe(true); }); }); - - - - diff --git a/webroot/rsrc/externals/javelin/core/__tests__/install.js b/webroot/rsrc/externals/javelin/core/__tests__/install.js index c6b78ce9e0..c13a281bd8 100644 --- a/webroot/rsrc/externals/javelin/core/__tests__/install.js +++ b/webroot/rsrc/externals/javelin/core/__tests__/install.js @@ -149,4 +149,3 @@ describe('Javelin Install', function() { }); }); - diff --git a/webroot/rsrc/externals/javelin/docs/Base.js b/webroot/rsrc/externals/javelin/docs/Base.js index dc207c7758..d2352e9c99 100644 --- a/webroot/rsrc/externals/javelin/docs/Base.js +++ b/webroot/rsrc/externals/javelin/docs/Base.js @@ -68,8 +68,3 @@ JX.install('Base', { } }); - - - - - diff --git a/webroot/rsrc/externals/javelin/docs/concepts/behaviors.diviner b/webroot/rsrc/externals/javelin/docs/concepts/behaviors.diviner index f41afe13cd..726762ecb4 100644 --- a/webroot/rsrc/externals/javelin/docs/concepts/behaviors.diviner +++ b/webroot/rsrc/externals/javelin/docs/concepts/behaviors.diviner @@ -179,4 +179,3 @@ The two major downsides to the behavior design appear to be: have more than just glue code, and should have been refactored into a real class some time ago. This is a pretty high-level drawback and is manageable through awareness of the risk and code review. - diff --git a/webroot/rsrc/externals/javelin/docs/onload.js b/webroot/rsrc/externals/javelin/docs/onload.js index 8772745045..7c76c08598 100644 --- a/webroot/rsrc/externals/javelin/docs/onload.js +++ b/webroot/rsrc/externals/javelin/docs/onload.js @@ -19,4 +19,3 @@ JX.onload = function(callback) { // This isn't the real function definition, it's only defined here to let the // documentation generator find it. The actual definition is in init.js. }; - diff --git a/webroot/rsrc/externals/javelin/ext/reactor/core/DynVal.js b/webroot/rsrc/externals/javelin/ext/reactor/core/DynVal.js index b65950caa9..ace3fd8ebe 100644 --- a/webroot/rsrc/externals/javelin/ext/reactor/core/DynVal.js +++ b/webroot/rsrc/externals/javelin/ext/reactor/core/DynVal.js @@ -45,4 +45,3 @@ JX.install('DynVal', { })); } }); - diff --git a/webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js b/webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js index 0dbefbf78c..a40d864dc8 100644 --- a/webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js +++ b/webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js @@ -87,4 +87,3 @@ JX.install('Reactor', { } } }); - diff --git a/webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js b/webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js index 490b4c10f4..02c60f9c41 100644 --- a/webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js +++ b/webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js @@ -94,4 +94,3 @@ JX.install('ReactorNode', { } } }); - diff --git a/webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNodeCalmer.js b/webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNodeCalmer.js index f06fd702dd..d652a7cbc0 100644 --- a/webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNodeCalmer.js +++ b/webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNodeCalmer.js @@ -45,4 +45,3 @@ JX.install('ReactorNodeCalmer', { } } }); - diff --git a/webroot/rsrc/externals/javelin/ext/reactor/dom/RDOM.js b/webroot/rsrc/externals/javelin/ext/reactor/dom/RDOM.js index 48b7b9687f..f34907f27f 100644 --- a/webroot/rsrc/externals/javelin/ext/reactor/dom/RDOM.js +++ b/webroot/rsrc/externals/javelin/ext/reactor/dom/RDOM.js @@ -403,5 +403,3 @@ JX.install('RDOM', { } } }); - - diff --git a/webroot/rsrc/externals/javelin/ext/view/HTMLView.js b/webroot/rsrc/externals/javelin/ext/view/HTMLView.js index aea6f7c7bd..244b252e05 100644 --- a/webroot/rsrc/externals/javelin/ext/view/HTMLView.js +++ b/webroot/rsrc/externals/javelin/ext/view/HTMLView.js @@ -135,4 +135,3 @@ JX.install('HTMLView', { } } }); - diff --git a/webroot/rsrc/externals/javelin/ext/view/View.js b/webroot/rsrc/externals/javelin/ext/view/View.js index 39d608a715..3e67320bcf 100644 --- a/webroot/rsrc/externals/javelin/ext/view/View.js +++ b/webroot/rsrc/externals/javelin/ext/view/View.js @@ -189,4 +189,3 @@ JX.install('View', { } } }); - diff --git a/webroot/rsrc/externals/javelin/ext/view/ViewRenderer.js b/webroot/rsrc/externals/javelin/ext/view/ViewRenderer.js index 3f11a3bec0..3fd3493683 100644 --- a/webroot/rsrc/externals/javelin/ext/view/ViewRenderer.js +++ b/webroot/rsrc/externals/javelin/ext/view/ViewRenderer.js @@ -17,4 +17,3 @@ JX.install('ViewRenderer', { } } }); - diff --git a/webroot/rsrc/externals/javelin/ext/view/ViewVisitor.js b/webroot/rsrc/externals/javelin/ext/view/ViewVisitor.js index 8c073cecb1..53d430c708 100644 --- a/webroot/rsrc/externals/javelin/ext/view/ViewVisitor.js +++ b/webroot/rsrc/externals/javelin/ext/view/ViewVisitor.js @@ -33,4 +33,3 @@ JX.install('ViewVisitor', { } } }); - diff --git a/webroot/rsrc/externals/javelin/lib/DOM.js b/webroot/rsrc/externals/javelin/lib/DOM.js index 5c94d406bc..42608a8e92 100644 --- a/webroot/rsrc/externals/javelin/lib/DOM.js +++ b/webroot/rsrc/externals/javelin/lib/DOM.js @@ -962,4 +962,3 @@ JX.install('DOM', { } } }); - diff --git a/webroot/rsrc/externals/javelin/lib/__tests__/URI.js b/webroot/rsrc/externals/javelin/lib/__tests__/URI.js index 62387c3b9e..a162ad59b8 100644 --- a/webroot/rsrc/externals/javelin/lib/__tests__/URI.js +++ b/webroot/rsrc/externals/javelin/lib/__tests__/URI.js @@ -300,4 +300,3 @@ describe('Javelin URI', function() { }); }); - diff --git a/webroot/rsrc/externals/javelin/lib/__tests__/behavior.js b/webroot/rsrc/externals/javelin/lib/__tests__/behavior.js index 11c47d4e36..3d25bead50 100644 --- a/webroot/rsrc/externals/javelin/lib/__tests__/behavior.js +++ b/webroot/rsrc/externals/javelin/lib/__tests__/behavior.js @@ -93,4 +93,3 @@ describe('Javelin Behaviors', function() { }); }); - diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js index 950d6876c7..aa5fb16d36 100644 --- a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js +++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js @@ -75,4 +75,3 @@ JX.install('TypeaheadCompositeSource', { } } }); - diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js index 6fc10b3c57..626d43378a 100644 --- a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js +++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js @@ -99,5 +99,3 @@ JX.install('TypeaheadOnDemandSource', { } } }); - - diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js index ace130610a..d0bd4672d9 100644 --- a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js +++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js @@ -56,6 +56,3 @@ JX.install('TypeaheadPreloadedSource', { } } }); - - - diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js index ac7045671d..39705f4dcd 100644 --- a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js +++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js @@ -35,6 +35,3 @@ JX.install('TypeaheadStaticSource', { } } }); - - - diff --git a/webroot/rsrc/image/icon/fatcow/README b/webroot/rsrc/image/icon/fatcow/README index c294834741..327a315cd4 100644 --- a/webroot/rsrc/image/icon/fatcow/README +++ b/webroot/rsrc/image/icon/fatcow/README @@ -14,4 +14,4 @@ Some icons have been adapted from the FatCow set for use in Phabricator: source/conduit.png (from satellite_dish.png) source/mobile.png (from phone.png) source/tablet.png (from tablet.png) - source/fax.png (from fax.png) \ No newline at end of file + source/fax.png (from fax.png) diff --git a/webroot/rsrc/js/application/config/behavior-reorder-fields.js b/webroot/rsrc/js/application/config/behavior-reorder-fields.js index deb9da61b7..eb2f5bc36d 100644 --- a/webroot/rsrc/js/application/config/behavior-reorder-fields.js +++ b/webroot/rsrc/js/application/config/behavior-reorder-fields.js @@ -55,4 +55,3 @@ JX.behavior('config-reorder-fields', function(config) { }; }); - diff --git a/webroot/rsrc/js/application/countdown/timer.js b/webroot/rsrc/js/application/countdown/timer.js index ce8f0a6bf4..16a5366cf6 100644 --- a/webroot/rsrc/js/application/countdown/timer.js +++ b/webroot/rsrc/js/application/countdown/timer.js @@ -50,4 +50,3 @@ JX.behavior('countdown-timer', function(config) { } }); - diff --git a/webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js b/webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js index 216c1d4492..3d712444d0 100644 --- a/webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js +++ b/webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js @@ -45,4 +45,3 @@ JX.behavior('differential-add-reviewers-and-ccs', function(config) { } }); }); - diff --git a/webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js b/webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js index 1d83eab062..6210ee6b80 100644 --- a/webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js +++ b/webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js @@ -267,4 +267,3 @@ JX.behavior('differential-edit-inline-comments', function(config) { }); }); - diff --git a/webroot/rsrc/js/application/differential/behavior-keyboard-nav.js b/webroot/rsrc/js/application/differential/behavior-keyboard-nav.js index 98d0b73a04..c7ed6b268e 100644 --- a/webroot/rsrc/js/application/differential/behavior-keyboard-nav.js +++ b/webroot/rsrc/js/application/differential/behavior-keyboard-nav.js @@ -274,4 +274,3 @@ JX.behavior('differential-keyboard-navigation', function(config) { } }); - diff --git a/webroot/rsrc/js/application/diffusion/behavior-commit-branches.js b/webroot/rsrc/js/application/diffusion/behavior-commit-branches.js index d72b5206f7..5911a84a09 100644 --- a/webroot/rsrc/js/application/diffusion/behavior-commit-branches.js +++ b/webroot/rsrc/js/application/diffusion/behavior-commit-branches.js @@ -16,4 +16,3 @@ JX.behavior('diffusion-commit-branches', function(config) { } }); - diff --git a/webroot/rsrc/js/application/diffusion/behavior-commit-graph.js b/webroot/rsrc/js/application/diffusion/behavior-commit-graph.js index e9ab4b12bb..75844369b2 100644 --- a/webroot/rsrc/js/application/diffusion/behavior-commit-graph.js +++ b/webroot/rsrc/js/application/diffusion/behavior-commit-graph.js @@ -140,4 +140,3 @@ JX.behavior('diffusion-commit-graph', function(config) { }); - diff --git a/webroot/rsrc/js/application/diffusion/behavior-pull-lastmodified.js b/webroot/rsrc/js/application/diffusion/behavior-pull-lastmodified.js index 01e8238718..fbf924df5b 100644 --- a/webroot/rsrc/js/application/diffusion/behavior-pull-lastmodified.js +++ b/webroot/rsrc/js/application/diffusion/behavior-pull-lastmodified.js @@ -19,4 +19,3 @@ JX.behavior('diffusion-pull-lastmodified', function(config) { } }); - diff --git a/webroot/rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js b/webroot/rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js index 17a3aa7aa5..c7b850f44f 100644 --- a/webroot/rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js +++ b/webroot/rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js @@ -62,4 +62,3 @@ JX.behavior('doorkeeper-tag', function(config, statics) { JX.onload(load); }); - diff --git a/webroot/rsrc/js/application/files/behavior-icon-composer.js b/webroot/rsrc/js/application/files/behavior-icon-composer.js index 2967f49e2f..8f574c0dc4 100644 --- a/webroot/rsrc/js/application/files/behavior-icon-composer.js +++ b/webroot/rsrc/js/application/files/behavior-icon-composer.js @@ -73,4 +73,3 @@ JX.behavior('icon-composer', function(config) { redraw(); }); - diff --git a/webroot/rsrc/js/application/files/behavior-launch-icon-composer.js b/webroot/rsrc/js/application/files/behavior-launch-icon-composer.js index 327a7efc54..65a1903690 100644 --- a/webroot/rsrc/js/application/files/behavior-launch-icon-composer.js +++ b/webroot/rsrc/js/application/files/behavior-launch-icon-composer.js @@ -22,4 +22,3 @@ JX.behavior('launch-icon-composer', function(config) { }); }); - diff --git a/webroot/rsrc/js/application/harbormaster/behavior-reorder-steps.js b/webroot/rsrc/js/application/harbormaster/behavior-reorder-steps.js index f47bea8ecd..3bbae89489 100644 --- a/webroot/rsrc/js/application/harbormaster/behavior-reorder-steps.js +++ b/webroot/rsrc/js/application/harbormaster/behavior-reorder-steps.js @@ -39,4 +39,3 @@ JX.behavior('harbormaster-reorder-steps', function(config) { }); }); - diff --git a/webroot/rsrc/js/application/maniphest/behavior-line-chart.js b/webroot/rsrc/js/application/maniphest/behavior-line-chart.js index cfa32e719e..0466e16ce8 100644 --- a/webroot/rsrc/js/application/maniphest/behavior-line-chart.js +++ b/webroot/rsrc/js/application/maniphest/behavior-line-chart.js @@ -86,4 +86,3 @@ JX.behavior('line-chart', function(config) { }); }); - diff --git a/webroot/rsrc/js/application/maniphest/behavior-transaction-controls.js b/webroot/rsrc/js/application/maniphest/behavior-transaction-controls.js index b4087067a2..213ed47b11 100644 --- a/webroot/rsrc/js/application/maniphest/behavior-transaction-controls.js +++ b/webroot/rsrc/js/application/maniphest/behavior-transaction-controls.js @@ -33,4 +33,3 @@ JX.behavior('maniphest-transaction-controls', function(config) { }); }); - diff --git a/webroot/rsrc/js/application/search/behavior-reorder-queries.js b/webroot/rsrc/js/application/search/behavior-reorder-queries.js index 8a7359f12c..38568193e3 100644 --- a/webroot/rsrc/js/application/search/behavior-reorder-queries.js +++ b/webroot/rsrc/js/application/search/behavior-reorder-queries.js @@ -39,4 +39,3 @@ JX.behavior('search-reorder-queries', function(config) { }); }); - diff --git a/webroot/rsrc/js/core/FileUpload.js b/webroot/rsrc/js/core/FileUpload.js index bdc28f427f..2d9e2d9b1d 100644 --- a/webroot/rsrc/js/core/FileUpload.js +++ b/webroot/rsrc/js/core/FileUpload.js @@ -111,4 +111,3 @@ JX.install('PhabricatorFileUpload', { } }); - diff --git a/webroot/rsrc/js/core/MultirowRowManager.js b/webroot/rsrc/js/core/MultirowRowManager.js index 319ff353c2..8c3655ddfe 100644 --- a/webroot/rsrc/js/core/MultirowRowManager.js +++ b/webroot/rsrc/js/core/MultirowRowManager.js @@ -143,4 +143,3 @@ JX.install('MultirowRowManager', { _removeSigil : "tools-multirow-row-manager-row-remove" } }); - diff --git a/webroot/rsrc/js/core/Notification.js b/webroot/rsrc/js/core/Notification.js index 494508c32d..0b66825b9f 100644 --- a/webroot/rsrc/js/core/Notification.js +++ b/webroot/rsrc/js/core/Notification.js @@ -188,4 +188,3 @@ JX.install('Notification', { } }); - diff --git a/webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js b/webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js index 352c617a96..c5f3bf3a30 100644 --- a/webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js +++ b/webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js @@ -39,4 +39,3 @@ JX.behavior('aphront-drag-and-drop-textarea', function(config) { } }); - diff --git a/webroot/rsrc/js/core/behavior-global-drag-and-drop.js b/webroot/rsrc/js/core/behavior-global-drag-and-drop.js index ad66625599..93986f4c99 100644 --- a/webroot/rsrc/js/core/behavior-global-drag-and-drop.js +++ b/webroot/rsrc/js/core/behavior-global-drag-and-drop.js @@ -65,4 +65,3 @@ JX.behavior('global-drag-and-drop', function(config) { drop.start(); }); - diff --git a/webroot/rsrc/swf/test.html b/webroot/rsrc/swf/test.html index 1cdf65ae62..37b96bde53 100644 --- a/webroot/rsrc/swf/test.html +++ b/webroot/rsrc/swf/test.html @@ -1,4 +1,4 @@ - \ No newline at end of file +