revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 13:22:42 +01:00
Code Issues Releases Wiki Activity

Don't flag "EXPLAIN" as a write

Browse source 
Summary: These queries are safe to run without a CSRF token, and we need them
for the query analyzer in DarkConsole.

Test Plan: "Analyze Query Plans" works again.

Reviewers: jungejason, nh, tuomaspelkonen, aran

Reviewed By: nh

CC: aran, epriestley, nh

Differential Revision: 895
This commit is contained in:
epriestley 2011-09-04 14:57:33 -07:00
parent ae045a9cf2
commit 628082d427
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/storage/connection/mysql/AphrontMySQLDatabaseConnection.php
View file

@ -209,7 +209,7 @@ class AphrontMySQLDatabaseConnection extends AphrontDatabaseConnection {
$this->requireConnection(); $this->requireConnection();
// TODO: Do we need to include transactional statements here? // TODO: Do we need to include transactional statements here?
$is_write = !preg_match('/^(SELECT|SHOW)\s/', $raw_query); $is_write = !preg_match('/^(SELECT|SHOW|EXPLAIN)\s/', $raw_query);
if ($is_write) { if ($is_write) {
AphrontWriteGuard::willWrite(); AphrontWriteGuard::willWrite();
} }