From 62973e0f5396187a13d1b44d2b2689367a966ef5 Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 17 Apr 2014 16:01:27 -0700 Subject: [PATCH] Add `activeDiffPHID` to differential.query Summary: Ref T4809. This saves us a few round trips to find a Buildable, and generally makes the notion of "active" more explicit (i.e., not just the diff with the largest ID). In the future, we may let you revert to previous diffs, which would make the "largest number" rule not always correct. Test Plan: Ran `differential.query`, got sensible results. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4809 Differential Revision: https://secure.phabricator.com/D8800 --- .../conduit/ConduitAPI_differential_query_Method.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/differential/conduit/ConduitAPI_differential_query_Method.php b/src/applications/differential/conduit/ConduitAPI_differential_query_Method.php index 349389c2ff..4d61b7863b 100644 --- a/src/applications/differential/conduit/ConduitAPI_differential_query_Method.php +++ b/src/applications/differential/conduit/ConduitAPI_differential_query_Method.php @@ -218,6 +218,7 @@ final class ConduitAPI_differential_query_Method 'summary' => $revision->getSummary(), 'testPlan' => $revision->getTestPlan(), 'lineCount' => $revision->getLineCount(), + 'activeDiffPHID' => $diff->getPHID(), 'diffs' => $revision->getDiffIDs(), 'commits' => $revision->getCommitPHIDs(), 'reviewers' => array_values($revision->getReviewers()),