revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-21 22:32:41 +01:00
Code Issues Releases Wiki Activity

Restrict maximum task title length to 255 characters

Browse source 
Summary:
A task title is supposed to summarize a task. For long novels, there is the task description.

Closes T15898

Test Plan: Go to http://phorge.localhost/maniphest/task/edit/form/default/ and enter a task title with multi-byte characters above the threshold, press "Enter".

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15898

Differential Revision: https://we.phorge.it/D25759
This commit is contained in:
Andre Klapper 2024-08-01 16:55:37 +02:00
parent d8b94dd87d
commit 62aaa0fcbe
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php
View file

@ -4,6 +4,7 @@ final class ManiphestTaskTitleTransaction
extends ManiphestTaskTransactionType {
const TRANSACTIONTYPE = 'title';
private $maximumTaskTitleLength = 255;
public function generateOldValue($object) {
return $object->getTitle();
@ -78,6 +79,13 @@ final class ManiphestTaskTitleTransaction
$xaction);
continue;
}
if (mb_strlen($new) > $this->maximumTaskTitleLength) {
$errors[] = $this->newInvalidError(
pht('Task title cannot exceed %d characters.',
$this->maximumTaskTitleLength),
$xaction);
continue;
}
}
if (!$errors) {