revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Remove a check for closing revisions

Browse source 
Summary:
I ran into a case where a commit isn't "new" but hasn't been closed. I
think the check on the status of the differential revision should be
enough and this check isn't needed.

Test Plan:
used the reparse.php script to close a revision that previously wouldn't
close.

Reviewers: epriestley, vrana

Reviewed By: vrana

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3232
This commit is contained in:
Nick Harper 2012-08-10 16:15:37 -07:00
parent 4eebd545ce
commit 62b3e4aea3
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
View file

@ -106,7 +106,6 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
DifferentialRevision::TABLE_COMMIT, DifferentialRevision::TABLE_COMMIT,
$revision->getID(), $revision->getID(),
$commit->getPHID()); $commit->getPHID());
$commit_is_new = $conn_w->getAffectedRows();
$committer_phid = $data->getCommitDetail('committerPHID'); $committer_phid = $data->getCommitDetail('committerPHID');
if ($committer_phid) { if ($committer_phid) {
@ -142,8 +141,7 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
$revision->getAuthorPHID()); $revision->getAuthorPHID());
$status_closed = ArcanistDifferentialRevisionStatus::CLOSED; $status_closed = ArcanistDifferentialRevisionStatus::CLOSED;
$should_close = $commit_is_new && $should_close = ($revision->getStatus() != $status_closed) &&
($revision->getStatus() != $status_closed) &&
$repository->shouldAutocloseCommit($commit, $data); $repository->shouldAutocloseCommit($commit, $data);
if ($should_close) { if ($should_close) {