revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00
Code Issues Releases Wiki Activity

According to Jira Project keys must start with an uppercase letter, followed by one or more uppercase alphanumeric characters

Browse source 
Summary: Jira allows creating projects which contain number in names, phabricator will not allow such projects but it should

Test Plan: Pasted URL with Jira project which contain number in project name and it was parsed and resolved properly in phabricator

Reviewers: epriestley, Pawka, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D21040
This commit is contained in:
Arturas Moskvinas arturas@uber.com 2020-03-09 16:35:40 +02:00
parent d0f4554dbe
commit 62f5bdbbd2
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/auth/provider/PhabricatorJIRAAuthProvider.php
View file

@ -335,7 +335,7 @@ final class PhabricatorJIRAAuthProvider
public function getDoorkeeperURIRef(PhutilURI $uri) { public function getDoorkeeperURIRef(PhutilURI $uri) {
$uri_string = phutil_string_cast($uri); $uri_string = phutil_string_cast($uri);
$pattern = '((https?://\S+?)/browse/([A-Z]+-[1-9]\d*))'; $pattern = '((https?://\S+?)/browse/([A-Z][A-Z0-9]*-[1-9]\d*))';
$matches = null; $matches = null;
if (!preg_match($pattern, $uri_string, $matches)) { if (!preg_match($pattern, $uri_string, $matches)) {
return null; return null;