revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-23 12:09:12 +01:00
Code Issues Releases Wiki Activity

Load changesets with inline comments drafts in large diff

Browse source 
Test Plan: Displayed a large diff with inline comment draft.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3175
This commit is contained in:
vrana 2012-08-06 20:42:43 -07:00
parent f614670de9
commit 6361ffedaa
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/applications/differential/controller/DifferentialRevisionViewController.php
View file

@ -200,8 +200,15 @@ final class DifferentialRevisionViewController extends DifferentialController {
"</strong>"); "</strong>");
$warning = $warning->render(); $warning = $warning->render();
$my_inlines = id(new DifferentialInlineComment())->loadAllWhere(
'revisionID = %d AND commentID IS NULL AND authorPHID = %s AND '.
'changesetID IN (%Ld)',
$this->revisionID,
$user->getPHID(),
mpull($changesets, 'getID'));
$visible_changesets = array(); $visible_changesets = array();
foreach ($inlines as $inline) { foreach ($inlines + $my_inlines as $inline) {
$changeset_id = $inline->getChangesetID(); $changeset_id = $inline->getChangesetID();
if (isset($changesets[$changeset_id])) { if (isset($changesets[$changeset_id])) {
$visible_changesets[$changeset_id] = $changesets[$changeset_id]; $visible_changesets[$changeset_id] = $changesets[$changeset_id];