From 63c33eeb5d3c7f61cfa4856d6de9e9b5365b041e Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Thu, 25 Jul 2013 17:40:33 -0700 Subject: [PATCH] make transaction edits work Summary: Fixes T3621. We had a fatal from a non-existent function. Also changes form to full width. Test Plan: edited and it worked! looked better too! Reviewers: epriestley, chad Reviewed By: chad CC: aran, Korvin Maniphest Tasks: T3621 Differential Revision: https://secure.phabricator.com/D6571 --- ...icatorApplicationTransactionCommentEditController.php | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentEditController.php b/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentEditController.php index 022b482caf..64cf7895d7 100644 --- a/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentEditController.php +++ b/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentEditController.php @@ -49,7 +49,7 @@ final class PhabricatorApplicationTransactionCommentEditController $editor = id(new PhabricatorApplicationTransactionCommentEditor()) ->setActor($user) - ->setContentSourceFromRequest($request) + ->setContentSource(PhabricatorContentSource::newFromRequest($request)) ->applyEdit($xaction, $comment); if ($request->isAjax()) { @@ -69,9 +69,12 @@ final class PhabricatorApplicationTransactionCommentEditController $dialog ->addHiddenInput('anchor', $request->getStr('anchor')) ->appendChild( - id(new PhabricatorRemarkupControl()) + id(new AphrontFormLayoutView()) + ->setFullWidth(true) + ->appendChild( + id(new PhabricatorRemarkupControl()) ->setName('text') - ->setValue($xaction->getComment()->getContent())); + ->setValue($xaction->getComment()->getContent()))); $dialog ->addSubmitButton(pht('Edit Comment'))