revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-29 04:28:12 +01:00
Code Issues Releases Wiki Activity

Don't prompt to mark notifications as read if we don't need to

Browse source 
Summary: Fixes whatever task is tracking this junk, if one exists. Don't prompt unless there's a security issue.

Test Plan:
  - Generated notifications from a test account.
  - Clicked "Mark All" from dropdown menu, no prompt.
  - Clicked "Mark All" from notifications screen, no prompt.
  - Command-Clicked "Mark All" from dropdown menu to open in new window, got normal prompt.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D18483
This commit is contained in:
epriestley 2017-08-28 12:12:13 -07:00
parent b8b701faf7
commit 643877b467
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/applications/notification/controller/PhabricatorNotificationClearController.php
View file

@ -8,6 +8,17 @@ final class PhabricatorNotificationClearController
$chrono_key = $request->getStr('chronoKey'); $chrono_key = $request->getStr('chronoKey');
if ($request->isDialogFormPost()) { if ($request->isDialogFormPost()) {
$should_clear = true;
} else {
try {
$request->validateCSRF();
$should_clear = true;
} catch (AphrontMalformedRequestException $ex) {
$should_clear = false;
}
}
if ($should_clear) {
$table = new PhabricatorFeedStoryNotification(); $table = new PhabricatorFeedStoryNotification();
queryfx( queryfx(