From 644ca4c3a3e704ba1d38ada628366ce90bcd75af Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 29 Sep 2014 08:10:48 -0700 Subject: [PATCH] Use --single-transaction in `bin/storage dump` Summary: See . From reading documentation, this seems dramatically better for InnoDB tables than the default behavior. Test Plan: Ran `bin/storage dump`, got a reasonable-looking dump. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D10606 --- .../workflow/PhabricatorStorageManagementDumpWorkflow.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php index fa47ca2133..4e01446929 100644 --- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php +++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php @@ -43,10 +43,8 @@ final class PhabricatorStorageManagementDumpWorkflow : ''; return phutil_passthru( - - 'mysqldump --default-character-set=utf8 '. + 'mysqldump --single-transaction --default-character-set=utf8 '. '-u %s %C -h %s %C --databases %Ls', - $api->getUser(), $flag_password, $host,