From 648d5ce19076ea5d14b4f2d628811079f8472abd Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 25 Apr 2019 08:08:56 -0700 Subject: [PATCH] Set a URI on Auth Messages, so the "Change Details" dialog from the transaction record has a cancel button Summary: If you edit an auth message in Auth > Customize Messages, then click "Show Details" in the transaction record, the resulting dialog uses the object's handle's URI to generate a "cancel" button. Since these handles currently have no URI, the dialog currently has no cancel/done button to close it. Test Plan: Edited an auth message, clicked "Show Details", was now able to click "Done" to close the dialog. Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D20471 --- .../auth/phid/PhabricatorAuthMessagePHIDType.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/applications/auth/phid/PhabricatorAuthMessagePHIDType.php b/src/applications/auth/phid/PhabricatorAuthMessagePHIDType.php index 7a023c4a4c..005e363b08 100644 --- a/src/applications/auth/phid/PhabricatorAuthMessagePHIDType.php +++ b/src/applications/auth/phid/PhabricatorAuthMessagePHIDType.php @@ -28,7 +28,11 @@ final class PhabricatorAuthMessagePHIDType extends PhabricatorPHIDType { PhabricatorHandleQuery $query, array $handles, array $objects) { - return; + + foreach ($handles as $phid => $handle) { + $message = $objects[$phid]; + $handle->setURI($message->getURI()); + } } }