revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 05:12:41 +01:00
Code Issues Releases Wiki Activity

Always override auth.email-domains when running unit tests

Browse source 
Summary: Fixes T9689, Always override `auth.email-domains` when running unit tests

Test Plan:
- Set `auth.email-domains`
- Run `arc unit --everything`.
Observe no errors.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Maniphest Tasks: T9689

Differential Revision: https://secure.phabricator.com/D14456
This commit is contained in:
lkassianik 2015-11-10 10:09:14 -08:00
parent 3747a35476
commit 64ad44cffb
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php
View file

@ -56,7 +56,6 @@ final class PhabricatorAccessControlTestCase extends PhabricatorTestCase {
$env->overrideEnvConfig('phabricator.base-uri', 'http://'.$host); $env->overrideEnvConfig('phabricator.base-uri', 'http://'.$host);
$env->overrideEnvConfig('policy.allow-public', false); $env->overrideEnvConfig('policy.allow-public', false);
$env->overrideEnvConfig('auth.require-email-verification', false); $env->overrideEnvConfig('auth.require-email-verification', false);
$env->overrideEnvConfig('auth.email-domains', array());
$env->overrideEnvConfig('security.require-multi-factor-auth', false); $env->overrideEnvConfig('security.require-multi-factor-auth', false);

4
src/infrastructure/testing/PhabricatorTestCase.php
View file

@ -120,6 +120,10 @@ abstract class PhabricatorTestCase extends PhutilTestCase {
'phabricator.base-uri', 'phabricator.base-uri',
'http://phabricator.example.com'); 'http://phabricator.example.com');
$this->env->overrideEnvConfig(
'auth.email-domains',
array());
// Tests do their own stubbing/voiding for events. // Tests do their own stubbing/voiding for events.
$this->env->overrideEnvConfig('phabricator.silent', false); $this->env->overrideEnvConfig('phabricator.silent', false);
} }