Remove loadMemberPHIDs from PhabricatorProject

Summary:
Ref T603. Move toward stamping out all the Project / ProjectProfile query irregularities with respect to policies.

  - Fixes a bug with Asana publishing when the remote task is deleted.
  - Fixes an issue with Herald commit rules.

Test Plan:
  - Viewed projects;
  - edited projects;
  - added and removed members from projects;
  - republished Asana-bridged feed stories about commits.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7251

src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php

@@ -83,7 +83,12 @@ final class DiffusionDoorkeeperCommitFeedStoryPublisher
         $request_phids = PhabricatorOwnersOwner::loadAffiliatedUserPHIDs(
           array($object->getID()));
       } else if ($object instanceof PhabricatorProject) {
-        $request_phids = $object->loadMemberPHIDs();
+        $project = id(new PhabricatorProjectQuery())
+          ->setViewer($this->getViewer())
+          ->withIDs(array($object->getID()))
+          ->needMembers(true)
+          ->executeOne();
+        $request_phids = $project->getMemberPHIDs();
       } else {
         // Dunno what this is.
         $request_phids = array();

src/applications/doorkeeper/worker/DoorkeeperFeedWorkerAsana.php

@@ -209,8 +209,12 @@ final class DoorkeeperFeedWorkerAsana extends DoorkeeperFeedWorker {
     // Add the silent followers first so that a user who is both a reviewer and
     // a CC gets silently added and then implicitly skipped by then noisy add.
     // They will get a subtask notification.
+
+    // We only do this if the task still exists.
+    if (empty($extra_data['gone'])) {
       $this->addFollowers($oauth_token, $task_id, $silent_followers, true);
       $this->addFollowers($oauth_token, $task_id, $noisy_followers);
+    }
 
     $dst_phid = $parent_ref->getExternalObject()->getPHID();
 

src/applications/herald/adapter/HeraldCommitAdapter.php

@@ -150,6 +150,8 @@ final class HeraldCommitAdapter extends HeraldAdapter {
 
     $object = new HeraldCommitAdapter();
 
+    $commit->attachRepository($repository);
+
     $object->repository = $repository;
     $object->commit = $commit;
     $object->commitData = $commit_data;

src/applications/project/controller/PhabricatorProjectMembersEditController.php

@@ -16,6 +16,7 @@ final class PhabricatorProjectMembersEditController
     $project = id(new PhabricatorProjectQuery())
       ->setViewer($user)
       ->withIDs(array($this->id))
+      ->needMembers(true)
       ->requireCapabilities(
         array(
           PhabricatorPolicyCapability::CAN_VIEW,
@@ -30,7 +31,7 @@ final class PhabricatorProjectMembersEditController
       $profile = new PhabricatorProjectProfile();
     }
 
-    $member_phids = $project->loadMemberPHIDs();
+    $member_phids = $project->getMemberPHIDs();
 
     $errors = array();
     if ($request->isFormPost()) {

src/applications/project/editor/PhabricatorProjectEditor.php

@@ -213,8 +213,7 @@ final class PhabricatorProjectEditor extends PhabricatorEditor {
         $xaction->setOldValue($project->getStatus());
         break;
       case PhabricatorProjectTransactionType::TYPE_MEMBERS:
-        $member_phids = $project->loadMemberPHIDs();
+        $member_phids = $project->getMemberPHIDs();
-        $project->attachMemberPHIDs($member_phids);
 
         $old_value = array_values($member_phids);
         $xaction->setOldValue($old_value);

src/applications/project/storage/PhabricatorProject.php

@@ -112,15 +112,6 @@ final class PhabricatorProject extends PhabricatorProjectDAO
     return $this->assertAttached($this->memberPHIDs);
   }
 
-  public function loadMemberPHIDs() {
-    if (!$this->getPHID()) {
-      return array();
-    }
-    return PhabricatorEdgeQuery::loadDestinationPHIDs(
-      $this->getPHID(),
-      PhabricatorEdgeConfig::TYPE_PROJ_MEMBER);
-  }
-
   public function setPhrictionSlug($slug) {
 
     // NOTE: We're doing a little magic here and stripping out '/' so that