Move some value massaging into SearchFields

Summary: Ref T8441. Ref T7715. Let SearchFields do some value massaging before buiding queries so we don't have to work as hard in each SearchEngine. Particularly, they can handle evaluateTokens() from Tokenizers.

Test Plan: Paste automatically gained access to `viewer()`, etc.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7715, T8441

Differential Revision: https://secure.phabricator.com/D13170

src/applications/paste/query/PhabricatorPasteSearchEngine.php

@@ -11,21 +11,24 @@ final class PhabricatorPasteSearchEngine
     return 'PhabricatorPasteApplication';
   }
 
-  public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
+  public function buildQueryFromParameters(array $map) {
     $query = id(new PhabricatorPasteQuery())
-      ->needContent(true)
+      ->needContent(true);
-      ->withAuthorPHIDs($saved->getParameter('authorPHIDs', array()))
-      ->withLanguages($saved->getParameter('languages', array()));
 
-    $start = $this->parseDateTime($saved->getParameter('createdStart'));
+    if ($map['authorPHIDs']) {
-    $end = $this->parseDateTime($saved->getParameter('createdEnd'));
+      $query->withAuthorPHIDs($map['authorPHIDs']);
-
-    if ($start) {
-      $query->withDateCreatedAfter($start);
     }
 
-    if ($end) {
+    if ($map['languages']) {
-      $query->withDateCreatedBefore($end);
+      $query->withLanguages($map['languages']);
+    }
+
+    if ($map['createdStart']) {
+      $query->withDateCreatedAfter($map['createdStart']);
+    }
+
+    if ($map['createdEnd']) {
+      $query->withDateCreatedBefore($map['createdEnd']);
     }
 
     return $query;

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

@@ -90,8 +90,24 @@ abstract class PhabricatorApplicationSearchEngine extends Phobject {
    * @param PhabricatorSavedQuery The saved query to operate on.
    * @return The result of the query.
    */
-  abstract public function buildQueryFromSavedQuery(
+  public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
-    PhabricatorSavedQuery $saved);
+    $fields = $this->buildSearchFields();
+    $viewer = $this->requireViewer();
+
+    $parameters = array();
+    foreach ($fields as $field) {
+      $field->setViewer($viewer);
+      $field->readValueFromSavedQuery($saved);
+      $value = $field->getValueForQuery($field->getValue());
+      $parameters[$field->getKey()] = $value;
+    }
+
+    return $this->buildQueryFromParameters($parameters);
+  }
+
+  protected function buildQueryFromParameters(array $parameters) {
+    throw new PhutilMethodNotImplementedException();
+  }
 
   /**
    * Builds the search form using the request.

src/applications/search/field/PhabricatorSearchDateField.php

@@ -11,6 +11,10 @@ final class PhabricatorSearchDateField
     return $request->getStr($key);
   }
 
+  public function getValueForQuery($value) {
+    return $this->parseDateTime($value);
+  }
+
   protected function validateControlValue($value) {
     if (!strlen($value)) {
       return;

src/applications/search/field/PhabricatorSearchField.php

@@ -201,6 +201,10 @@ abstract class PhabricatorSearchField extends Phobject {
     return null;
   }
 
+  public function getValueForQuery($value) {
+    return $value;
+  }
+
 
 /* -(  Rendering Controls  )------------------------------------------------- */
 

src/applications/search/field/PhabricatorSearchTokenizerField.php

@@ -11,11 +11,18 @@ abstract class PhabricatorSearchTokenizerField
     return $this->getListFromRequest($request, $key);
   }
 
+  public function getValueForQuery($value) {
+    return $this->newDatasource()
+      ->setViewer($this->getViewer())
+      ->evaluateTokens($value);
+  }
+
   protected function newControl() {
     return id(new AphrontFormTokenizerControl())
       ->setDatasource($this->newDatasource());
   }
 
+
   abstract protected function newDatasource();
 
 }

src/applications/search/field/PhabricatorSearchUsersField.php

@@ -8,9 +8,7 @@ final class PhabricatorSearchUsersField
   }
 
   protected function newDatasource() {
-    // TODO: Make this use PhabricatorPeopleUserFunctionDatasource once field
+    return new PhabricatorPeopleUserFunctionDatasource();
-    // support is a little more powerful.
-    return new PhabricatorPeopleDatasource();
   }
 
   protected function getValueFromRequest(AphrontRequest $request, $key) {