Fix a few minor bugs in Auth Providers

Summary: Fixes T7496, T7511. Sets text for registration is not enabled, sets can_manage on add_provider button.

Test Plan: Test with a logged in admin and logged in normal joe user.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7496, T7511

Differential Revision: https://secure.phabricator.com/D12014

src/applications/auth/controller/config/PhabricatorAuthListController.php

@@ -12,6 +12,8 @@ final class PhabricatorAuthListController
       ->execute();
 
     $list = new PHUIObjectItemListView();
+    $can_manage = $this->hasApplicationCapability(
+        AuthManageProvidersCapability::CAPABILITY);
 
     foreach ($configs as $config) {
       $item = new PHUIObjectItemView();
@@ -47,10 +49,10 @@ final class PhabricatorAuthListController
 
       if ($config->getShouldAllowRegistration()) {
         $item->addAttribute(pht('Allows Registration'));
+      } else {
+        $item->addAttribute(pht('Does Not Allow Registration'));
       }
 
-      $can_manage = $this->hasApplicationCapability(
-        AuthManageProvidersCapability::CAPABILITY);
       if ($config->getIsEnabled()) {
         $item->setState(PHUIObjectItemView::STATE_SUCCESS);
         $item->addAction(
@@ -152,6 +154,7 @@ final class PhabricatorAuthListController
         ->setColor(PHUIButtonView::SIMPLE)
         ->setHref($this->getApplicationURI('config/new/'))
         ->setIcon($image)
+        ->setDisabled(!$can_manage)
         ->setText(pht('Add Provider'));
 
     $header = id(new PHUIHeaderView())