From 663629e8ad9d050110294fa456307a9d300e85b7 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 9 Nov 2016 17:05:41 -0800
Subject: [PATCH] =?UTF-8?q?Use=20Doritos=E2=84=A2=20Brand=C2=AE=20perfect?=
 =?UTF-8?q?=20circles=20to=20indicate=20Busy/Away/Disabled?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Summary:
Fixes T11829.

  - Currently in use: Doritos™ Brand® "Nacho Cheese"® perfect circles: •
  - Available alternative: Doritos™ Brand® "Cool Ranch"® perfect circles: ●

Test Plan: {F1913116}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11829

Differential Revision: https://secure.phabricator.com/D16834
---
 .../phid/PhabricatorObjectHandle.php          |  12 ++++++++++-
 .../application/base/standard-page-view.css   |  20 ++++++------------
 .../rsrc/image/icon/fatcow/bullet_black.png   | Bin 230 -> 0 bytes
 .../rsrc/image/icon/fatcow/bullet_orange.png  | Bin 232 -> 0 bytes
 webroot/rsrc/image/icon/fatcow/bullet_red.png | Bin 230 -> 0 bytes
 5 files changed, 17 insertions(+), 15 deletions(-)
 delete mode 100644 webroot/rsrc/image/icon/fatcow/bullet_black.png
 delete mode 100644 webroot/rsrc/image/icon/fatcow/bullet_orange.png
 delete mode 100644 webroot/rsrc/image/icon/fatcow/bullet_red.png

diff --git a/src/applications/phid/PhabricatorObjectHandle.php b/src/applications/phid/PhabricatorObjectHandle.php
index f3c04d2a25..943464ed67 100644
--- a/src/applications/phid/PhabricatorObjectHandle.php
+++ b/src/applications/phid/PhabricatorObjectHandle.php
@@ -314,8 +314,18 @@ final class PhabricatorObjectHandle
       $classes[] = 'handle-status-'.$this->status;
     }
 
+    $circle = null;
     if ($this->availability != self::AVAILABILITY_FULL) {
       $classes[] = 'handle-availability-'.$this->availability;
+      $circle = array(
+        phutil_tag(
+          'span',
+          array(
+            'class' => 'perfect-circle',
+          ),
+          "\xE2\x80\xA2"),
+        ' ',
+      );
     }
 
     if ($this->getType() == PhabricatorPeopleUserPHIDType::TYPECONST) {
@@ -339,7 +349,7 @@ final class PhabricatorObjectHandle
     return javelin_tag(
       $uri ? 'a' : 'span',
       $attributes,
-      array($icon, $name));
+      array($circle, $icon, $name));
   }
 
   public function renderTag() {
diff --git a/webroot/rsrc/css/application/base/standard-page-view.css b/webroot/rsrc/css/application/base/standard-page-view.css
index 36294ca288..ebcf157ad4 100644
--- a/webroot/rsrc/css/application/base/standard-page-view.css
+++ b/webroot/rsrc/css/application/base/standard-page-view.css
@@ -76,24 +76,16 @@ a.handle-status-closed:hover {
   color: #19558D;
 }
 
-a.handle-availability-disabled,
-a.handle-availability-none,
-a.handle-availability-partial {
-  padding-left: 11px;
-  background-repeat: no-repeat;
-  background-position: -4px center;
+.handle-availability-none .perfect-circle {
+  color: {$red};
 }
 
-a.handle-availability-none {
-  background-image: url(/rsrc/image/icon/fatcow/bullet_red.png);
+.handle-availability-partial .perfect-circle {
+  color: {$orange};
 }
 
-a.handle-availability-partial {
-  background-image: url(/rsrc/image/icon/fatcow/bullet_orange.png);
-}
-
-a.handle-availability-disabled {
-  background-image: url(/rsrc/image/icon/fatcow/bullet_black.png);
+.handle-availability-disabled .perfect-circle {
+  color: {$greytext};
 }
 
 .aphront-developer-error-callout {
diff --git a/webroot/rsrc/image/icon/fatcow/bullet_black.png b/webroot/rsrc/image/icon/fatcow/bullet_black.png
deleted file mode 100644
index a113d8ef3b385b8ef62dcf67bce1c9e148bc6180..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 230
zcmeAS@N?(olHy`uVBq!ia0vp^d_c_4!3HF+i2N%7Qj#UE5hcO-X(i=}MX3yqDfvmM
z3ZA)%>8U}fi7AzZCsS>JiaI=9978H@CH?vT-=5jBp|jD)VVj#+ieFY1SKzF)^YfZ7
zyLl_vu^oBe_(MqG_=By2Tyq*K#089<e=<4jk?6SDP$6e$AEun?#OB+=<j&mwd1>Pe
z{`tptTbS%)dgTAZq>RCETgXMH6Dw~w+~Dq5@A$L7(L%gKU6?CW;0EK-EB=-}CH_ws
b7}*#O>q?$o`$lRX&`k`Uu6{1-oD!M<-fU8z

diff --git a/webroot/rsrc/image/icon/fatcow/bullet_orange.png b/webroot/rsrc/image/icon/fatcow/bullet_orange.png
deleted file mode 100644
index dacfd4697fe27f5c3bef46bd689ae67fa1a9c7ee..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 232
zcmeAS@N?(olHy`uVBq!ia0vp^d_c_4!3HF+i2N%7Qj#UE5hcO-X(i=}MX3yqDfvmM
z3ZA)%>8U}fi7AzZCsS>Jin=^q978H@CH?vT-=5jBp)kSJZhg3#*W{GPv21EGMbjK=
zcslMge^gcIa|}Pw<T_bc;5}1PnnpZBhd8sLw7~gh%|mI)rjyiCF0`CExGa#l{qxes
z8T|8)?Y1!4$Mnemhe;WO;Wmpb#V1#C9p11WxxV1fafdnFM<#Q&YH_@2NSf2o+34f&
ee+!pD0)v;7>h5ID>Tf_-F?hQAxvX<aXaWE)UQ_J=

diff --git a/webroot/rsrc/image/icon/fatcow/bullet_red.png b/webroot/rsrc/image/icon/fatcow/bullet_red.png
deleted file mode 100644
index cc56c4b4b82cb43d95ecd7d285de3df687c76a11..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 230
zcmeAS@N?(olHy`uVBq!ia0vp^d_c_4!3HF+i2N%7Qj#UE5hcO-X(i=}MX3yqDfvmM
z3ZA)%>8U}fi7AzZCsS>JiaI=9978H@CH?vT-=5jBp|jD)VVj#+$~i}E*+nKd<##t-
zcJo%SV>|M`@rRJW@dsN4x#l!fhzl4y|73F5BhhiQp+e5iK1?~&iOsi#$(_0V^U}r{
z{PU0PwlLYp^vM5*Ng0FTwvdZXCsy8WxWV1A-tlLDqlI{fx-eI$zzxQuSNtt|O8lQN
bFtRZm5|uoAq<57b&`k`Uu6{1-oD!M<)ud80