Add a 'silent' option to diffusion.createcomment

Test Plan: Created comments with 'silent' both true and empty, received notifcation for only the latter.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7916

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

@@ -8,6 +8,8 @@ final class PhabricatorAuditCommentEditor extends PhabricatorEditor {
   private $auditors = array();
   private $ccs = array();
 
+  private $noEmail;
+
   public function __construct(PhabricatorRepositoryCommit $commit) {
     $this->commit = $commit;
     return $this;
@@ -28,6 +30,11 @@ final class PhabricatorAuditCommentEditor extends PhabricatorEditor {
     return $this;
   }
 
+  public function setNoEmail($no_email) {
+    $this->noEmail = $no_email;
+    return $this;
+  }
+
   public function addComment(PhabricatorAuditComment $comment) {
 
     $commit = $this->commit;
@@ -297,8 +304,10 @@ final class PhabricatorAuditCommentEditor extends PhabricatorEditor {
     id(new PhabricatorSearchIndexer())
       ->indexDocumentByPHID($commit->getPHID());
 
+    if (!$this->noEmail) {
       $this->sendMail($comment, $other_comments, $inline_comments, $requests);
     }
+  }
 
 
   /**

src/applications/diffusion/conduit/ConduitAPI_diffusion_createcomment_Method.php

@@ -21,6 +21,7 @@ final class ConduitAPI_diffusion_createcomment_Method
       'phid'    => 'required string',
       'action'  => 'optional string',
       'message' => 'required string',
+      'silent'  => 'optional bool',
     );
   }
 
@@ -73,6 +74,7 @@ final class ConduitAPI_diffusion_createcomment_Method
 
     id(new PhabricatorAuditCommentEditor($commit))
       ->setActor($request->getUser())
+      ->setNoEmail($request->getValue('silent'))
       ->addComment($comment);
 
     return true;