revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-04-03 16:08:19 +02:00
Code Issues Releases Wiki Activity

Use ManiphestTaskQuery instead of ad-hoc load in Maniphest reports

Browse source 
Summary: Fixes T5829. This stuff is old and busted, but keep it working for now.

Test Plan: No more fatal when there are recently closed tasks.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5829

Differential Revision: https://secure.phabricator.com/D10201
This commit is contained in:
epriestley 2014-08-08 16:21:53 -07:00
parent 24a6eeb8d8
commit 664507e450
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/applications/maniphest/controller/ManiphestReportController.php
View file

@ -671,9 +671,9 @@ final class ManiphestReportController extends ManiphestController {
$open_status_list[] = json_encode((string)$constant); $open_status_list[] = json_encode((string)$constant);
} }
$tasks = queryfx_all( $rows = queryfx_all(
$conn_r, $conn_r,
'SELECT t.* FROM %T t JOIN %T x ON x.objectPHID = t.phid 'SELECT t.id FROM %T t JOIN %T x ON x.objectPHID = t.phid
WHERE t.status NOT IN (%Ls) WHERE t.status NOT IN (%Ls)
AND x.oldValue IN (null, %Ls) AND x.oldValue IN (null, %Ls)
AND x.newValue NOT IN (%Ls) AND x.newValue NOT IN (%Ls)
@ -687,7 +687,16 @@ final class ManiphestReportController extends ManiphestController {
$window_epoch, $window_epoch,
$window_epoch); $window_epoch);
return id(new ManiphestTask())->loadAllFromArray($tasks); if (!$rows) {
return array();
}
$ids = ipull($rows, 'id');
return id(new ManiphestTaskQuery())
->setViewer($this->getRequest()->getUser())
->withIDs($ids)
->execute();
} }
/** /**