revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-11 07:11:04 +01:00
Code Issues Releases Wiki Activity

Add a User-Agent header to OAuth requests

Browse source 
Summary: GitHub now requires this: http://developer.github.com/changes/2013-04-24-user-agent-required/

Test Plan: Used GitHub auth to login.

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D5787
This commit is contained in:
epriestley 2013-04-26 07:52:58 -07:00
parent 614dcbb2d9
commit 664fe7ef73
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/applications/auth/controller/PhabricatorOAuthLoginController.php
View file

@ -47,12 +47,13 @@ final class PhabricatorOAuthLoginController
$userinfo_uri = (string)$userinfo_uri; $userinfo_uri = (string)$userinfo_uri;
try { try {
$user_data = HTTPSFuture::loadContent($userinfo_uri); $user_data_request = new HTTPSFuture($userinfo_uri);
if ($user_data === false) {
throw new PhabricatorOAuthProviderException( // NOTE: GitHub requires a User-Agent header.
"Request to '{$userinfo_uri}' failed!"); $user_data_request->addHeader('User-Agent', 'Phabricator');
}
$provider->setUserData($user_data); list($body) = $user_data_request->resolvex();
$provider->setUserData($body);
} catch (PhabricatorOAuthProviderException $e) { } catch (PhabricatorOAuthProviderException $e) {
return $this->buildErrorResponse(new PhabricatorOAuthFailureView(), $e); return $this->buildErrorResponse(new PhabricatorOAuthFailureView(), $e);
} }