From 667955b8aeca6fc10dd1900db068da7a96b7ef33 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 16 Mar 2018 13:03:36 -0700 Subject: [PATCH] Clarify that a PHUITagView API argument is boolean, not a value in "millimeters" Summary: See PHI454. Ref T13102. This parameter is not named as clearly as it could be. This is a buff to API humor. See also . Test Plan: Read API method, laughed aloud ("LAL") much harder because the humor was now less subtle. Subtle humor is unsuitable for this project. Maniphest Tasks: T13102 Differential Revision: https://secure.phabricator.com/D19231 --- src/view/phui/PHUITagView.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/view/phui/PHUITagView.php b/src/view/phui/PHUITagView.php index 482b3f4400..aa309a4bb6 100644 --- a/src/view/phui/PHUITagView.php +++ b/src/view/phui/PHUITagView.php @@ -117,8 +117,8 @@ final class PHUITagView extends AphrontTagView { return $this; } - public function setSlimShady($mm) { - $this->slimShady = $mm; + public function setSlimShady($is_eminem) { + $this->slimShady = $is_eminem; return $this; }