revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-20 12:30:56 +01:00
Code Issues Releases Wiki Activity

[Redesign] Add color to diff Table of Contents

Browse source 
Summary: Ref T8099. I think these colors make sense, but if any seem wrong, lmk. Colors the type of file change.

Test Plan: Test a few diffs locally, read carefully, ask epriestley.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13502
This commit is contained in:
Chad Little 2015-07-01 11:33:31 -07:00
parent 3b755115c2
commit 66afb92fb3
2 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/applications/differential/constants/DifferentialChangeType.php
View file

@ -38,6 +38,22 @@ final class DifferentialChangeType extends Phobject {
return idx($types, coalesce($type, '?'), '~');
}
public static function getSummaryColorForChangeType($type) {
static $types = array(
self::TYPE_ADD => 'green',
self::TYPE_CHANGE => 'black',
self::TYPE_DELETE => 'red',
self::TYPE_MOVE_AWAY => 'orange',
self::TYPE_COPY_AWAY => 'black',
self::TYPE_MOVE_HERE => 'green',
self::TYPE_COPY_HERE => 'green',
self::TYPE_MULTICOPY => 'orange',
self::TYPE_MESSAGE => 'black',
self::TYPE_CHILD => 'black',
);
return idx($types, coalesce($type, '?'), 'black');
}
public static function getShortNameForFileType($type) {
static $names = array(
self::FILE_TEXT => null,

4
src/applications/differential/view/DifferentialDiffTableOfContentsView.php
View file

@ -56,6 +56,7 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
$this->requireResource('differential-core-view-css');
$this->requireResource('differential-table-of-contents-css');
$this->requireResource('phui-text-css');
$rows = array();
@ -130,6 +131,7 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
$char = DifferentialChangeType::getSummaryCharacterForChangeType($type);
$chartitle = DifferentialChangeType::getFullNameForChangeType($type);
$desc = DifferentialChangeType::getShortNameForFileType($ftype);
$color = DifferentialChangeType::getSummaryColorForChangeType($type);
if ($desc) {
$desc = '('.$desc.')';
}
@ -170,6 +172,8 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
$changeset->getAbsoluteRepositoryPath($this->repository, $this->diff);
}
$char = phutil_tag('span', array('class' => 'phui-text-'.$color), $char);
$rows[] = array(
$char,
$pchar,