revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-30 16:38:21 +01:00
Code Issues Releases Wiki Activity

Fix bug with mousein / mouseout event on comment preview at bottom of page

Browse source 
Summary: these comments aren't associated the same way with the actual changeset ui. ergo, don't update the reticle when mousing over these comments.

Test Plan: moused over comments at bottom - no more JS error. mouse over comments inline - reticle highlighting / de-highlighting still occurred as expected.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1657

Differential Revision: https://secure.phabricator.com/D3299
This commit is contained in:
Bob Trahan 2012-08-15 15:07:56 -07:00
parent fa5a5a0a12
commit 66b5acd275
1 changed files with 12 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js
View file

@ -169,6 +169,7 @@ JX.behavior('differential-edit-inline-comments', function(config) {
hideReticle();
} else {
root = e.getNode('differential-changeset');
if (root) {
var data = e.getNodeData('differential-inline-comment');
var change = e.getNodeData('differential-changeset');
@ -184,6 +185,7 @@ JX.behavior('differential-edit-inline-comments', function(config) {
updateReticle();
}
}
});
var action_handler = function(op, e) {