1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 05:50:55 +01:00

Truncate and scroll task graph tables instead of fitting task titles to the display

Summary: Fixes T11676. Instead of trying to fit task titles to the display, truncate them and let the table scroll.

Test Plan:
Table now scrolls when cramped:

{F1843396}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11676

Differential Revision: https://secure.phabricator.com/D16583
This commit is contained in:
epriestley 2016-09-21 14:41:52 -07:00
parent db2425b300
commit 66c7f22c27
3 changed files with 15 additions and 6 deletions

View file

@ -9,7 +9,7 @@ return array(
'names' => array(
'conpherence.pkg.css' => '80a3fcb3',
'conpherence.pkg.js' => '89b4837e',
'core.pkg.css' => 'eb1298d4',
'core.pkg.css' => 'f7b03076',
'core.pkg.js' => '1d376fa9',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '3fb7f532',
@ -27,7 +27,7 @@ return array(
'rsrc/css/aphront/notification.css' => '3f6c89c9',
'rsrc/css/aphront/panel-view.css' => '8427b78d',
'rsrc/css/aphront/phabricator-nav-view.css' => 'b29426e9',
'rsrc/css/aphront/table-view.css' => '832656fd',
'rsrc/css/aphront/table-view.css' => '3225137a',
'rsrc/css/aphront/tokenizer.css' => '056da01b',
'rsrc/css/aphront/tooltip.css' => '1a07aea8',
'rsrc/css/aphront/typeahead-browse.css' => '8904346a',
@ -607,7 +607,7 @@ return array(
'aphront-list-filter-view-css' => '5d6f0526',
'aphront-multi-column-view-css' => 'fd18389d',
'aphront-panel-view-css' => '8427b78d',
'aphront-table-view-css' => '832656fd',
'aphront-table-view-css' => '3225137a',
'aphront-tokenizer-control-css' => '056da01b',
'aphront-tooltip-css' => '1a07aea8',
'aphront-typeahead-control-css' => 'd4f16145',

View file

@ -51,12 +51,19 @@ final class ManiphestTaskGraph
$assigned = phutil_tag('em', array(), pht('None'));
}
$full_title = $object->getTitle();
$title = id(new PhutilUTF8StringTruncator())
->setMaximumGlyphs(80)
->truncateString($full_title);
$link = phutil_tag(
'a',
array(
'href' => $object->getURI(),
'title' => $full_title,
),
$object->getTitle());
$title);
$link = array(
phutil_tag(
@ -95,8 +102,6 @@ final class ManiphestTaskGraph
));
}
$link = AphrontTableView::renderSingleDisplayLine($link);
return array(
$marker,
$trace,

View file

@ -228,6 +228,10 @@ span.single-display-line-content {
position: static;
}
.aphront-table-view td.object-link {
white-space: nowrap;
}
.aphront-table-view tr.closed td.object-link .object-name,
.aphront-table-view tr.alt-closed td.object-link .object-name {
text-decoration: line-through;