revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-14 02:42:40 +01:00
Code Issues Releases Wiki Activity

Fix an issue with creating tasks directly into workboard columns

Browse source 
Summary:
See <https://discourse.phabricator-community.org/t/tasks-created-via-workboard-column-menu-are-moved-to-wrong-column/2200>. The recent `setIsConduitOnly()` / `setIsFormField()` change (in D19842) disrupted creating tasks directly into a column from the workboard UI.

This field //is// a form field, it just doesn't render a visible control.

Test Plan:
  - Created a task directly into a workboard column. Before: column selection ignored. After: appeared in correct column.
  - Used "move on workboard" comment action.
  - Edited tasks; edited forms for tasks. Didn't observe any collateral damage (weird "Column" fields being present).

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19870
This commit is contained in:
epriestley 2018-12-12 08:09:13 -08:00
parent d8e2bb9f0f
commit 66ff6d4a2c
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/maniphest/editor/ManiphestEditEngine.php
View file

@ -169,7 +169,9 @@ EODOCS
->setConduitDocumentation($column_documentation) ->setConduitDocumentation($column_documentation)
->setAliases(array('columnPHID', 'columns', 'columnPHIDs')) ->setAliases(array('columnPHID', 'columns', 'columnPHIDs'))
->setTransactionType(PhabricatorTransactions::TYPE_COLUMNS) ->setTransactionType(PhabricatorTransactions::TYPE_COLUMNS)
->setIsFormField(false) ->setIsReorderable(false)
->setIsDefaultable(false)
->setIsLockable(false)
->setCommentActionLabel(pht('Move on Workboard')) ->setCommentActionLabel(pht('Move on Workboard'))
->setCommentActionOrder(2000) ->setCommentActionOrder(2000)
->setColumnMap($column_map), ->setColumnMap($column_map),