From 673f0d6c817486ceb9d0b3ed64e5d675d9bf7426 Mon Sep 17 00:00:00 2001 From: David Reuss Date: Mon, 19 Dec 2011 08:37:29 -0800 Subject: [PATCH] Display changed attachments as other changes in Maniphest Summary: When changing attachments, the removed part is squished together with the added parts, making it hard to read. This changes the output so it looks like other changes, seperating each action by a semicolon. Test Plan: Viewed a task where i had attached and deleted revisions, and saw the output look as other changes of same type. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, epriestley Differential Revision: 1238 --- .../view/transactiondetail/ManiphestTransactionDetailView.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/maniphest/view/transactiondetail/ManiphestTransactionDetailView.php b/src/applications/maniphest/view/transactiondetail/ManiphestTransactionDetailView.php index c407475d72..09c30cfeb5 100644 --- a/src/applications/maniphest/view/transactiondetail/ManiphestTransactionDetailView.php +++ b/src/applications/maniphest/view/transactiondetail/ManiphestTransactionDetailView.php @@ -525,7 +525,7 @@ class ManiphestTransactionDetailView extends ManiphestView { } } else { $verb = 'Changed Attached'; - $desc = 'changed attached '.$plural.', added: '.$add_desc. + $desc = 'changed attached '.$plural.', added: '.$add_desc.'; '. 'removed: '.$rem_desc; } break;