From 6915011067d619780c390e3ad9ecb820132bbe84 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 7 Sep 2015 17:18:35 -0700 Subject: [PATCH] Provide an AphrontController implementation of willSendResponse() Summary: This is required by Aphront now but not given a default implementation in the base class. Test Plan: CORGI sites now work. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D14079 --- resources/celerity/map.php | 10 +++++----- src/aphront/AphrontController.php | 4 ++++ webroot/rsrc/css/aphront/list-filter-view.css | 2 +- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index a468a918cf..a478e285db 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -7,7 +7,7 @@ */ return array( 'names' => array( - 'core.pkg.css' => '7d2aec87', + 'core.pkg.css' => 'e9f745e2', 'core.pkg.js' => '47dc9ebb', 'darkconsole.pkg.js' => 'e7393ebb', 'differential.pkg.css' => '2de124c9', @@ -20,7 +20,7 @@ return array( 'rsrc/css/aphront/dark-console.css' => '6378ef3d', 'rsrc/css/aphront/dialog-view.css' => 'fe58b18d', 'rsrc/css/aphront/lightbox-attachment.css' => '7acac05d', - 'rsrc/css/aphront/list-filter-view.css' => 'aa5ffcb9', + 'rsrc/css/aphront/list-filter-view.css' => '5d6f0526', 'rsrc/css/aphront/multi-column.css' => 'fd18389d', 'rsrc/css/aphront/notification.css' => '9c279160', 'rsrc/css/aphront/panel-view.css' => '8427b78d', @@ -104,7 +104,7 @@ return array( 'rsrc/css/application/tokens/tokens.css' => '3d0f239e', 'rsrc/css/application/uiexample/example.css' => '528b19de', 'rsrc/css/core/core.css' => 'a76cefc9', - 'rsrc/css/core/remarkup.css' => '1c4ac273', + 'rsrc/css/core/remarkup.css' => 'ef286a6e', 'rsrc/css/core/syntax.css' => '9fd11da8', 'rsrc/css/core/z-index.css' => '57ddcaa2', 'rsrc/css/diviner/diviner-shared.css' => '5a337049', @@ -493,7 +493,7 @@ return array( 'aphront-bars' => '231ac33c', 'aphront-dark-console-css' => '6378ef3d', 'aphront-dialog-view-css' => 'fe58b18d', - 'aphront-list-filter-view-css' => 'aa5ffcb9', + 'aphront-list-filter-view-css' => '5d6f0526', 'aphront-multi-column-view-css' => 'fd18389d', 'aphront-panel-view-css' => '8427b78d', 'aphront-table-view-css' => 'e3632cc9', @@ -737,7 +737,7 @@ return array( 'phabricator-object-selector-css' => '85ee8ce6', 'phabricator-phtize' => 'd254d646', 'phabricator-prefab' => '6920d200', - 'phabricator-remarkup-css' => '1c4ac273', + 'phabricator-remarkup-css' => 'ef286a6e', 'phabricator-search-results-css' => '7dea472c', 'phabricator-shaped-request' => '7cbe244b', 'phabricator-side-menu-view-css' => 'bec2458e', diff --git a/src/aphront/AphrontController.php b/src/aphront/AphrontController.php index ded0b362a3..4e5df8afbd 100644 --- a/src/aphront/AphrontController.php +++ b/src/aphront/AphrontController.php @@ -37,6 +37,10 @@ abstract class AphrontController extends Phobject { 'processRequest()')); } + public function willSendResponse(AphrontResponse $response) { + return $response; + } + final public function setRequest(AphrontRequest $request) { $this->request = $request; return $this; diff --git a/webroot/rsrc/css/aphront/list-filter-view.css b/webroot/rsrc/css/aphront/list-filter-view.css index f41008cb34..50d43f2383 100644 --- a/webroot/rsrc/css/aphront/list-filter-view.css +++ b/webroot/rsrc/css/aphront/list-filter-view.css @@ -39,7 +39,7 @@ padding: 0 0 4px 4px; } -/* When a list filter view contains two consecuitive forms, lay them out +/* When a list filter view contains two consecutive forms, lay them out without much white space in between them so they look more contiugous. At the time of writing, this is used only in the Diffusion repository search UI. */