From 6929ac539e8673c8638ab8827db593ea4e105420 Mon Sep 17 00:00:00 2001 From: vrana Date: Tue, 17 Apr 2012 11:40:26 -0700 Subject: [PATCH] Print Maniphest tasks in Differential e-mail Test Plan: Send diff with attached task, read e-mail. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1128 Differential Revision: https://secure.phabricator.com/D2256 --- .../differential/mail/base/DifferentialMail.php | 5 +++++ .../reviewrequest/DifferentialReviewRequestMail.php | 11 +++++++++++ 2 files changed, 16 insertions(+) diff --git a/src/applications/differential/mail/base/DifferentialMail.php b/src/applications/differential/mail/base/DifferentialMail.php index 9694306ef7..bd5721b391 100644 --- a/src/applications/differential/mail/base/DifferentialMail.php +++ b/src/applications/differential/mail/base/DifferentialMail.php @@ -354,6 +354,11 @@ EOTEXT; return $this->changesets; } + protected function getManiphestTaskPHIDs() { + return $this->getRevision()->getAttachedPHIDs( + PhabricatorPHIDConstants::PHID_TYPE_TASK); + } + public function setInlineComments(array $inline_comments) { assert_instances_of($inline_comments, 'PhabricatorInlineCommentInterface'); $this->inlineComments = $inline_comments; diff --git a/src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php b/src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php index 40cd29fe75..878140b09b 100644 --- a/src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php +++ b/src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php @@ -71,6 +71,17 @@ abstract class DifferentialReviewRequestMail extends DifferentialMail { $body[] = $this->renderRevisionDetailLink(); $body[] = null; + $task_phids = $this->getManiphestTaskPHIDs(); + if ($task_phids) { + $handles = id(new PhabricatorObjectHandleData($task_phids)) + ->loadHandles(); + $body[] = 'MANIPHEST TASKS'; + foreach ($handles as $handle) { + $body[] = ' '.PhabricatorEnv::getProductionURI($handle->getURI()); + } + $body[] = null; + } + $changesets = $this->getChangesets(); if ($changesets) { $body[] = 'AFFECTED FILES';