revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 12:52:42 +01:00
Code Issues Releases Wiki Activity

Don't spend ridiculous amounts of time rebuilding orderable columns

Browse source 
Summary:
Ref T8575. Because orderable columns need to build custom fields, they are relatively expensive to build. Use the request cache.

(The request cache is technically more correct than `static`, because configuration may change between requests and we may eventually reuse interpreters.)

Test Plan: Saw home page time drop 39% (from 462ms to 283ms).

Reviewers: btrahan, avivey

Reviewed By: avivey

Subscribers: avivey, epriestley

Maniphest Tasks: T8575

Differential Revision: https://secure.phabricator.com/D13322
This commit is contained in:
epriestley 2015-06-16 19:32:58 -07:00
parent 8484adcffd
commit 6933ee5fb8
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
View file

@ -872,6 +872,15 @@ abstract class PhabricatorCursorPagedPolicyAwareQuery
* @task order * @task order
*/ */
public function getOrderableColumns() { public function getOrderableColumns() {
$cache = PhabricatorCaches::getRequestCache();
$class = get_class($this);
$cache_key = 'query.orderablecolumns.'.$class;
$columns = $cache->getKey($cache_key);
if ($columns !== null) {
return $columns;
}
$columns = array( $columns = array(
'id' => array( 'id' => array(
'table' => $this->getPrimaryTableAlias(), 'table' => $this->getPrimaryTableAlias(),
@ -909,6 +918,8 @@ abstract class PhabricatorCursorPagedPolicyAwareQuery
} }
} }
$cache->setKey($cache_key, $columns);
return $columns; return $columns;
} }