Filter archived Badges from UI

Summary: If you archive a badge, remove it's presence in the main Phabricator UI. These are still accessible from `/badges/` for properity. Ref T9944

Test Plan: Archive a badge, weep uncontrollably.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T9944

Differential Revision: https://secure.phabricator.com/D14730

src/applications/people/controller/PhabricatorPeopleProfileController.php

@@ -210,6 +210,7 @@ final class PhabricatorPeopleProfileController
         $badges = id(new PhabricatorBadgesQuery())
           ->setViewer($viewer)
           ->withPHIDs($badge_phids)
+          ->withStatuses(array(PhabricatorBadgesBadge::STATUS_ACTIVE))
           ->execute();
 
         $flex = new PHUIBadgeBoxView();

src/applications/people/event/PhabricatorPeopleHovercardEventListener.php

@@ -87,6 +87,7 @@ final class PhabricatorPeopleHovercardEventListener
         $badges = id(new PhabricatorBadgesQuery())
           ->setViewer($viewer)
           ->withPHIDs($badge_phids)
+          ->withStatuses(array(PhabricatorBadgesBadge::STATUS_ACTIVE))
           ->execute();
 
         foreach ($badges as $badge) {

src/view/phui/PHUITimelineView.php

@@ -263,6 +263,7 @@ final class PHUITimelineView extends AphrontView {
     $all_badges = id(new PhabricatorBadgesQuery())
       ->setViewer($viewer)
       ->withPHIDs($badge_phids)
+      ->withStatuses(array(PhabricatorBadgesBadge::STATUS_ACTIVE))
       ->execute();
     $all_badges = mpull($all_badges, null, 'getPHID');