Explicitly declare method/property visibility

Summary: Self-explanatory.

Test Plan: `arc lint`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: hach-que, Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11278

src/applications/differential/landing/DifferentialLandingStrategy.php

@@ -10,7 +10,7 @@ abstract class DifferentialLandingStrategy {
   /**
    * @return PhabricatorActionView or null.
    */
-  abstract function createMenuItem(
+  public abstract function createMenuItem(
     PhabricatorUser $viewer,
     DifferentialRevision $revision,
     PhabricatorRepository $repository);

src/applications/drydock/controller/DrydockController.php

@@ -2,7 +2,7 @@
 
 abstract class DrydockController extends PhabricatorController {
 
-  abstract function buildSideNavView();
+  public abstract function buildSideNavView();
 
   protected function buildApplicationMenu() {
     return $this->buildSideNavView()->getMenu();

src/applications/owners/storage/__tests__/PhabricatorOwnersPackageTestCase.php

@@ -2,7 +2,7 @@
 
 final class PhabricatorOwnersPackageTestCase extends PhabricatorTestCase {
 
-  function testFindLongestPathsPerPackage() {
+  public function testFindLongestPathsPerPackage() {
     $rows = array(
       array('id' => 1, 'excluded' => 0, 'path' => 'src/'),
       array('id' => 1, 'excluded' => 1, 'path' => 'src/releeph/'),

src/applications/phragment/controller/PhragmentController.php

@@ -201,7 +201,7 @@ abstract class PhragmentController extends PhabricatorController {
       ->addPropertyList($properties);
   }
 
-  function renderConfigurationWarningIfRequired() {
+  public function renderConfigurationWarningIfRequired() {
     $alt = PhabricatorEnv::getEnvConfig('security.alternate-file-domain');
     if ($alt === null) {
       return id(new AphrontErrorView())
@@ -225,7 +225,7 @@ abstract class PhragmentController extends PhabricatorController {
    * are configured otherwise (because the Files app does not support showing
    * the info page to viewers who are not logged in).
    */
-  function isCorrectlyConfigured() {
+  public function isCorrectlyConfigured() {
     $alt = PhabricatorEnv::getEnvConfig('security.alternate-file-domain');
     return $alt !== null;
   }

src/applications/phragment/controller/PhragmentRevertController.php

@@ -64,7 +64,7 @@ final class PhragmentRevertController extends PhragmentController {
     return $this->createDialog($fragment, $version);
   }
 
-  function createDialog(
+  public function createDialog(
     PhragmentFragment $fragment,
     PhragmentFragmentVersion $version) {
 

src/applications/phragment/controller/PhragmentSnapshotDeleteController.php

@@ -36,7 +36,7 @@ final class PhragmentSnapshotDeleteController extends PhragmentController {
     return $this->createDialog();
   }
 
-  function createDialog() {
+  public function createDialog() {
     $request = $this->getRequest();
     $viewer = $request->getUser();
 

src/applications/phragment/controller/PhragmentSnapshotPromoteController.php

@@ -162,7 +162,7 @@ final class PhragmentSnapshotPromoteController extends PhragmentController {
     return $this->createDialog();
   }
 
-  function createDialog() {
+  public function createDialog() {
     $request = $this->getRequest();
     $viewer = $request->getUser();
 

src/infrastructure/log/PhabricatorAccessLog.php

@@ -2,7 +2,7 @@
 
 final class PhabricatorAccessLog {
 
-  static $log;
+  private static $log;
 
   public static function init() {
     // NOTE: This currently has no effect, but some day we may reuse PHP

src/infrastructure/log/PhabricatorSSHLog.php

@@ -2,7 +2,7 @@
 
 final class PhabricatorSSHLog extends Phobject {
 
-  static $log;
+  private static $log;
 
   public static function getLog() {
     if (!self::$log) {

src/infrastructure/storage/patch/PhabricatorSQLPatchList.php

@@ -2,8 +2,8 @@
 
 abstract class PhabricatorSQLPatchList {
 
-  abstract function getNamespace();
+  public abstract function getNamespace();
-  abstract function getPatches();
+  public abstract function getPatches();
 
   /**
    * Examine a directory for `.php` and `.sql` files and build patch