From 69cb76092142c89c83115a4970cac0a079c097dd Mon Sep 17 00:00:00 2001 From: ekubischta Date: Sat, 26 Jun 2021 15:44:56 +0000 Subject: [PATCH] Updated .arclint in Phorge to exclude package-lock.json from Aphlict setup Summary: Aphlict requires a machine generated `package-lock.json` that can trigger linters unnecessarily. This revision excludes it from all linters Test Plan: **Testing** ```name="Fake Change to set off the linter"" diff --git a/support/aphlict/server/package-lock.json b/support/aphlict/server/package-lock.json index 8af62ae233..a417725182 100644 --- a/support/aphlict/server/package-lock.json +++ b/support/aphlict/server/package-lock.json @@ -2,11 +2,12 @@ "name": "aphlict-server", "requires": true, "lockfileVersion": 1, + "testing" : true, "dependencies": { "ws": { "version": "7.5.0", "resolved": "https://registry.npmjs.org/ws/-/ws-7.5.0.tgz", - "integrity": "sha512-6ezXvzOZupqKj4jUqbQ9tXuJNo+BR2gU8fFRk3XCP3e0G6WT414u5ELe6Y0vtp7kmSJ3F7YWObSNr1ESsgi4vw==" + "integrity": "sha512-6ezXvzOZupqKj4jUqbQ9tXuJNo+BR2gU8fFRk3XCP3e0G6WT414u5ELe6Y0vtp7kmSJ3F7YWObSNr1ESsgasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfi4vw==" } } } ``` ```name="arc lint results" root@63c842bff39e:/srv/phorge/phorge# arc lint >>> Lint for support/aphlict/server/package-lock.json: Warning (TXT3) Line Too Long This line is 156 characters long, but the convention is 80 characters. 7 "ws": { 8 "version": "7.5.0", 9 "resolved": "https://registry.npmjs.org/ws/-/ws-7.5.0.tgz", >>> 10 "integrity": "sha512-6ezXvzOZupqKj4jUqbQ9tXuJNo+BR2gU8fFRk3XCP3e0G6WT414u5ELe6Y0vtp7kmSJ3F7YWObSNr1ESsgasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfi4vw==" 11 } 12 } 13 } root@63c842bff39e:/srv/phorge/phorge# ``` Updated change ```name="Change to .arclint" diff --git a/.arclint b/.arclint index f215d93fdc..ca89c601e4 100644 --- a/.arclint +++ b/.arclint @@ -2,7 +2,8 @@ "exclude": [ "(^externals/)", "(^webroot/rsrc/externals/(?!javelin/))", - "(/__tests__/data/)" + "(/__tests__/data/)", + "(^support/aphlict/server/package-lock.json)" ], "linters": { "chmod": { ``` ```name="arc lint results" root@63c842bff39e:/srv/phorge/phorge# arc lint OKAY No lint messages. root@63c842bff39e:/srv/phorge/phorge# ``` Reviewers: O1 Blessed Committers, deadalnix, eax, speck Reviewed By: O1 Blessed Committers, deadalnix, eax, speck Subscribers: speck, tobiaswiese Maniphest Tasks: T15021 Differential Revision: https://we.phorge.it/D25012 --- .arclint | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.arclint b/.arclint index f215d93fdc..ca89c601e4 100644 --- a/.arclint +++ b/.arclint @@ -2,7 +2,8 @@ "exclude": [ "(^externals/)", "(^webroot/rsrc/externals/(?!javelin/))", - "(/__tests__/data/)" + "(/__tests__/data/)", + "(^support/aphlict/server/package-lock.json)" ], "linters": { "chmod": {