revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00
Code Issues Releases Wiki Activity

Added differential revision reviewers information to differential.getrevision

Browse source 
conduit call.

Summary:
The reviewer information was not available for revisions before this.

Test Plan:
Tested with Conduit Console that correct reviewers were returned.

Reviewed By: jungejason
Reviewers: jungejason
Commenters: epriestley
CC: epriestley, tuomaspelkonen, jungejason
Differential Revision: 160
This commit is contained in:
tuomaspelkonen 2011-04-24 00:10:47 -07:00
parent 9367c41a28
commit 6a0234fed3
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/conduit/method/differential/getrevision/ConduitAPI_differential_getrevision_Method.php
View file

@ -47,6 +47,9 @@ class ConduitAPI_differential_getrevision_Method extends ConduitAPIMethod {
throw new ConduitException('ERR_BAD_REVISION'); throw new ConduitException('ERR_BAD_REVISION');
} }
$revision->loadRelationships();
$reviewer_phids = array_values($revision->getReviewers());
$diffs = $revision->loadDiffs(); $diffs = $revision->loadDiffs();
$diff_dicts = array(); $diff_dicts = array();
@ -74,6 +77,7 @@ class ConduitAPI_differential_getrevision_Method extends ConduitAPIMethod {
'blameRevision' => $revision->getBlameRevision(), 'blameRevision' => $revision->getBlameRevision(),
'dateCommitted' => $revision->getDateCommitted(), 'dateCommitted' => $revision->getDateCommitted(),
'lineCount' => $revision->getLineCount(), 'lineCount' => $revision->getLineCount(),
'reviewerPHIDs' => $reviewer_phids,
'diffs' => $diff_dicts, 'diffs' => $diff_dicts,
); );