From 6a0fb7c37f3f7f62c7a00a8031eec7e8a7b6d3d2 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 28 Jan 2015 12:52:58 -0800 Subject: [PATCH] Make grammar more consistent Summary: In Maniphest, we say "X closed by committing ". In Differential, we currently say "X closed by commit ", which sounds nongrammatical to me. Test Plan: grammar'd Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D11544 --- .../differential/storage/DifferentialTransaction.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/differential/storage/DifferentialTransaction.php b/src/applications/differential/storage/DifferentialTransaction.php index e30356a952..2e6fc88472 100644 --- a/src/applications/differential/storage/DifferentialTransaction.php +++ b/src/applications/differential/storage/DifferentialTransaction.php @@ -393,14 +393,14 @@ final class DifferentialTransaction extends PhabricatorApplicationTransaction { if ($committer_name && ($committer_name != $author_name)) { return pht( - '%s closed %s by commit %s (authored by %s).', + '%s closed %s by committing %s (authored by %s).', $author_link, $object_link, $commit_name, $author_name); } else { return pht( - '%s closed %s by commit %s.', + '%s closed %s by committing %s.', $author_link, $object_link, $commit_name);