revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 21:02:41 +01:00
Code Issues Releases Wiki Activity

Set "importStatus" as nonmutable on save()

Browse source 
Summary: Fixes T6840. Depends on D11822, which is a little iffy.

Test Plan:
Verified all references to `importStatus` are either:

  - SQL patches creating the column;
  - reads;
  - writes immediately before an insert; or
  - explicit updates of the column.

That is, I identified no cases of `setImportStatus(X)->save()` on a Commit which may already exist. This //would// break that.

In general, almost all writes go through `$commit->writeImportStatusFlag()`, which is an explicit update.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6840

Differential Revision: https://secure.phabricator.com/D11823
This commit is contained in:
epriestley 2015-02-19 10:36:36 -08:00
parent 751ffe123d
commit 6a60b8cb6f
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -7,7 +7,7 @@
*/ */
return array( return array(
'names' => array( 'names' => array(
'core.pkg.css' => '048d109b', 'core.pkg.css' => '375bfcd1',
'core.pkg.js' => '23d653bb', 'core.pkg.js' => '23d653bb',
'darkconsole.pkg.js' => '8ab24e01', 'darkconsole.pkg.js' => '8ab24e01',
'differential.pkg.css' => '380f07e5', 'differential.pkg.css' => '380f07e5',
@ -104,7 +104,7 @@ return array(
'rsrc/css/application/slowvote/slowvote.css' => '266df6a1', 'rsrc/css/application/slowvote/slowvote.css' => '266df6a1',
'rsrc/css/application/tokens/tokens.css' => '3d0f239e', 'rsrc/css/application/tokens/tokens.css' => '3d0f239e',
'rsrc/css/application/uiexample/example.css' => '528b19de', 'rsrc/css/application/uiexample/example.css' => '528b19de',
'rsrc/css/core/core.css' => 'd7f6ec35', 'rsrc/css/core/core.css' => '8f9b9588',
'rsrc/css/core/remarkup.css' => 'de20f873', 'rsrc/css/core/remarkup.css' => 'de20f873',
'rsrc/css/core/syntax.css' => '56c1ba38', 'rsrc/css/core/syntax.css' => '56c1ba38',
'rsrc/css/core/z-index.css' => '40eb7003', 'rsrc/css/core/z-index.css' => '40eb7003',
@ -715,7 +715,7 @@ return array(
'phabricator-busy' => '6453c869', 'phabricator-busy' => '6453c869',
'phabricator-chatlog-css' => '852140ff', 'phabricator-chatlog-css' => '852140ff',
'phabricator-content-source-view-css' => '4b8b05d4', 'phabricator-content-source-view-css' => '4b8b05d4',
'phabricator-core-css' => 'd7f6ec35', 'phabricator-core-css' => '8f9b9588',
'phabricator-countdown-css' => '86b7b0a0', 'phabricator-countdown-css' => '86b7b0a0',
'phabricator-dashboard-css' => 'c0062064', 'phabricator-dashboard-css' => 'c0062064',
'phabricator-drag-and-drop-file-upload' => '8c49f386', 'phabricator-drag-and-drop-file-upload' => '8c49f386',

3
src/applications/repository/storage/PhabricatorRepositoryCommit.php
View file

@ -99,6 +99,9 @@ final class PhabricatorRepositoryCommit
'unique' => true, 'unique' => true,
), ),
), ),
self::CONFIG_NO_MUTATE => array(
'importStatus',
),
) + parent::getConfiguration(); ) + parent::getConfiguration();
} }